[jira] [Comment Edited] (CALCITE-1336) Add view name to the ViewExpander

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405419#comment-15405419 ] 

Julian Hyde edited comment on CALCITE-1336 at 8/3/16 8:06 AM:
--------------------------------------------------------------

Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/7936185; thanks for the PR, [~julienledem]!


was (Author: julianhyde):
Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/2b953a09; thanks for the PR, [~julienledem]!

> Add view name to the ViewExpander
> ---------------------------------
>
>                 Key: CALCITE-1336
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1336
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Julien Le Dem
>            Assignee: Julian Hyde
>             Fix For: 1.9.0
>
>
> The ViewExpander.expandView() call already has the schema path that contains the view but not the view name itself.
> In some context it is useful to also know the name of the view being expanded.
> current call:
> {code}
> RelRoot expandView(
>         RelDataType rowType,
>         String queryString,
>         SchemaPlus rootSchema,
>         List<String> schemaPath);
> {code}
> proposed:
> {code}
> RelRoot expandView(
>         RelDataType rowType,
>         String queryString,
>         SchemaPlus rootSchema,
>         List<String> schemaPath,
>         String viewName);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)