You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/08/01 15:47:39 UTC
Review Request 68146: Added actions and ACLs to authorize removal of
resource providers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68146/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Bugs: MESOS-8403
https://issues.apache.org/jira/browse/MESOS-8403
Repository: mesos
Description
-------
Added actions and ACLs to authorize removal of resource providers.
Diffs
-----
include/mesos/authorizer/acls.proto 1777c04316bfd7493894f0e782f170fe8437aafe
include/mesos/authorizer/authorizer.proto 8b5fa09f389ca4c26f8390d35af32c4cdd561418
src/authorizer/local/authorizer.cpp abf5b4663cd517fb6d69b5373dd0e6520e87cf8e
src/tests/authorization_tests.cpp 41ecac29a53f6ad9553cbf0a1121e1f3cff50df8
Diff: https://reviews.apache.org/r/68146/diff/1/
Testing
-------
`make check`
Additional testing with the test case added in https://reviews.apache.org/r/68147/.
Thanks,
Benjamin Bannier
Re: Review Request 68146: Added actions and ACLs to authorize removal
of resource providers.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68146/
-----------------------------------------------------------
(Updated Aug. 16, 2018, 4:31 p.m.)
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Changes
-------
Reordered declarations.
Bugs: MESOS-8403
https://issues.apache.org/jira/browse/MESOS-8403
Repository: mesos
Description
-------
Added actions and ACLs to authorize removal of resource providers.
Diffs (updated)
-----
include/mesos/authorizer/acls.proto f5d2580c29df5c9917a5ce0d5df876b3511438df
include/mesos/authorizer/authorizer.proto 7330416b44ea12009362c1aae7935b079822efe1
src/authorizer/local/authorizer.cpp f99b88e10df1e0959f1ddd2e45374862c2dc0a5b
src/tests/authorization_tests.cpp de57fc97addee4bab9eafae6109a72cbb0c2f4ce
Diff: https://reviews.apache.org/r/68146/diff/4/
Changes: https://reviews.apache.org/r/68146/diff/3-4/
Testing
-------
`make check`
Additional testing with the test case added in https://reviews.apache.org/r/68147/.
Thanks,
Benjamin Bannier
Re: Review Request 68146: Added actions and ACLs to authorize removal
of resource providers.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68146/#review207349
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/authorizer/acls.proto
Lines 497 (patched)
<https://reviews.apache.org/r/68146/#comment290702>
s/`to remove resource providers`/`to mark resource providers as gone`/
include/mesos/authorizer/acls.proto
Lines 655 (patched)
<https://reviews.apache.org/r/68146/#comment290704>
Any reason to choose this order? It seems more natural to put the two resource provider ACLs together, like the order you use in the following switch cases.
src/authorizer/local/authorizer.cpp
Line 1565 (original), 1580 (patched)
<https://reviews.apache.org/r/68146/#comment290705>
Move this upward?
src/authorizer/local/authorizer.cpp
Line 1766 (original), 1789 (patched)
<https://reviews.apache.org/r/68146/#comment290706>
Make the order consistent?
- Chun-Hung Hsiao
On Aug. 15, 2018, 1:53 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68146/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2018, 1:53 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added actions and ACLs to authorize removal of resource providers.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/acls.proto f5d2580c29df5c9917a5ce0d5df876b3511438df
> include/mesos/authorizer/authorizer.proto 7330416b44ea12009362c1aae7935b079822efe1
> src/authorizer/local/authorizer.cpp f99b88e10df1e0959f1ddd2e45374862c2dc0a5b
> src/tests/authorization_tests.cpp de57fc97addee4bab9eafae6109a72cbb0c2f4ce
>
>
> Diff: https://reviews.apache.org/r/68146/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68146: Added actions and ACLs to authorize removal
of resource providers.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68146/
-----------------------------------------------------------
(Updated Aug. 15, 2018, 3:53 p.m.)
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Changes
-------
Addressed issues raised by Chun.
Bugs: MESOS-8403
https://issues.apache.org/jira/browse/MESOS-8403
Repository: mesos
Description
-------
Added actions and ACLs to authorize removal of resource providers.
Diffs (updated)
-----
include/mesos/authorizer/acls.proto f5d2580c29df5c9917a5ce0d5df876b3511438df
include/mesos/authorizer/authorizer.proto 7330416b44ea12009362c1aae7935b079822efe1
src/authorizer/local/authorizer.cpp f99b88e10df1e0959f1ddd2e45374862c2dc0a5b
src/tests/authorization_tests.cpp de57fc97addee4bab9eafae6109a72cbb0c2f4ce
Diff: https://reviews.apache.org/r/68146/diff/3/
Changes: https://reviews.apache.org/r/68146/diff/2-3/
Testing
-------
`make check`
Additional testing with the test case added in https://reviews.apache.org/r/68147/.
Thanks,
Benjamin Bannier
Re: Review Request 68146: Added actions and ACLs to authorize removal
of resource providers.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On Aug. 15, 2018, 4:42 a.m., Chun-Hung Hsiao wrote:
> > include/mesos/authorizer/acls.proto
> > Lines 656 (patched)
> > <https://reviews.apache.org/r/68146/diff/2/?file=2066226#file2066226line656>
> >
> > `mark_resource_providers_gone`
Re-open this issue becasue an `s` is missing.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68146/#review207301
-----------------------------------------------------------
On Aug. 15, 2018, 1:53 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68146/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2018, 1:53 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added actions and ACLs to authorize removal of resource providers.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/acls.proto f5d2580c29df5c9917a5ce0d5df876b3511438df
> include/mesos/authorizer/authorizer.proto 7330416b44ea12009362c1aae7935b079822efe1
> src/authorizer/local/authorizer.cpp f99b88e10df1e0959f1ddd2e45374862c2dc0a5b
> src/tests/authorization_tests.cpp de57fc97addee4bab9eafae6109a72cbb0c2f4ce
>
>
> Diff: https://reviews.apache.org/r/68146/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68146: Added actions and ACLs to authorize removal
of resource providers.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68146/#review207301
-----------------------------------------------------------
include/mesos/authorizer/acls.proto
Lines 512 (patched)
<https://reviews.apache.org/r/68146/#comment290630>
How about `MarkResourceProviderGone`?
include/mesos/authorizer/acls.proto
Lines 656 (patched)
<https://reviews.apache.org/r/68146/#comment290631>
`mark_resource_providers_gone`
- Chun-Hung Hsiao
On Aug. 1, 2018, 3:47 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68146/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 3:47 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added actions and ACLs to authorize removal of resource providers.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/acls.proto f5d2580c29df5c9917a5ce0d5df876b3511438df
> include/mesos/authorizer/authorizer.proto 7330416b44ea12009362c1aae7935b079822efe1
> src/authorizer/local/authorizer.cpp f99b88e10df1e0959f1ddd2e45374862c2dc0a5b
> src/tests/authorization_tests.cpp 0c3e59eb91d334e1a0b5860b84fcdf87bd91203f
>
>
> Diff: https://reviews.apache.org/r/68146/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>