You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by ottobackwards <gi...@git.apache.org> on 2018/06/17 14:56:07 UTC

[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header

Github user ottobackwards commented on the issue:

    https://github.com/apache/nifi/pull/2800
  
    This looks good, just two comments.
    
    1. If we are going to add support for non-ascii, the test should test non-ascii, can we add that?
    2. We now have a pattern of use in two places using with a try catch around setting headers with encoding, maybe we should have a function?


---