[GitHub] [kafka] ijuma commented on a change in pull request #10457: KAFKA-12588: remove --zookeeper option from topic command

[GitBox <gi...@apache.org>]

ijuma commented on a change in pull request #10457:
URL: https://github.com/apache/kafka/pull/10457#discussion_r605602884



##########
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##########
@@ -670,9 +505,9 @@ object TopicCommand extends Logging {
     private val reportUnavailablePartitionsOpt = parser.accepts("unavailable-partitions",
       "if set when describing topics, only show partitions whose leader is not available")
     private val reportUnderMinIsrPartitionsOpt = parser.accepts("under-min-isr-partitions",
-      "if set when describing topics, only show partitions whose isr count is less than the configured minimum. Not supported with the --zookeeper option.")
+      "if set when describing topics, only show partitions whose isr count is less than the configured minimum.")
     private val reportAtMinIsrPartitionsOpt = parser.accepts("at-min-isr-partitions",
-      "if set when describing topics, only show partitions whose isr count is equal to the configured minimum. Not supported with the --zookeeper option.")
+      "if set when describing topics, only show partitions whose isr count is equal to the configured minimum.")

Review comment:
       We have this line:
   
   ```
       // This is not currently used, but we keep it for compatibility
       parser.accepts("force", "Suppress console prompts")
   ```
   
   Was this deprecated also? Can we remove it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org