You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/12/06 00:08:36 UTC
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14861
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
The following patters and documented:
MONTH, MON, DAY, DY, D, Q, WW, W
Also added boundaries for TZM and TZM (IMPALKA-9217).
Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
---
M docs/topics/impala_conversion_functions.xml
1 file changed, 705 insertions(+), 303 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/14861/1
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14861 )
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/547/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 00:29:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14861
to look at the new patch set (#3).
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
The following patters are documented:
MONTH, MON, DAY, DY, D, Q, WW, W
Also added boundaries for TZH and TZM (IMPALA-9217).
Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
---
M docs/topics/impala_conversion_functions.xml
1 file changed, 839 insertions(+), 303 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/14861/3
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14861 )
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/547/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 00:08:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14861 )
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/552/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Dec 2019 19:15:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14861 )
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14861/2/docs/topics/impala_conversion_functions.xml
File docs/topics/impala_conversion_functions.xml:
http://gerrit.cloudera.org:8080/#/c/14861/2/docs/topics/impala_conversion_functions.xml@426
PS2, Line 426: Converts a 2-digit month number.
> Hmm, what about this one?
Done
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Dec 2019 18:54:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14861 )
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
The following patters are documented:
MONTH, MON, DAY, DY, D, Q, WW, W
Also added boundaries for TZH and TZM (IMPALA-9217).
Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Reviewed-on: http://gerrit.cloudera.org:8080/14861
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
---
M docs/topics/impala_conversion_functions.xml
1 file changed, 839 insertions(+), 303 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Alex Rodoni: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14861 )
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
Patch Set 1:
(14 comments)
Thanks for taking care of this!
http://gerrit.cloudera.org:8080/#/c/14861/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14861/1//COMMIT_MSG@9
PS1, Line 9: and
nit: are?
http://gerrit.cloudera.org:8080/#/c/14861/1//COMMIT_MSG@12
PS1, Line 12: TZM
TZH
http://gerrit.cloudera.org:8080/#/c/14861/1//COMMIT_MSG@12
PS1, Line 12: IMPALKA
nit: IMPALA
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml
File docs/topics/impala_conversion_functions.xml:
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@407
PS1, Line 407: MONTH
Can you also mention that the case is also important when this token is given in the format? e.g. MONTH, Month, month would require different casing of the input in a string to datetime conversion and would produce differently cased outputs in a datetime to string conversion? e.g. respectively "JULY", "July", "july"
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@410
PS1, Line 410: Month name
"Full month name" would be more self-explanatory
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@413
PS1, Line 413: string to date/time conversions
For string to datetime conversions could you please add that the expected inputs are in the form of the textual month name without trailing spaces ("June", "August" etc.) but if an FX modifier is active for the token then trailing spaces are also expected ("June ", "August ")?
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@413
PS1, Line 413: returns
nit: converts to
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@415
PS1, Line 415: <p>
: In date/time to string conversions, returns a 9-character-long full
: month name with trailing spaces.
: </p>
I'd also mention that providing FM modifier for this token would result in omitting the trailing spaces.
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@423
PS1, Line 423: <codeph>MON</codeph>
Similarly to the month token can you mention the differences between MON, Mon, mon?
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@432
PS1, Line 432: <codeph>WW</codeph>
Coudl you mention that 1st week begins on January 1st and ends on the 7th, and so on?
This is relevant as milestone 4 will have a new week numbering token besides this where the 1st week starts from the first Monday of the year.
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@445
PS1, Line 445: <codeph>W</codeph>
Again, please add: 1st week starts on the 1st of the month and ends on the 7th, and so on.
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@458
PS1, Line 458: <codeph>D</codeph>
Please add: 1 means Sunday, 2 means Monday, and so on.
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@500
PS1, Line 500: <codeph>DAY</codeph>
Please mention the following things similarly to the full month name token:
- Differences between DAY, Day and day
- In datetime to string conversion an FM modifier can be used to omit trailing spaces.
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@520
PS1, Line 520: <codeph>DY</codeph>
Please mention DY, Dy, and dy for different cases.
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 12:34:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14861 )
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Dec 2019 19:16:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14861 )
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/549/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 20:39:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14861 )
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/549/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 21:00:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14861
to look at the new patch set (#2).
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
The following patters are documented:
MONTH, MON, DAY, DY, D, Q, WW, W
Also added boundaries for TZH and TZM (IMPALA-9217).
Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
---
M docs/topics/impala_conversion_functions.xml
1 file changed, 829 insertions(+), 303 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/14861/2
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14861 )
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
Patch Set 1:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/14861/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14861/1//COMMIT_MSG@9
PS1, Line 9: and
> nit: are?
Done
http://gerrit.cloudera.org:8080/#/c/14861/1//COMMIT_MSG@12
PS1, Line 12: IMPALKA
> nit: IMPALA
Done
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml
File docs/topics/impala_conversion_functions.xml:
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@407
PS1, Line 407: MONTH
> Can you also mention that the case is also important when this token is giv
Done
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@410
PS1, Line 410: Month name
> "Full month name" would be more self-explanatory
Done
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@413
PS1, Line 413: returns
> nit: converts to
Done
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@413
PS1, Line 413: string to date/time conversions
> For string to datetime conversions could you please add that the expected i
9-character-long, right?
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@415
PS1, Line 415: <p>
: In date/time to string conversions, returns a 9-character-long full
: month name with trailing spaces.
: </p>
> I'd also mention that providing FM modifier for this token would result in
Done
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@423
PS1, Line 423: <codeph>MON</codeph>
> Similarly to the month token can you mention the differences between MON, M
Done
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@432
PS1, Line 432: <codeph>WW</codeph>
> Coudl you mention that 1st week begins on January 1st and ends on the 7th,
Done
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@445
PS1, Line 445: <codeph>W</codeph>
> Again, please add: 1st week starts on the 1st of the month and ends on the
Done
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@458
PS1, Line 458: <codeph>D</codeph>
> Please add: 1 means Sunday, 2 means Monday, and so on.
Done
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@500
PS1, Line 500: <codeph>DAY</codeph>
> Please mention the following things similarly to the full month name token:
Done
http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@520
PS1, Line 520: <codeph>DY</codeph>
> Please mention DY, Dy, and dy for different cases.
Done
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 20:37:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14861 )
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Apart from one comment, I'm fine with this patch. Please take care of that one and you can carry over my +2 once that's done.
http://gerrit.cloudera.org:8080/#/c/14861/2/docs/topics/impala_conversion_functions.xml
File docs/topics/impala_conversion_functions.xml:
http://gerrit.cloudera.org:8080/#/c/14861/2/docs/topics/impala_conversion_functions.xml@426
PS2, Line 426: Converts a 2-digit month number.
Hmm, what about this one?
"Converts textual month names into 2-digit month numbers"
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Dec 2019 10:25:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14861 )
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/552/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b
Gerrit-Change-Number: 14861
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Dec 2019 18:54:18 +0000
Gerrit-HasComments: No