You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/01 08:15:50 UTC
[GitHub] [spark] advancedxy opened a new pull request #34455: [SPARK-37176] sync JsonInferSchema#infer method's exception handle
advancedxy opened a new pull request #34455:
URL: https://github.com/apache/spark/pull/34455
logic with JacksonParser#parse method
### What changes were proposed in this pull request?
Change `JsonInferSchema#infer`'s exception handle logic to be aligned with `JacksonParser#parse`
### Why are the changes needed?
To reduce behavior inconsistency, users can have the same expectation for schema infer and json parse when dealing with some malformed input.
### Does this PR introduce _any_ user-facing change?
Yes.
Before this patch, json's inferring schema could be failed for some malformed input but succeeded when parsing.
After this patch, they have the same exception handle logic.
### How was this patch tested?
Added one new test and modify one exist test to cover the new case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] advancedxy commented on a change in pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
advancedxy commented on a change in pull request #34455:
URL: https://github.com/apache/spark/pull/34455#discussion_r740781759
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
##########
@@ -68,14 +83,18 @@ private[sql] class JsonInferSchema(options: JSONOptions) extends Serializable {
Some(inferField(parser))
}
} catch {
- case e @ (_: RuntimeException | _: JsonProcessingException) => parseMode match {
- case PermissiveMode =>
- Some(StructType(Seq(StructField(columnNameOfCorruptRecord, StringType))))
- case DropMalformedMode =>
- None
- case FailFastMode =>
- throw QueryExecutionErrors.malformedRecordsDetectedInSchemaInferenceError(e)
- }
+ case e: SparkUpgradeException => throw e
+ case e @ (_: RuntimeException | _: JsonProcessingException |
+ _: MalformedInputException) =>
Review comment:
The `SparkUpgradeException` is not necessary, so I removed this exception handling.
I add a new test to cover `MalformedInputException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] advancedxy commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
advancedxy commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957170019
> im okay with this change. I think this is dupe of #33706 but let's go ahead with this PR. cc @yaooqinn FYI
Ah, I didn't see that one. @yaooqinn would like to finish your PR? If so, you can copied some of my tests into your commit. Otherwise, I will proceed with PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957173591
I am OK, this change looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #34455:
URL: https://github.com/apache/spark/pull/34455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] advancedxy commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
advancedxy commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957170019
> im okay with this change. I think this is dupe of #33706 but let's go ahead with this PR. cc @yaooqinn FYI
Ah, I didn't see that one. @yaooqinn would like to finish your PR? If so, you can copied some of my tests into your commit. Otherwise, I will proceed with PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34455: [SPARK-37176] sync JsonInferSchema#infer method's exception handle
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-956031320
@advancedxy Thank you for the ping. I will review this PR today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957134486
im okay with this change. I think this is dupe of https://github.com/apache/spark/pull/33706 but let's go ahead with this PR. cc @yaooqinn FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957264008
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49311/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957134486
im okay with this change. I think this is dupe of https://github.com/apache/spark/pull/33706 but let's go ahead with this PR. cc @yaooqinn FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957173286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957166042
**[Test build #144841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144841/testReport)** for PR 34455 at commit [`8dae181`](https://github.com/apache/spark/commit/8dae1818f724db02c2d26d9d235fca1ed3498f9b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957223557
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49311/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #34455:
URL: https://github.com/apache/spark/pull/34455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957257060
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49311/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957166042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957264008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] advancedxy commented on pull request #34455: [SPARK-37176] sync JsonInferSchema#infer method's exception handle
Posted by GitBox <gi...@apache.org>.
advancedxy commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-956026367
Hi, @MaxGekk could you review this PR in your spare time since you touched the relevant(encoding related) code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957264008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk edited a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
MaxGekk edited a comment on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957269638
+1, LGTM. Merging to master.
Thank you, @advancedxy and @yaooqinn @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957495211
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144841/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957166042
**[Test build #144841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144841/testReport)** for PR 34455 at commit [`8dae181`](https://github.com/apache/spark/commit/8dae1818f724db02c2d26d9d235fca1ed3498f9b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] advancedxy commented on a change in pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
advancedxy commented on a change in pull request #34455:
URL: https://github.com/apache/spark/pull/34455#discussion_r740082391
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
##########
@@ -68,14 +83,18 @@ private[sql] class JsonInferSchema(options: JSONOptions) extends Serializable {
Some(inferField(parser))
}
} catch {
- case e @ (_: RuntimeException | _: JsonProcessingException) => parseMode match {
- case PermissiveMode =>
- Some(StructType(Seq(StructField(columnNameOfCorruptRecord, StringType))))
- case DropMalformedMode =>
- None
- case FailFastMode =>
- throw QueryExecutionErrors.malformedRecordsDetectedInSchemaInferenceError(e)
- }
+ case e: SparkUpgradeException => throw e
+ case e @ (_: RuntimeException | _: JsonProcessingException |
+ _: MalformedInputException) =>
Review comment:
Good point. Will add later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957134486
im okay with this change. I think this is dupe of https://github.com/apache/spark/pull/33706 but let's go ahead with this PR. cc @yaooqinn FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-956114962
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49276/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957166042
**[Test build #144841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144841/testReport)** for PR 34455 at commit [`8dae181`](https://github.com/apache/spark/commit/8dae1818f724db02c2d26d9d235fca1ed3498f9b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk edited a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
MaxGekk edited a comment on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957269638
+1, LGTM. Merging to master.
Thank you, @advancedxy and @yaooqinn @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #34455:
URL: https://github.com/apache/spark/pull/34455#discussion_r740058005
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
##########
@@ -68,14 +83,18 @@ private[sql] class JsonInferSchema(options: JSONOptions) extends Serializable {
Some(inferField(parser))
}
} catch {
- case e @ (_: RuntimeException | _: JsonProcessingException) => parseMode match {
- case PermissiveMode =>
- Some(StructType(Seq(StructField(columnNameOfCorruptRecord, StringType))))
- case DropMalformedMode =>
- None
- case FailFastMode =>
- throw QueryExecutionErrors.malformedRecordsDetectedInSchemaInferenceError(e)
- }
+ case e: SparkUpgradeException => throw e
+ case e @ (_: RuntimeException | _: JsonProcessingException |
+ _: MalformedInputException) =>
Review comment:
Could you write tests or modify existing tests to check new exception handling:
- SparkUpgradeException
- MalformedInputException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-956234430
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144806/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957173286
@advancedxy Your PR has better test coverage for now. I am waiting for test results and going to merge it if @HyukjinKwon @yaooqinn don't mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-956034570
**[Test build #144806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144806/testReport)** for PR 34455 at commit [`03009c1`](https://github.com/apache/spark/commit/03009c1c3d20e1f8a4a686bdeb33c66f5e1ee169).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957269638
+1, LGTM. Merging to master.
Thank youm @advancedxy and @yaooqinn @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957173286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957166042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-956230853
**[Test build #144806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144806/testReport)** for PR 34455 at commit [`03009c1`](https://github.com/apache/spark/commit/03009c1c3d20e1f8a4a686bdeb33c66f5e1ee169).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-956034570
**[Test build #144806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144806/testReport)** for PR 34455 at commit [`03009c1`](https://github.com/apache/spark/commit/03009c1c3d20e1f8a4a686bdeb33c66f5e1ee169).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-956234430
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144806/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] advancedxy commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
advancedxy commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957170019
> im okay with this change. I think this is dupe of #33706 but let's go ahead with this PR. cc @yaooqinn FYI
Ah, I didn't see that one. @yaooqinn would like to finish your PR? If so, you can copied some of my tests into your commit. Otherwise, I will proceed with PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #34455:
URL: https://github.com/apache/spark/pull/34455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957495211
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144841/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957264008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957264008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-956064516
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49276/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-956114962
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49276/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-956107537
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49276/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957488906
**[Test build #144841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144841/testReport)** for PR 34455 at commit [`8dae181`](https://github.com/apache/spark/commit/8dae1818f724db02c2d26d9d235fca1ed3498f9b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957173591
I am OK, this change looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] advancedxy commented on a change in pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
advancedxy commented on a change in pull request #34455:
URL: https://github.com/apache/spark/pull/34455#discussion_r740781759
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
##########
@@ -68,14 +83,18 @@ private[sql] class JsonInferSchema(options: JSONOptions) extends Serializable {
Some(inferField(parser))
}
} catch {
- case e @ (_: RuntimeException | _: JsonProcessingException) => parseMode match {
- case PermissiveMode =>
- Some(StructType(Seq(StructField(columnNameOfCorruptRecord, StringType))))
- case DropMalformedMode =>
- None
- case FailFastMode =>
- throw QueryExecutionErrors.malformedRecordsDetectedInSchemaInferenceError(e)
- }
+ case e: SparkUpgradeException => throw e
+ case e @ (_: RuntimeException | _: JsonProcessingException |
+ _: MalformedInputException) =>
Review comment:
The `SparkUpgradeException` is not necessary, so I removed this exception handling.
I add a new test to cover `MalformedInputException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] advancedxy commented on a change in pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
advancedxy commented on a change in pull request #34455:
URL: https://github.com/apache/spark/pull/34455#discussion_r740781759
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
##########
@@ -68,14 +83,18 @@ private[sql] class JsonInferSchema(options: JSONOptions) extends Serializable {
Some(inferField(parser))
}
} catch {
- case e @ (_: RuntimeException | _: JsonProcessingException) => parseMode match {
- case PermissiveMode =>
- Some(StructType(Seq(StructField(columnNameOfCorruptRecord, StringType))))
- case DropMalformedMode =>
- None
- case FailFastMode =>
- throw QueryExecutionErrors.malformedRecordsDetectedInSchemaInferenceError(e)
- }
+ case e: SparkUpgradeException => throw e
+ case e @ (_: RuntimeException | _: JsonProcessingException |
+ _: MalformedInputException) =>
Review comment:
The `SparkUpgradeException` is not necessary, so I removed this exception handling.
I add a new test to cover `MalformedInputException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957264008
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49311/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957166042
**[Test build #144841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144841/testReport)** for PR 34455 at commit [`8dae181`](https://github.com/apache/spark/commit/8dae1818f724db02c2d26d9d235fca1ed3498f9b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk edited a comment on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
MaxGekk edited a comment on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957269638
+1, LGTM. Merging to master.
Thank you, @advancedxy and @yaooqinn @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #34455: [SPARK-37176][SQL] Sync JsonInferSchema#infer method's exception handle logic with JacksonParser#parse method
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #34455:
URL: https://github.com/apache/spark/pull/34455#issuecomment-957173591
I am OK, this change looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org