You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2022/10/14 05:40:26 UTC
Review Request 74167: RANGER-3888: fixed unit test failures caused by earlier commit in RANGER-3888 - #2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74167/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
Bugs: RANGER-3888
https://issues.apache.org/jira/browse/RANGER-3888
Repository: ranger
Description
-------
- updated unit tests to add more details in failure messages to make troubleshooting easier
- updated tests for valid range for month: 0-11
- updated validation logic to fail only when a given range is completely outside the valid range; earlier validation used to fail even if either min or max fall out of range
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java 1e38118f7
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 59c50e4ca
agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-invalid.json 321df659f
agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid-and-applicable.json 76489094a
agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid.json d42d3e6d1
Diff: https://reviews.apache.org/r/74167/diff/1/
Testing
-------
- verified that TestPolicyEngine tests pass successfully
Thanks,
Madhan Neethiraj
Re: Review Request 74167: RANGER-3888: fixed unit test failures caused by earlier commit in RANGER-3888 - #2
Posted by Madhan Neethiraj <ma...@apache.org>.
> On Oct. 26, 2022, 2:15 p.m., Abhay Kulkarni wrote:
> > agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid-and-applicable.json
> > Line 383 (original), 383 (patched)
> > <https://reviews.apache.org/r/74167/diff/1/?file=2270656#file2270656line383>
> >
> > This test used to fail. Does the change in RangerScheduleValidator.java (lines 366 and 375) fix that failure?
Yes, that is correct.
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74167/#review224830
-----------------------------------------------------------
On Oct. 14, 2022, 5:40 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74167/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2022, 5:40 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3888
> https://issues.apache.org/jira/browse/RANGER-3888
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - updated unit tests to add more details in failure messages to make troubleshooting easier
> - updated tests for valid range for month: 0-11
> - updated validation logic to fail only when a given range is completely outside the valid range; earlier validation used to fail even if either min or max fall out of range
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java 1e38118f7
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 59c50e4ca
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-invalid.json 321df659f
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid-and-applicable.json 76489094a
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid.json d42d3e6d1
>
>
> Diff: https://reviews.apache.org/r/74167/diff/1/
>
>
> Testing
> -------
>
> - verified that TestPolicyEngine tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74167: RANGER-3888: fixed unit test failures caused by earlier commit in RANGER-3888 - #2
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74167/#review224830
-----------------------------------------------------------
agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid-and-applicable.json
Line 383 (original), 383 (patched)
<https://reviews.apache.org/r/74167/#comment313700>
This test used to fail. Does the change in RangerScheduleValidator.java (lines 366 and 375) fix that failure?
- Abhay Kulkarni
On Oct. 14, 2022, 5:40 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74167/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2022, 5:40 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3888
> https://issues.apache.org/jira/browse/RANGER-3888
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - updated unit tests to add more details in failure messages to make troubleshooting easier
> - updated tests for valid range for month: 0-11
> - updated validation logic to fail only when a given range is completely outside the valid range; earlier validation used to fail even if either min or max fall out of range
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java 1e38118f7
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 59c50e4ca
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-invalid.json 321df659f
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid-and-applicable.json 76489094a
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid.json d42d3e6d1
>
>
> Diff: https://reviews.apache.org/r/74167/diff/1/
>
>
> Testing
> -------
>
> - verified that TestPolicyEngine tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74167: RANGER-3888: fixed unit test failures caused by earlier commit in RANGER-3888 - #2
Posted by Madhan Neethiraj <ma...@apache.org>.
> On Oct. 27, 2022, 6:22 p.m., Dineshkumar Yadav wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java
> > Line 366 (original), 366 (patched)
> > <https://reviews.apache.org/r/74167/diff/1/?file=2270653#file2270653line366>
> >
> > This seems to be not satisfying condition.
Updated validation to handle year ranger differently from the rest - month/dayOfMonth/dayOfWeek/hour/minute.
> On Oct. 27, 2022, 6:22 p.m., Dineshkumar Yadav wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java
> > Line 375 (original), 375 (patched)
> > <https://reviews.apache.org/r/74167/diff/1/?file=2270653#file2270653line375>
> >
> > This seems to be not satisfying condition
Updated validation to handle year ranger differently from the rest - month/dayOfMonth/dayOfWeek/hour/minute.
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74167/#review224839
-----------------------------------------------------------
On Oct. 27, 2022, 8:27 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74167/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2022, 8:27 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3888
> https://issues.apache.org/jira/browse/RANGER-3888
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - updated unit tests to add more details in failure messages to make troubleshooting easier
> - updated tests for valid range for month: 0-11
> - updated validation logic to fail only when a given range is completely outside the valid range; earlier validation used to fail even if either min or max fall out of range
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java 1e38118f7
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 59c50e4ca
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-invalid.json 321df659f
>
>
> Diff: https://reviews.apache.org/r/74167/diff/2/
>
>
> Testing
> -------
>
> - verified that TestPolicyEngine tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74167: RANGER-3888: fixed unit test failures caused by earlier commit in RANGER-3888 - #2
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74167/#review224839
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java
Line 366 (original), 366 (patched)
<https://reviews.apache.org/r/74167/#comment313716>
This seems to be not satisfying condition.
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java
Line 375 (original), 375 (patched)
<https://reviews.apache.org/r/74167/#comment313717>
This seems to be not satisfying condition
- Dineshkumar Yadav
On Oct. 14, 2022, 5:40 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74167/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2022, 5:40 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3888
> https://issues.apache.org/jira/browse/RANGER-3888
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - updated unit tests to add more details in failure messages to make troubleshooting easier
> - updated tests for valid range for month: 0-11
> - updated validation logic to fail only when a given range is completely outside the valid range; earlier validation used to fail even if either min or max fall out of range
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java 1e38118f7
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 59c50e4ca
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-invalid.json 321df659f
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid-and-applicable.json 76489094a
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid.json d42d3e6d1
>
>
> Diff: https://reviews.apache.org/r/74167/diff/1/
>
>
> Testing
> -------
>
> - verified that TestPolicyEngine tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74167: RANGER-3888: fixed unit test failures caused by earlier commit in RANGER-3888 - #2
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74167/#review224842
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java
Line 376 (original), 399 (patched)
<https://reviews.apache.org/r/74167/#comment313720>
Please use Val2 instead of val1 while printing error msg.
- Dineshkumar Yadav
On Oct. 27, 2022, 8:27 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74167/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2022, 8:27 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3888
> https://issues.apache.org/jira/browse/RANGER-3888
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - updated unit tests to add more details in failure messages to make troubleshooting easier
> - updated tests for valid range for month: 0-11
> - updated validation logic to fail only when a given range is completely outside the valid range; earlier validation used to fail even if either min or max fall out of range
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java 1e38118f7
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 59c50e4ca
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-invalid.json 321df659f
>
>
> Diff: https://reviews.apache.org/r/74167/diff/2/
>
>
> Testing
> -------
>
> - verified that TestPolicyEngine tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74167: RANGER-3888: fixed unit test failures caused by earlier commit in RANGER-3888 - #2
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74167/#review224843
-----------------------------------------------------------
Ship it!
Ship It!
- Dineshkumar Yadav
On Oct. 28, 2022, 3:52 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74167/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2022, 3:52 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3888
> https://issues.apache.org/jira/browse/RANGER-3888
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - updated unit tests to add more details in failure messages to make troubleshooting easier
> - updated tests for valid range for month: 0-11
> - updated validation logic to fail only when a given range is completely outside the valid range; earlier validation used to fail even if either min or max fall out of range
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java 1e38118f7
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 59c50e4ca
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-invalid.json 321df659f
>
>
> Diff: https://reviews.apache.org/r/74167/diff/3/
>
>
> Testing
> -------
>
> - verified that TestPolicyEngine tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74167: RANGER-3888: fixed unit test failures caused by earlier commit in RANGER-3888 - #2
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74167/
-----------------------------------------------------------
(Updated Oct. 28, 2022, 3:52 p.m.)
Review request for ranger, Ankita Sinha, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
Changes
-------
updates to address review comment.
Bugs: RANGER-3888
https://issues.apache.org/jira/browse/RANGER-3888
Repository: ranger
Description
-------
- updated unit tests to add more details in failure messages to make troubleshooting easier
- updated tests for valid range for month: 0-11
- updated validation logic to fail only when a given range is completely outside the valid range; earlier validation used to fail even if either min or max fall out of range
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java 1e38118f7
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 59c50e4ca
agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-invalid.json 321df659f
Diff: https://reviews.apache.org/r/74167/diff/3/
Changes: https://reviews.apache.org/r/74167/diff/2-3/
Testing
-------
- verified that TestPolicyEngine tests pass successfully
Thanks,
Madhan Neethiraj
Re: Review Request 74167: RANGER-3888: fixed unit test failures caused by earlier commit in RANGER-3888 - #2
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74167/
-----------------------------------------------------------
(Updated Oct. 27, 2022, 8:27 p.m.)
Review request for ranger, Ankita Sinha, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
Changes
-------
addressed review comments.
Bugs: RANGER-3888
https://issues.apache.org/jira/browse/RANGER-3888
Repository: ranger
Description
-------
- updated unit tests to add more details in failure messages to make troubleshooting easier
- updated tests for valid range for month: 0-11
- updated validation logic to fail only when a given range is completely outside the valid range; earlier validation used to fail even if either min or max fall out of range
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java 1e38118f7
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 59c50e4ca
agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-invalid.json 321df659f
Diff: https://reviews.apache.org/r/74167/diff/2/
Changes: https://reviews.apache.org/r/74167/diff/1-2/
Testing
-------
- verified that TestPolicyEngine tests pass successfully
Thanks,
Madhan Neethiraj
Re: Review Request 74167: RANGER-3888: fixed unit test failures caused by earlier commit in RANGER-3888 - #2
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74167/#review224832
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Oct. 14, 2022, 5:40 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74167/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2022, 5:40 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3888
> https://issues.apache.org/jira/browse/RANGER-3888
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - updated unit tests to add more details in failure messages to make troubleshooting easier
> - updated tests for valid range for month: 0-11
> - updated validation logic to fail only when a given range is completely outside the valid range; earlier validation used to fail even if either min or max fall out of range
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java 1e38118f7
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 59c50e4ca
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-invalid.json 321df659f
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid-and-applicable.json 76489094a
> agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid.json d42d3e6d1
>
>
> Diff: https://reviews.apache.org/r/74167/diff/1/
>
>
> Testing
> -------
>
> - verified that TestPolicyEngine tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>