You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/18 14:52:39 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #17683: rename none_failed_or_skipped by none_failed_and_at_least_one_succeed

kaxil commented on a change in pull request #17683:
URL: https://github.com/apache/airflow/pull/17683#discussion_r691316424



##########
File path: airflow/utils/trigger_rule.py
##########
@@ -32,6 +32,7 @@ class TriggerRule:
     NONE_SKIPPED = 'none_skipped'
     DUMMY = 'dummy'
     ALWAYS = 'always'
+    NONE_FAILED_AND_AT_LEAST_ONE_SUCCEED = "none_failed_and_at_least_one_succeed"

Review comment:
       This is tooooo long. Are you sure you wanted to change the name of `none_failed_or_skipped` and not `none_failed` based on https://github.com/apache/airflow/issues/17012#issuecomment-883089001




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org