[jira] Resolved: (BVAL-75) javadocs, compiler (generics) warnings, etc.

["Carlos Vara (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BVAL-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carlos Vara resolved BVAL-75.
-----------------------------

    Fix Version/s: 0.2-incubating
       Resolution: Fixed

Patches applied in rev 962604, project's tests and TCK pass and compilation is fine under JDK 1.6 and 1.5.

Great work Matt, code is much cleaner now! And you also added some very valid TODOs in there.

A few notes:
- There are a some @SuppressWarnings("unchecked"), we should probably work on removing those were possible. 
- The star imports are due to a non unified formatting style in the team. I think a discussion in the dev list to agree on a common style would be very benefitial for the project.
- In ClassHelper, I had to change:
List<Class<?>> subClasses = new ArrayList<Class<?>>(Arrays.asList(clazz.getInterfaces()));
with
List<Class<?>> subClasses = new ArrayList(Arrays.asList(clazz.getInterfaces()));
for the project to compile under JDK 1.5

> javadocs, compiler (generics) warnings, etc.
> --------------------------------------------
>
>                 Key: BVAL-75
>                 URL: https://issues.apache.org/jira/browse/BVAL-75
>             Project: BeanValidation
>          Issue Type: Improvement
>          Components: jsr303
>    Affects Versions: 0.2-incubating
>            Reporter: Matt Benson
>            Assignee: Carlos Vara
>             Fix For: 0.2-incubating
>
>         Attachments: core.patch.txt, jsr303.patch.txt
>
>
> Driven by my desire to understand the structure of bval, I undertook the exercise of completing the javadoc, and cleaning up as many compiler warnings as was practical, in the core and jsr303 modules.
> "etc." includes such things as small (method-scoped) refactorings, occasional expansion of wildcard imports, and TODO comments to note possible improvements for future consideration.  I will attach a separate patch for each of the modules I have worked on.
> (jsr303 component selected; "core" not available)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.