You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/05/16 01:34:55 UTC

[jira] Created: (THRIFT-3) Comparator is on object equivalence, not value equivalence

Comparator is on object equivalence, not value equivalence
----------------------------------------------------------

                 Key: THRIFT-3
                 URL: https://issues.apache.org/jira/browse/THRIFT-3
             Project: Thrift
          Issue Type: Bug
          Components: Library (Ruby)
            Reporter: Bryan Duxbury
            Priority: Minor


If you try to compare two generated Ruby objects of the same Thrift type, == will not evaluate true, because the default == operator is on object id. This makes it hard to use Thrift objects in testing (and elsewhere, no doubt).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (THRIFT-3) Comparator is on object equivalence, not value equivalence

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury reassigned THRIFT-3:
----------------------------------

    Assignee: Bryan Duxbury

> Comparator is on object equivalence, not value equivalence
> ----------------------------------------------------------
>
>                 Key: THRIFT-3
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>
> If you try to compare two generated Ruby objects of the same Thrift type, == will not evaluate true, because the default == operator is on object id. This makes it hard to use Thrift objects in testing (and elsewhere, no doubt).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (THRIFT-3) Comparator is on object equivalence, not value equivalence

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury resolved THRIFT-3.
--------------------------------

    Resolution: Fixed

Fixed via THRIFT-38 commit.

> Comparator is on object equivalence, not value equivalence
> ----------------------------------------------------------
>
>                 Key: THRIFT-3
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Bryan Duxbury
>            Priority: Minor
>
> If you try to compare two generated Ruby objects of the same Thrift type, == will not evaluate true, because the default == operator is on object id. This makes it hard to use Thrift objects in testing (and elsewhere, no doubt).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-3) Comparator is on object equivalence, not value equivalence

Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600160#action_12600160 ] 

Kevin Clark commented on THRIFT-3:
----------------------------------

I think there's a proper === defined in test_helper right now. It could make sense that it is the default === for thrift structs.

> Comparator is on object equivalence, not value equivalence
> ----------------------------------------------------------
>
>                 Key: THRIFT-3
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Bryan Duxbury
>            Priority: Minor
>
> If you try to compare two generated Ruby objects of the same Thrift type, == will not evaluate true, because the default == operator is on object id. This makes it hard to use Thrift objects in testing (and elsewhere, no doubt).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.