You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2023/04/18 06:53:58 UTC

[GitHub] [arrow-datafusion] viirya opened a new pull request, #6041: Add test for handling precision overflow when casting from integer to decimal

viirya opened a new pull request, #6041:
URL: https://github.com/apache/arrow-datafusion/pull/6041

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #5825.
   
   # Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #6041: Add test for handling precision overflow when casting from integer to decimal

Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #6041:
URL: https://github.com/apache/arrow-datafusion/pull/6041#discussion_r1169577294


##########
datafusion/core/tests/sqllogictests/test_files/decimal.slt:
##########
@@ -592,3 +592,8 @@ query TB
 select arrow_typeof(null <= a), null <= a from (values (1.1::decimal)) as t(a);
 ----
 Boolean NULL
+
+query R
+select try_cast(1234567 as decimal(7,3));
+----
+NULL

Review Comment:
   I've verified that this returns incorrect result `1234.567` before the fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan merged pull request #6041: Add test for handling precision overflow when casting from integer to decimal

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan merged PR #6041:
URL: https://github.com/apache/arrow-datafusion/pull/6041


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] viirya commented on pull request #6041: Add test for handling precision overflow when casting from integer to decimal

Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #6041:
URL: https://github.com/apache/arrow-datafusion/pull/6041#issuecomment-1512626662

   Thanks @Dandandan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan commented on pull request #6041: Add test for handling precision overflow when casting from integer to decimal

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #6041:
URL: https://github.com/apache/arrow-datafusion/pull/6041#issuecomment-1513313472

   Thanks @viirya 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org