You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/08 17:37:24 UTC
[GitHub] [airflow] dstandish opened a new pull request, #24930: Small docstring clarification in _find_zombies
dstandish opened a new pull request, #24930:
URL: https://github.com/apache/airflow/pull/24930
Small clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #24930: Small docstring clarification in _find_zombies
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #24930:
URL: https://github.com/apache/airflow/pull/24930#discussion_r917045856
##########
airflow/jobs/scheduler_job.py:
##########
@@ -1358,8 +1358,8 @@ def check_trigger_timeouts(self, session: Session = None):
def _find_zombies(self, session):
"""
Find zombie task instances, which are tasks haven't heartbeated for too long
- or have a no-longer-running LocalTaskJob, and send them off to the DAG processor
- to be handled.
+ or have a no-longer-running LocalTaskJob, and register a TaskCallbackRequest,
Review Comment:
```suggestion
or have a no-longer-running LocalTaskJob, and create a TaskCallbackRequest
```
A little better still?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham closed pull request #24930: Small docstring clarification in _find_zombies
Posted by GitBox <gi...@apache.org>.
jedcunningham closed pull request #24930: Small docstring clarification in _find_zombies
URL: https://github.com/apache/airflow/pull/24930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish merged pull request #24930: Small docstring clarification in _find_zombies
Posted by GitBox <gi...@apache.org>.
dstandish merged PR #24930:
URL: https://github.com/apache/airflow/pull/24930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org