You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Matthew F. Dennis (JIRA)" <ji...@apache.org> on 2011/02/16 05:36:57 UTC
[jira] Created: (CASSANDRA-2174) saved caches written with
BufferedRandomAccessFile cannot be read by ObjectInputStream
saved caches written with BufferedRandomAccessFile cannot be read by ObjectInputStream
--------------------------------------------------------------------------------------
Key: CASSANDRA-2174
URL: https://issues.apache.org/jira/browse/CASSANDRA-2174
Project: Cassandra
Issue Type: Bug
Reporter: Matthew F. Dennis
Assignee: Matthew F. Dennis
The CacheWriter is currently writing with BufferedRandomAccessFile which is incompatible with ObjectInputStream resulting in stack traces about corrupted stream headers when loading a saved cache.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2174) saved caches written with
BufferedRandomAccessFile cannot be read by ObjectInputStream
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995183#comment-12995183 ]
Jonathan Ellis commented on CASSANDRA-2174:
-------------------------------------------
We don't use ObjectInputStream for cache reads anymore, and we need to use BRAF to get the non-buffer-cache-clobbering effect on cache writes.
We don't care about 0.7.0 reading 0.7.1/2 caches, since we made the choice to allow 0.7.1 to write new-format data files (CASSANDRA-1555) which is a much bigger incompatibility.
If 0.7.1/2 can't read 0.7.0, then we goofed, but changing it back (breaking 0.7.2 -> 0.7.3) seems like too late.
> saved caches written with BufferedRandomAccessFile cannot be read by ObjectInputStream
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2174
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7.3
>
> Attachments: 2174-cassandra-0.7.txt
>
>
> The CacheWriter is currently writing with BufferedRandomAccessFile which is incompatible with ObjectInputStream resulting in stack traces about corrupted stream headers when loading a saved cache.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2174) saved caches written with
BufferedRandomAccessFile cannot be read by ObjectInputStream
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew F. Dennis updated CASSANDRA-2174:
-----------------------------------------
Attachment: 2174-cassandra-0.7.txt
I neglected to see the skipCache flag and was intending to make the read/write code symmetric.
attached patch contains only CFS change from OIS to DIS.
> saved caches written with BufferedRandomAccessFile cannot be read by ObjectInputStream
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2174
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7.3
>
> Attachments: 2174-cassandra-0.7.txt
>
>
> The CacheWriter is currently writing with BufferedRandomAccessFile which is incompatible with ObjectInputStream resulting in stack traces about corrupted stream headers when loading a saved cache.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2174) saved caches written with
BufferedRandomAccessFile cannot be read by ObjectInputStream
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995159#comment-12995159 ]
Matthew F. Dennis commented on CASSANDRA-2174:
----------------------------------------------
patch is on top of CASSANDRA-2172
> saved caches written with BufferedRandomAccessFile cannot be read by ObjectInputStream
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2174
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7.3
>
> Attachments: 2174-cassandra-0.7.txt
>
>
> The CacheWriter is currently writing with BufferedRandomAccessFile which is incompatible with ObjectInputStream resulting in stack traces about corrupted stream headers when loading a saved cache.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2174) saved caches written with
BufferedRandomAccessFile cannot be read by ObjectInputStream
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2174:
--------------------------------------
Remaining Estimate: 2h
Original Estimate: 2h
> saved caches written with BufferedRandomAccessFile cannot be read by ObjectInputStream
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2174
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7.3
>
> Attachments: 2174-cassandra-0.7.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The CacheWriter is currently writing with BufferedRandomAccessFile which is incompatible with ObjectInputStream resulting in stack traces about corrupted stream headers when loading a saved cache.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2174) saved caches written with
BufferedRandomAccessFile cannot be read by ObjectInputStream
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew F. Dennis updated CASSANDRA-2174:
-----------------------------------------
Attachment: 2174-cassandra-0.7.txt
> saved caches written with BufferedRandomAccessFile cannot be read by ObjectInputStream
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2174
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7.3
>
> Attachments: 2174-cassandra-0.7.txt
>
>
> The CacheWriter is currently writing with BufferedRandomAccessFile which is incompatible with ObjectInputStream resulting in stack traces about corrupted stream headers when loading a saved cache.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2174) saved caches written with
BufferedRandomAccessFile cannot be read by ObjectInputStream
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew F. Dennis updated CASSANDRA-2174:
-----------------------------------------
Attachment: 2174-cassandra-0.7-v2.txt
> saved caches written with BufferedRandomAccessFile cannot be read by ObjectInputStream
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2174
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7.3
>
> Attachments: 2174-cassandra-0.7.txt
>
>
> The CacheWriter is currently writing with BufferedRandomAccessFile which is incompatible with ObjectInputStream resulting in stack traces about corrupted stream headers when loading a saved cache.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2174) saved caches written with
BufferedRandomAccessFile cannot be read by ObjectInputStream
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995563#comment-12995563 ]
Hudson commented on CASSANDRA-2174:
-----------------------------------
Integrated in Cassandra-0.7 #282 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/282/])
read saved caches with DataInputStream
patch by mdennis; reviewed by jbellis for CASSANDRA-2174
> saved caches written with BufferedRandomAccessFile cannot be read by ObjectInputStream
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2174
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7.3
>
> Attachments: 2174-cassandra-0.7.txt
>
>
> The CacheWriter is currently writing with BufferedRandomAccessFile which is incompatible with ObjectInputStream resulting in stack traces about corrupted stream headers when loading a saved cache.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2174) saved caches written with
BufferedRandomAccessFile cannot be read by ObjectInputStream
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew F. Dennis updated CASSANDRA-2174:
-----------------------------------------
Attachment: (was: 2174-cassandra-0.7.txt)
> saved caches written with BufferedRandomAccessFile cannot be read by ObjectInputStream
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2174
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7.3
>
>
> The CacheWriter is currently writing with BufferedRandomAccessFile which is incompatible with ObjectInputStream resulting in stack traces about corrupted stream headers when loading a saved cache.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2174) saved caches written with
BufferedRandomAccessFile cannot be read by ObjectInputStream
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995187#comment-12995187 ]
Jonathan Ellis commented on CASSANDRA-2174:
-------------------------------------------
Oops, I applied the patch and _then_ looked for uses of OIS. Those operations are not commutative. :)
> saved caches written with BufferedRandomAccessFile cannot be read by ObjectInputStream
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2174
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7.3
>
> Attachments: 2174-cassandra-0.7.txt
>
>
> The CacheWriter is currently writing with BufferedRandomAccessFile which is incompatible with ObjectInputStream resulting in stack traces about corrupted stream headers when loading a saved cache.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2174) saved caches written with
BufferedRandomAccessFile cannot be read by ObjectInputStream
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995188#comment-12995188 ]
Jonathan Ellis commented on CASSANDRA-2174:
-------------------------------------------
So... the important fix is the CFS change, and the CacheWriter change is gratuitous?
> saved caches written with BufferedRandomAccessFile cannot be read by ObjectInputStream
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2174
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7.3
>
> Attachments: 2174-cassandra-0.7.txt
>
>
> The CacheWriter is currently writing with BufferedRandomAccessFile which is incompatible with ObjectInputStream resulting in stack traces about corrupted stream headers when loading a saved cache.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2174) saved caches written with
BufferedRandomAccessFile cannot be read by ObjectInputStream
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew F. Dennis updated CASSANDRA-2174:
-----------------------------------------
Attachment: (was: 2174-cassandra-0.7-v2.txt)
> saved caches written with BufferedRandomAccessFile cannot be read by ObjectInputStream
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2174
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Matthew F. Dennis
> Assignee: Matthew F. Dennis
> Fix For: 0.7.3
>
> Attachments: 2174-cassandra-0.7.txt
>
>
> The CacheWriter is currently writing with BufferedRandomAccessFile which is incompatible with ObjectInputStream resulting in stack traces about corrupted stream headers when loading a saved cache.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira