You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/12/18 02:12:05 UTC
[GitHub] [incubator-yunikorn-site] wilfred-s opened a new pull request #33: [YUNIKORN-317] cache removal design doc
wilfred-s opened a new pull request #33:
URL: https://github.com/apache/incubator-yunikorn-site/pull/33
Adding the design doc for the cache removal implemented in YUNIKORN-317
Small side changes to clean up build and files:
Change to slug to define docs home
Removal of unused files (atom and doap)
Removal of unicode line separator chars (LSEP, U+2028)
Clean up of build script tabs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] yangwwei commented on pull request #33: [YUNIKORN-317] cache removal design doc
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #33:
URL: https://github.com/apache/incubator-yunikorn-site/pull/33#issuecomment-748674862
@wilfred-s feel free to merge this with a proper commit message, thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] wilfred-s closed pull request #33: [YUNIKORN-317] cache removal design doc
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #33:
URL: https://github.com/apache/incubator-yunikorn-site/pull/33
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] wilfred-s commented on pull request #33: [YUNIKORN-317] cache removal design doc
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #33:
URL: https://github.com/apache/incubator-yunikorn-site/pull/33#issuecomment-748749513
commit pushed, auto build will publish soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] yangwwei commented on a change in pull request #33: [YUNIKORN-317] cache removal design doc
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #33:
URL: https://github.com/apache/incubator-yunikorn-site/pull/33#discussion_r545574002
##########
File path: docs/design/cache_removal.md
##########
@@ -0,0 +1,449 @@
+---
+id: cache_removal
+title: Scheduler cache removal design
+---
+
+<!--
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ -->
+
+# Proposal to combine Cache and Scheduler's implementation in the core
+This document describes the current state of the scheduler and cache implementation.
+It describes the changes planned based on the analysis that was done of the current behaviour.
+
+## Goals
+The goal is to provide the same functionality before and after the change.
+- Junit tests before and after the merge must all pass.
+- Smoke tests defined in the core should all pass without major changes*.
Review comment:
seems like there is an extra * at the end of the line
##########
File path: docs/design/cache_removal.md
##########
@@ -0,0 +1,449 @@
+---
+id: cache_removal
+title: Scheduler cache removal design
+---
+
+<!--
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ -->
+
+# Proposal to combine Cache and Scheduler's implementation in the core
+This document describes the current state of the scheduler and cache implementation.
+It describes the changes planned based on the analysis that was done of the current behaviour.
+
+## Goals
+The goal is to provide the same functionality before and after the change.
+- Junit tests before and after the merge must all pass.
Review comment:
Junit tests ? I believe this is a typo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] wilfred-s commented on a change in pull request #33: [YUNIKORN-317] cache removal design doc
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #33:
URL: https://github.com/apache/incubator-yunikorn-site/pull/33#discussion_r546346452
##########
File path: docs/design/cache_removal.md
##########
@@ -0,0 +1,449 @@
+---
+id: cache_removal
+title: Scheduler cache removal design
+---
+
+<!--
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ -->
+
+# Proposal to combine Cache and Scheduler's implementation in the core
+This document describes the current state of the scheduler and cache implementation.
+It describes the changes planned based on the analysis that was done of the current behaviour.
+
+## Goals
+The goal is to provide the same functionality before and after the change.
+- Junit tests before and after the merge must all pass.
+- Smoke tests defined in the core should all pass without major changes*.
Review comment:
the footnote link was not added correctly fixed that
##########
File path: docs/design/cache_removal.md
##########
@@ -0,0 +1,449 @@
+---
+id: cache_removal
+title: Scheduler cache removal design
+---
+
+<!--
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ -->
+
+# Proposal to combine Cache and Scheduler's implementation in the core
+This document describes the current state of the scheduler and cache implementation.
+It describes the changes planned based on the analysis that was done of the current behaviour.
+
+## Goals
+The goal is to provide the same functionality before and after the change.
+- Junit tests before and after the merge must all pass.
Review comment:
yep that is a typo, fixed in the update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] wilfred-s commented on pull request #33: [YUNIKORN-317] cache removal design doc
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #33:
URL: https://github.com/apache/incubator-yunikorn-site/pull/33#issuecomment-748582346
The [core design doc](http://yunikorn.apache.org/docs/next/design/scheduler_core_design) needs a full rewrite. All that is there needs to be done from scratch. That is a good amount of work and will follow as a separate change.
I expect that it will take at least 3 days to rewrite it all. There are a number of things in that doc that are not correct anymore.
When we have that done the existing document will be replaced. For now we just have a tag in it to show that it is not current.
Filed [YUNIKORN-495](https://issues.apache.org/jira/browse/YUNIKORN-495) for this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org