You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "caiqi1111 (via GitHub)" <gi...@apache.org> on 2025/12/02 01:46:43 UTC
[PR] fix: elasticsearch-logger plugin support elasticsaerch data_stream [apisix]
caiqi1111 opened a new pull request, #12784:
URL: https://github.com/apache/apisix/pull/12784
### Description
Elasticsearch Data streams are well-suited for logs, events, metrics, and other continuously generated data. However data_stream only support op_type=create for _bulk API.
reference：https://www.elastic.co/docs/api/doc/elasticsearch/v8/operation/operation-bulk
<img width="1158" height="815" alt="1055a5dd-73cd-4901-9fd4-89e72cab8e83" src="https://github.com/user-attachments/assets/f225c466-c3ee-48fb-99ea-0a5d5dab1aa5" />
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: elasticsearch-logger plugin support elasticsaerch data_stream [apisix]
Posted by "moonming (via GitHub)" <gi...@apache.org>.
moonming commented on PR #12784:
URL: https://github.com/apache/apisix/pull/12784#issuecomment-4064882157
Hi @caiqi1111, thank you for looking into this!
I appreciate the effort, but I have a few concerns with the current state:
1. **Missing test coverage**: There are no test cases to verify the `data_stream` behavior, which makes it hard to validate the change.
2. **Incomplete approach**: Proper `data_stream` support in Elasticsearch logger should be implemented through a schema-level `data_stream` configuration field (similar to how the `index` field works), rather than just changing the `op_type`. The data stream API has different semantics around indexing.
3. **Inactivity**: This PR has been inactive for several months without addressing the feedback.
I'm going to close this PR for now. If you're still interested in adding proper data stream support, I'd suggest:
- Adding a `data_stream` boolean or object field to the plugin schema
- Adjusting the bulk API call format accordingly
- Including comprehensive test cases
Feel free to open a new PR with the more complete implementation. Thanks again for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: elasticsearch-logger plugin support elasticsaerch data_stream [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #12784:
URL: https://github.com/apache/apisix/pull/12784#issuecomment-3688493078
Hi @caiqi1111, following up on the previous review comments. Please let us know if you have any updates. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: elasticsearch-logger plugin support elasticsaerch data_stream [apisix]
Posted by "moonming (via GitHub)" <gi...@apache.org>.
moonming closed pull request #12784: fix: elasticsearch-logger plugin support elasticsaerch data_stream
URL: https://github.com/apache/apisix/pull/12784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: elasticsearch-logger plugin support elasticsaerch data_stream [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12784:
URL: https://github.com/apache/apisix/pull/12784#issuecomment-3940631123
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org