You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2017/06/05 05:23:46 UTC
[58/67] [abbrv] kylin git commit: minor, remove some verbose logs
minor, remove some verbose logs
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/de193bcd
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/de193bcd
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/de193bcd
Branch: refs/heads/master
Commit: de193bcd1c4ef37b0d06a8c11557a64f68fa90ee
Parents: 0c85fb7
Author: lidongsjtu <li...@apache.org>
Authored: Thu Jun 1 21:32:58 2017 +0800
Committer: hongbin ma <ma...@kyligence.io>
Committed: Thu Jun 1 21:37:09 2017 +0800
----------------------------------------------------------------------
.../org/apache/kylin/common/KylinConfig.java | 1 -
.../org/apache/kylin/job/dao/ExecutableDao.java | 1 -
.../kylin/metadata/cachesync/Broadcaster.java | 2 +-
.../engine/mr/common/AbstractHadoopJob.java | 34 ++++++++++----------
4 files changed, 18 insertions(+), 20 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/de193bcd/core-common/src/main/java/org/apache/kylin/common/KylinConfig.java
----------------------------------------------------------------------
diff --git a/core-common/src/main/java/org/apache/kylin/common/KylinConfig.java b/core-common/src/main/java/org/apache/kylin/common/KylinConfig.java
index 04af9f5..7974c80 100644
--- a/core-common/src/main/java/org/apache/kylin/common/KylinConfig.java
+++ b/core-common/src/main/java/org/apache/kylin/common/KylinConfig.java
@@ -131,7 +131,6 @@ public class KylinConfig extends KylinConfigBase {
* LOCAL_FOLDER: path to resource folder
*/
UriType uriType = decideUriType(uri);
- logger.info("The URI " + uri + " is recognized as " + uriType);
if (uriType == UriType.LOCAL_FOLDER) {
KylinConfig config = new KylinConfig();
http://git-wip-us.apache.org/repos/asf/kylin/blob/de193bcd/core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java
----------------------------------------------------------------------
diff --git a/core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java b/core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java
index 70799d8..bd020f8 100644
--- a/core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java
+++ b/core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java
@@ -214,7 +214,6 @@ public class ExecutableDao {
}
public void updateJobOutput(ExecutableOutputPO output) throws PersistentException {
- logger.debug("updating job output, id: " + output.getUuid());
try {
final long ts = writeJobOutputResource(pathOfJobOutput(output.getUuid()), output);
output.setLastModified(ts);
http://git-wip-us.apache.org/repos/asf/kylin/blob/de193bcd/core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java
----------------------------------------------------------------------
diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java b/core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java
index 4a8c6d3..4fbfc7c 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java
@@ -192,7 +192,7 @@ public class Broadcaster {
if (list == null)
return;
- logger.debug("Broadcasting metadata change: entity=" + entity + ", event=" + event + ", cacheKey=" + cacheKey + ", listeners=" + list);
+ logger.trace("Broadcasting metadata change: entity=" + entity + ", event=" + event + ", cacheKey=" + cacheKey + ", listeners=" + list);
// prevents concurrent modification exception
list = Lists.newArrayList(list);
http://git-wip-us.apache.org/repos/asf/kylin/blob/de193bcd/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java
----------------------------------------------------------------------
diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java
index 764cbdd..abfa224 100644
--- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java
+++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java
@@ -160,7 +160,7 @@ public abstract class AbstractHadoopJob extends Configured implements Tool {
File jarFile = new File(jarPath);
if (jarFile.exists()) {
job.setJar(jarPath);
- logger.info("append job jar: " + jarPath);
+ logger.trace("append job jar: " + jarPath);
} else {
job.setJarByClass(this.getClass());
}
@@ -168,7 +168,7 @@ public abstract class AbstractHadoopJob extends Configured implements Tool {
String kylinHiveDependency = System.getProperty("kylin.hive.dependency");
String kylinHBaseDependency = System.getProperty("kylin.hbase.dependency");
String kylinKafkaDependency = System.getProperty("kylin.kafka.dependency");
- logger.info("append kylin.hbase.dependency: " + kylinHBaseDependency + " to " + MAP_REDUCE_CLASSPATH);
+ logger.trace("append kylin.hbase.dependency: " + kylinHBaseDependency + " to " + MAP_REDUCE_CLASSPATH);
Configuration jobConf = job.getConfiguration();
String classpath = jobConf.get(MAP_REDUCE_CLASSPATH);
@@ -185,7 +185,7 @@ public abstract class AbstractHadoopJob extends Configured implements Tool {
}
jobConf.set(MAP_REDUCE_CLASSPATH, classpath);
- logger.info("Hadoop job classpath is: " + job.getConfiguration().get(MAP_REDUCE_CLASSPATH));
+ logger.trace("Hadoop job classpath is: " + job.getConfiguration().get(MAP_REDUCE_CLASSPATH));
/*
* set extra dependencies as tmpjars & tmpfiles if configured
@@ -197,28 +197,28 @@ public abstract class AbstractHadoopJob extends Configured implements Tool {
// yarn classpath is comma separated
kylinHiveDependency = kylinHiveDependency.replace(":", ",");
- logger.info("Hive Dependencies Before Filtered: " + kylinHiveDependency);
+ logger.trace("Hive Dependencies Before Filtered: " + kylinHiveDependency);
String filteredHive = filterKylinHiveDependency(kylinHiveDependency, kylinConf);
- logger.info("Hive Dependencies After Filtered: " + filteredHive);
+ logger.trace("Hive Dependencies After Filtered: " + filteredHive);
StringUtil.appendWithSeparator(kylinDependency, filteredHive);
} else {
- logger.info("No hive dependency jars set in the environment, will find them from classpath:");
+ logger.debug("No hive dependency jars set in the environment, will find them from classpath:");
try {
String hiveExecJarPath = ClassUtil.findContainingJar(Class.forName("org.apache.hadoop.hive.ql.Driver"));
StringUtil.appendWithSeparator(kylinDependency, hiveExecJarPath);
- logger.info("hive-exec jar file: " + hiveExecJarPath);
+ logger.debug("hive-exec jar file: " + hiveExecJarPath);
String hiveHCatJarPath = ClassUtil.findContainingJar(Class.forName("org.apache.hive.hcatalog.mapreduce.HCatInputFormat"));
StringUtil.appendWithSeparator(kylinDependency, hiveHCatJarPath);
- logger.info("hive-catalog jar file: " + hiveHCatJarPath);
+ logger.debug("hive-catalog jar file: " + hiveHCatJarPath);
String hiveMetaStoreJarPath = ClassUtil.findContainingJar(Class.forName("org.apache.hadoop.hive.metastore.api.Table"));
StringUtil.appendWithSeparator(kylinDependency, hiveMetaStoreJarPath);
- logger.info("hive-metastore jar file: " + hiveMetaStoreJarPath);
+ logger.debug("hive-metastore jar file: " + hiveMetaStoreJarPath);
} catch (ClassNotFoundException e) {
logger.error("Cannot found hive dependency jars: " + e);
}
@@ -227,14 +227,14 @@ public abstract class AbstractHadoopJob extends Configured implements Tool {
// for kafka dependencies
if (kylinKafkaDependency != null) {
kylinKafkaDependency = kylinKafkaDependency.replace(":", ",");
- logger.info("Kafka Dependencies: " + kylinKafkaDependency);
+ logger.trace("Kafka Dependencies: " + kylinKafkaDependency);
StringUtil.appendWithSeparator(kylinDependency, kylinKafkaDependency);
} else {
- logger.info("No Kafka dependency jar set in the environment, will find them from classpath:");
+ logger.debug("No Kafka dependency jar set in the environment, will find them from classpath:");
try {
String kafkaClientJarPath = ClassUtil.findContainingJar(Class.forName("org.apache.kafka.clients.consumer.KafkaConsumer"));
StringUtil.appendWithSeparator(kylinDependency, kafkaClientJarPath);
- logger.info("kafka jar file: " + kafkaClientJarPath);
+ logger.debug("kafka jar file: " + kafkaClientJarPath);
} catch (ClassNotFoundException e) {
logger.debug("Not found kafka client jar from classpath, it is optional for normal build: " + e);
@@ -303,7 +303,7 @@ public abstract class AbstractHadoopJob extends Configured implements Tool {
logger.warn("The directory of kylin dependency '" + fileName + "' does not exist, skip");
continue;
}
-
+
if (fs.getFileStatus(p).isDirectory()) {
appendTmpDir(job, fs, p, jarList, fileList);
continue;
@@ -355,7 +355,7 @@ public abstract class AbstractHadoopJob extends Configured implements Tool {
tmpJars += "," + jarList;
}
conf.set("tmpjars", tmpJars);
- logger.info("Job 'tmpjars' updated -- " + tmpJars);
+ logger.trace("Job 'tmpjars' updated -- " + tmpJars);
}
private void appendTmpFiles(String fileList, Configuration conf) {
@@ -369,7 +369,7 @@ public abstract class AbstractHadoopJob extends Configured implements Tool {
tmpFiles += "," + fileList;
}
conf.set("tmpfiles", tmpFiles);
- logger.info("Job 'tmpfiles' updated -- " + tmpFiles);
+ logger.trace("Job 'tmpfiles' updated -- " + tmpFiles);
}
private String getDefaultMapRedClasspath() {
@@ -427,7 +427,7 @@ public abstract class AbstractHadoopJob extends Configured implements Tool {
ret += addInputDirs(new String[] { path.toString() }, job);
}
} else {
- logger.debug("Add input " + inp);
+ logger.trace("Add input " + inp);
FileInputFormat.addInputPath(job, new Path(inp));
ret++;
}
@@ -517,7 +517,7 @@ public abstract class AbstractHadoopJob extends Configured implements Tool {
protected void cleanupTempConfFile(Configuration conf) {
String tempMetaFileString = conf.get("tmpfiles");
- logger.info("tempMetaFileString is : " + tempMetaFileString);
+ logger.trace("tempMetaFileString is : " + tempMetaFileString);
if (tempMetaFileString != null) {
if (tempMetaFileString.startsWith("file://")) {
tempMetaFileString = tempMetaFileString.substring("file://".length());