[GitHub] [arrow-datafusion] tz70s commented on a diff in pull request #6232: Safeguard round function decimal places overflow

["tz70s (via GitHub)" <gi...@apache.org>]

tz70s commented on code in PR #6232:
URL: https://github.com/apache/arrow-datafusion/pull/6232#discussion_r1185242876


##########
datafusion/physical-expr/src/math_expressions.rs:
##########
@@ -226,21 +227,23 @@ pub fn round(args: &[ArrayRef]) -> Result<ArrayRef> {
                     }
                 )) as ArrayRef)
             }
-            ColumnarValue::Array(decimal_places) => Ok(Arc::new(make_function_inputs2!(

Review Comment:
   I basically give up using the existing macro (`make_function_inputs2`), not sure is it worth changing it to be possibly return `Result` within the `$FUNC`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org