[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5282: [LLVM] Fix generation of LLVM intrinsics

[GitBox <gi...@apache.org>]

tqchen commented on a change in pull request #5282: [LLVM] Fix generation of LLVM intrinsics
URL: https://github.com/apache/incubator-tvm/pull/5282#discussion_r405921326
 
 

 ##########
 File path: src/target/llvm/codegen_llvm.cc
 ##########
 @@ -698,21 +698,33 @@ llvm::Value* CodeGenLLVM::CreateIntrinsic(const CallNode* op) {
         sig_type.push_back(arg_value.back()->getType());
       }
     }
+    // LLVM's prefetch intrinsic returns "void", while TVM's prefetch
+    // returns int32. This causes problems because prefetch is one of
+    // those intrinsics that is generated automatically via the
 
 Review comment:
   I see, let us leave a TODO here, hopefully after we introduce the type system to type the intrinsics, we will be able to use the same type as LLVM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services