You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/10/16 02:37:30 UTC

[GitHub] [kylin] bigxiaochu commented on a change in pull request #1299: KYLIN-4613 add build cubev2 and JobRestClient

bigxiaochu commented on a change in pull request #1299:
URL: https://github.com/apache/kylin/pull/1299#discussion_r505999634



##########
File path: core-common/src/main/java/org/apache/kylin/common/KylinConfig.java
##########
@@ -134,7 +134,7 @@ private static void buildDefaultOrderedProperties() {
         }
     }
 
-    public static KylinConfig getInstanceFromEnv() {
+    public static KylinConfig getInstanceFromEnv(boolean allowConfigFileNoExist) {

Review comment:
       因为作为客户端提交建模、构建请求时，可以不需要有kylin的部署结构，也不需要有符合部署目录结构规范的配置文件。以减少客户端程序的依赖复杂度。




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org