You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by PSUdaemon <gi...@git.apache.org> on 2016/10/26 17:58:35 UTC
[GitHub] trafficserver pull request #1140: Fix CID 1356975
GitHub user PSUdaemon opened a pull request:
https://github.com/apache/trafficserver/pull/1140
Fix CID 1356975
Check for NULL before pointer dereference.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PSUdaemon/trafficserver cov1356975
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1140.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1140
----
commit 0778afd90f5c3a2a6b6680c28b60e0378c1a5829
Author: Phil Sorber <so...@apache.org>
Date: 2016-10-26T17:56:09Z
Fix CID 1356975
Check for NULL before pointer dereference.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1140: TS-5006: Fix CID 1356975
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1140#discussion_r85228532
--- Diff: proxy/http/HttpSM.cc ---
@@ -3309,7 +3309,7 @@ HttpSM::tunnel_handler_ua(int event, HttpTunnelConsumer *c)
// only external POSTs should be subject to this logic; ruling out internal POSTs here
bool is_eligible_post_request = (t_state.method == HTTP_WKSIDX_POST);
- if (is_eligible_post_request) {
+ if (is_eligible_post_request && ua_session) {
--- End diff --
I think @shinrich is looking at code further up where we check for NULLness of `ua_session` so maybe she can say more whether or not we should be asserting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1140: TS-5006: Fix CID 1356975
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1140
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1093/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1140: TS-5006: Fix CID 1356975
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1140#discussion_r85228363
--- Diff: proxy/http/HttpSM.cc ---
@@ -3309,7 +3309,7 @@ HttpSM::tunnel_handler_ua(int event, HttpTunnelConsumer *c)
// only external POSTs should be subject to this logic; ruling out internal POSTs here
bool is_eligible_post_request = (t_state.method == HTTP_WKSIDX_POST);
- if (is_eligible_post_request) {
+ if (is_eligible_post_request && ua_session) {
--- End diff --
I don't know this code much, but seeing that we don't crash here, presumably ua_session generally is not NULL here. So maybe a better thing is a release assert?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1140: Fix CID 1356975
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1140
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/976/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1140: TS-5006: Fix CID 1356975
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1140
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1100/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1140: TS-5006: Fix CID 1356975
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1140: TS-5006: Fix CID 1356975
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1140#discussion_r85231582
--- Diff: proxy/http/HttpSM.cc ---
@@ -3309,7 +3309,7 @@ HttpSM::tunnel_handler_ua(int event, HttpTunnelConsumer *c)
// only external POSTs should be subject to this logic; ruling out internal POSTs here
bool is_eligible_post_request = (t_state.method == HTTP_WKSIDX_POST);
- if (is_eligible_post_request) {
+ if (is_eligible_post_request && ua_session) {
--- End diff --
Yes, looked at that. I don't think the NULL check around abort is necessary at all. So perhaps the easier thing is to remove that check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1140: TS-5006: Fix CID 1356975
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1140
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/985/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1140: Fix CID 1356975
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1140
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1083/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1140: Fix CID 1356975
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1140
This needs a Jira number.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1140: TS-5006: Fix CID 1356975
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1140
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/993/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---