[jira] [Commented] (CASSANDRA-13081) Confusing StreamReader.StreamDeserializer.cleanup leftover? code

["Paulo Motta (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-13081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798349#comment-15798349 ] 

Paulo Motta commented on CASSANDRA-13081:
-----------------------------------------

Good catch! Patch attached removing streaming pre-3.0 compatibility code. Mind reviewing?

||trunk||
|[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-13081]|
|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-13081-testall/lastCompletedBuild/testReport/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-13081-dtest/lastCompletedBuild/testReport/]|


> Confusing StreamReader.StreamDeserializer.cleanup leftover? code
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-13081
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13081
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 4.x
>
>
> The cleanup method in StreamReader.StreamDeserializer does stuff in the cases when the field 'in' is a RewindableDataInputStreamPlus typed object.
> Given that it is a 
>      this.in = new DataInputPlus.DataInputStreamPlus(in);
> that can never be. I'm assuming this was left over from some previous refactor or such. Assuming we can just delete this?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)