[GitHub] [tinkerpop] newkek commented on a change in pull request #1110: TINKERPOP-2211 Add API which allows per-request option for bytecode

[GitBox <gi...@apache.org>]

newkek commented on a change in pull request #1110: TINKERPOP-2211 Add API which allows per-request option for bytecode
URL: https://github.com/apache/tinkerpop/pull/1110#discussion_r282522230
 
 

 ##########
 File path: gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteConnection.java
 ##########
 @@ -210,7 +214,20 @@ public static DriverRemoteConnection using(final Configuration conf) {
     @Override
     public <E> CompletableFuture<RemoteTraversal<?, E>> submitAsync(final Bytecode bytecode) throws RemoteConnectionException {
         try {
-            return client.submitAsync(bytecode).thenApply(rs -> new DriverRemoteTraversal<>(rs, client, attachElements, conf));
+            final Iterator<OptionsStrategy> itty = IteratorUtils.map(
+                    IteratorUtils.filter(bytecode.getSourceInstructions().iterator(),
 
 Review comment:
   Could this (extracting `RequestOptions` from a `Bytecode`) be made available as a utility for other implementors of `RemoteConnection`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services