You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by cs...@apache.org on 2019/07/02 12:56:43 UTC
[sling-org-apache-sling-distribution-journal-kafka] 02/02: Avoid
volatile
This is an automated email from the ASF dual-hosted git repository.
cschneider pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-distribution-journal-kafka.git
commit 5b01420faa81bcfbf44c57602e05e0237635238f
Author: Christian Schneider <cs...@adobe.com>
AuthorDate: Tue Jul 2 14:50:44 2019 +0200
Avoid volatile
---
.../sling/distribution/journal/kafka/KafkaClientProvider.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/main/java/org/apache/sling/distribution/journal/kafka/KafkaClientProvider.java b/src/main/java/org/apache/sling/distribution/journal/kafka/KafkaClientProvider.java
index 4b31bbb..78046c0 100644
--- a/src/main/java/org/apache/sling/distribution/journal/kafka/KafkaClientProvider.java
+++ b/src/main/java/org/apache/sling/distribution/journal/kafka/KafkaClientProvider.java
@@ -90,9 +90,9 @@ public class KafkaClientProvider implements MessagingProvider, Closeable {
private ExceptionEventSender eventSender;
- private volatile KafkaProducer<String, byte[]> rawProducer = null;
+ private KafkaProducer<String, byte[]> rawProducer = null;
- private volatile KafkaProducer<String, String> jsonProducer = null;
+ private KafkaProducer<String, String> jsonProducer = null;
private String kafkaBootstrapServers;
@@ -118,7 +118,7 @@ public class KafkaClientProvider implements MessagingProvider, Closeable {
}
@Deactivate
- public void close() {
+ public synchronized void close() {
closeQuietly(rawProducer);
closeQuietly(jsonProducer);
}