You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/04 07:15:24 UTC
[GitHub] [shardingsphere] menghaoranss opened a new pull request #5917: Fixes failed to disable slave database
menghaoranss opened a new pull request #5917:
URL: https://github.com/apache/shardingsphere/pull/5917
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #5917: Fixes failed to disable slave database
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5917:
URL: https://github.com/apache/shardingsphere/pull/5917#issuecomment-638676658
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5917?src=pr&el=h1) Report
> Merging [#5917](https://codecov.io/gh/apache/shardingsphere/pull/5917?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/52aa585f059ecf10f5617ba03767e7c6b60ab37c&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `60.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5917/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5917?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5917 +/- ##
============================================
- Coverage 52.97% 52.97% -0.01%
+ Complexity 439 438 -1
============================================
Files 1181 1181
Lines 20776 20778 +2
Branches 3740 3741 +1
============================================
Hits 11007 11007
Misses 9089 9089
- Partials 680 682 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5917?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...enter/listener/DataSourceStateChangedListener.java](https://codecov.io/gh/apache/shardingsphere/pull/5917/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtcmVnaXN0cnljZW50ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY29yZS9yZWdpc3RyeWNlbnRlci9saXN0ZW5lci9EYXRhU291cmNlU3RhdGVDaGFuZ2VkTGlzdGVuZXIuamF2YQ==) | `62.50% <0.00%> (-8.93%)` | `0.00 <0.00> (ø)` | |
| [...rchestration/center/listener/DataChangedEvent.java](https://codecov.io/gh/apache/shardingsphere/pull/5917/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY2VudGVyL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY2VudGVyLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvbGlzdGVuZXIvRGF0YUNoYW5nZWRFdmVudC5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ter/instance/CuratorZookeeperCenterRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/5917/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY2VudGVyL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY2VudGVyLXpvb2tlZXBlci1jdXJhdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NlbnRlci9pbnN0YW5jZS9DdXJhdG9yWm9va2VlcGVyQ2VudGVyUmVwb3NpdG9yeS5qYXZh) | `74.57% <100.00%> (-0.64%)` | `26.00 <0.00> (-1.00)` | |
| [...gistrycenter/listener/RegistryListenerManager.java](https://codecov.io/gh/apache/shardingsphere/pull/5917/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtcmVnaXN0cnljZW50ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY29yZS9yZWdpc3RyeWNlbnRlci9saXN0ZW5lci9SZWdpc3RyeUxpc3RlbmVyTWFuYWdlci5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5917?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5917?src=pr&el=footer). Last update [52aa585...b509c54](https://codecov.io/gh/apache/shardingsphere/pull/5917?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking merged pull request #5917: Fixes failed to disable slave database
Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #5917:
URL: https://github.com/apache/shardingsphere/pull/5917
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org