You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/21 11:11:59 UTC
[GitHub] [pulsar] Jason918 opened a new pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar
Jason918 opened a new pull request #10670:
URL: https://github.com/apache/pulsar/pull/10670
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Fixes #10669
### Motivation
GC log is useful for production environment, I think it should take affect by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar
Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #10670:
URL: https://github.com/apache/pulsar/pull/10670#issuecomment-849409894
> @Jason918 Would you please help update your branch with the latest master? seems the always CI get failed.
OK, merged with master.
BTW, Is it my commits causing the CI failed? These updates seems trivial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 closed pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar
Posted by GitBox <gi...@apache.org>.
Jason918 closed pull request #10670:
URL: https://github.com/apache/pulsar/pull/10670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #10670:
URL: https://github.com/apache/pulsar/pull/10670#issuecomment-846648037
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10670:
URL: https://github.com/apache/pulsar/pull/10670#issuecomment-848226916
Now that we are running on Java 11 for the Docker image in master branch, there's a required change related to `PULSAR_GC_LOG` . It's not currently compatible with Java 11. The logic in `conf/pulsar_env.sh` to set PULSAR_GC_LOG currently handles only Java 8:
https://github.com/apache/pulsar/blob/8d3c0df33e6589bf1ab8cc427409c7d222509237/conf/pulsar_env.sh#L50-L58
there's also similar logic in `bin/function-localrunner` so it probably makes sense to fix that too:
https://github.com/apache/pulsar/blob/c6158e3d3e0e215e0bade91a557dc4bdb63cc297/bin/function-localrunner#L31-L39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #10670:
URL: https://github.com/apache/pulsar/pull/10670#issuecomment-848631508
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10670:
URL: https://github.com/apache/pulsar/pull/10670#issuecomment-848226916
Now that we are running on Java 11 for the Docker image in master branch, there's a required change related to `PULSAR_GC_LOG` . It's not currently compatible with Java 11. The logic in `conf/pulsar_env.sh` to set PULSAR_GC_LOG currently handles only Java 8:
https://github.com/apache/pulsar/blob/8d3c0df33e6589bf1ab8cc427409c7d222509237/conf/pulsar_env.sh#L50-L58
there's also similar logic in `bin/function-localrunner` so it probably makes sense to fix that too:
https://github.com/apache/pulsar/blob/c6158e3d3e0e215e0bade91a557dc4bdb63cc297/bin/function-localrunner#L31-L39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #10670:
URL: https://github.com/apache/pulsar/pull/10670#issuecomment-848040912
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar
Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #10670:
URL: https://github.com/apache/pulsar/pull/10670#issuecomment-849406340
> @Jason918 For bookie startup, it will be better to add gc log too. In my production env, i have add the gc log for broker, zookeeper and bookie.
OK, Added gc log for bookie in the updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 edited a comment on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar
Posted by GitBox <gi...@apache.org>.
Jason918 edited a comment on pull request #10670:
URL: https://github.com/apache/pulsar/pull/10670#issuecomment-849409894
> @Jason918 Would you please help update your branch with the latest master? seems the always CI get failed.
OK, merged with master.
BTW, Is it my commits causing the CI failed? These updates seem trivial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #10670:
URL: https://github.com/apache/pulsar/pull/10670#issuecomment-855877265
I agree with the motivation of the PR, it's useful for the production environment. Since we are trying to change the default value, it will make difference in the new Pulsar release, I think it's better to discuss this at the dev email thread first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #10670:
URL: https://github.com/apache/pulsar/pull/10670#issuecomment-848044641
@Jason918 For bookie startup, it will be better to add gc log too. In my production env, i have add the gc log for broker, zookeeper and bookie.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #10670:
URL: https://github.com/apache/pulsar/pull/10670#issuecomment-846648265
@merlimat @codelipenghui What do you think of this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org