You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/07/19 18:51:05 UTC

Review Request 12765: Removed the deprecated monitoring statistics.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12765/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Repository: mesos-git


Description
-------

We kept the usage.json endpoint for temporary backwards compatibility.


Diffs
-----

  src/slave/monitor.hpp 52568ad8ec566f7cf36c249c76d798d44eacb578 
  src/slave/monitor.cpp 4f3c91fce94918de43d7ad0b598d4902a46be8b6 

Diff: https://reviews.apache.org/r/12765/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Re: Review Request 12765: Removed the deprecated monitoring statistics.

Posted by Ben Mahler <be...@gmail.com>.

> On July 23, 2013, 2:44 a.m., Ross Allen wrote:
> > Several controllers in the UI call '/monitor/usage.json' on slaves. Is that the same endpoint being removed here? If so, we need to update the UI to use the new endpoint.

Good catch, yes that's being removed so I'll have to update the webui in this change as well. There's a bit of added complexity as we no longer expose "cpu_usage" through the endpoint. This means the webui will have to compute the usage from the raw values.

i.e.

(new_cpu_time - old_cpu_time) / (new_timestamp - old_timestamp)


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12765/#review23674
-----------------------------------------------------------


On July 19, 2013, 4:51 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12765/
> -----------------------------------------------------------
> 
> (Updated July 19, 2013, 4:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> We kept the usage.json endpoint for temporary backwards compatibility.
> 
> 
> Diffs
> -----
> 
>   src/slave/monitor.hpp 52568ad8ec566f7cf36c249c76d798d44eacb578 
>   src/slave/monitor.cpp 4f3c91fce94918de43d7ad0b598d4902a46be8b6 
> 
> Diff: https://reviews.apache.org/r/12765/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Re: Review Request 12765: Removed the deprecated monitoring statistics.

Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12765/#review23674
-----------------------------------------------------------


Several controllers in the UI call '/monitor/usage.json' on slaves. Is that the same endpoint being removed here? If so, we need to update the UI to use the new endpoint.

- Ross Allen


On July 19, 2013, 4:51 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12765/
> -----------------------------------------------------------
> 
> (Updated July 19, 2013, 4:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> We kept the usage.json endpoint for temporary backwards compatibility.
> 
> 
> Diffs
> -----
> 
>   src/slave/monitor.hpp 52568ad8ec566f7cf36c249c76d798d44eacb578 
>   src/slave/monitor.cpp 4f3c91fce94918de43d7ad0b598d4902a46be8b6 
> 
> Diff: https://reviews.apache.org/r/12765/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Re: Review Request 12765: Removed the deprecated monitoring statistics.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12765/
-----------------------------------------------------------

(Updated Jan. 15, 2014, 1:44 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Forgot to remove CPU_TIME_SECS in this change.


Bugs: MESOS-519
    https://issues.apache.org/jira/browse/MESOS-519


Repository: mesos-git


Description
-------

We kept the usage.json endpoint for temporary backwards compatibility.


Diffs (updated)
-----

  src/slave/monitor.hpp 52568ad8ec566f7cf36c249c76d798d44eacb578 
  src/slave/monitor.cpp a931c4f35a8793c66ee03de82f0e0a21b92f8ffa 
  src/tests/monitor_tests.cpp a341893b16fbe502fa32704fcd1f3f85519ad253 

Diff: https://reviews.apache.org/r/12765/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Re: Review Request 12765: Removed the deprecated monitoring statistics.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12765/#review31832
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Jan. 14, 2014, 7:08 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12765/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 7:08 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Bugs: MESOS-519
>     https://issues.apache.org/jira/browse/MESOS-519
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> We kept the usage.json endpoint for temporary backwards compatibility.
> 
> 
> Diffs
> -----
> 
>   src/slave/monitor.hpp 52568ad8ec566f7cf36c249c76d798d44eacb578 
>   src/slave/monitor.cpp a931c4f35a8793c66ee03de82f0e0a21b92f8ffa 
>   src/tests/monitor_tests.cpp a341893b16fbe502fa32704fcd1f3f85519ad253 
> 
> Diff: https://reviews.apache.org/r/12765/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Re: Review Request 12765: Removed the deprecated monitoring statistics.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12765/
-----------------------------------------------------------

(Updated Jan. 14, 2014, 7:08 a.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
-------

Rebase.


Bugs: MESOS-519
    https://issues.apache.org/jira/browse/MESOS-519


Repository: mesos-git


Description
-------

We kept the usage.json endpoint for temporary backwards compatibility.


Diffs (updated)
-----

  src/slave/monitor.hpp 52568ad8ec566f7cf36c249c76d798d44eacb578 
  src/slave/monitor.cpp a931c4f35a8793c66ee03de82f0e0a21b92f8ffa 
  src/tests/monitor_tests.cpp a341893b16fbe502fa32704fcd1f3f85519ad253 

Diff: https://reviews.apache.org/r/12765/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Re: Review Request 12765: Removed the deprecated monitoring statistics.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12765/
-----------------------------------------------------------

(Updated Aug. 15, 2013, 10:13 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Rebased and fixed the tests. This is now part of a chain of reviews that ends with updating the webui to poll the monitoring information.


Bugs: MESOS-519
    https://issues.apache.org/jira/browse/MESOS-519


Repository: mesos-git


Description
-------

We kept the usage.json endpoint for temporary backwards compatibility.


Diffs (updated)
-----

  src/slave/monitor.hpp 52568ad8ec566f7cf36c249c76d798d44eacb578 
  src/slave/monitor.cpp 8e1eb353c55f9a04b07c382c10c669715a2d7ac2 
  src/tests/monitor_tests.cpp 31424160b0493ef37705be25cd97f74e027d85ef 

Diff: https://reviews.apache.org/r/12765/diff/


Testing
-------

make check


Thanks,

Ben Mahler