You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "FMX (via GitHub)" <gi...@apache.org> on 2023/05/16 03:41:58 UTC

[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

FMX commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1194565549


##########
common/src/main/scala/org/apache/celeborn/common/network/CelebornRackResolver.scala:
##########
@@ -32,6 +32,8 @@ import org.apache.celeborn.common.util.CelebornHadoopUtils
 
 class CelebornRackResolver(celebornConf: CelebornConf) extends Logging {

Review Comment:
   How about moving this class to master module? I found that our common module contains too much content.



##########
common/src/main/scala/org/apache/celeborn/common/network/CelebornRackResolver.scala:
##########
@@ -32,6 +32,8 @@ import org.apache.celeborn.common.util.CelebornHadoopUtils
 
 class CelebornRackResolver(celebornConf: CelebornConf) extends Logging {
 
+  val enabledRackAware = celebornConf.slotsAssignRackAwareEnabled
+
   private val dnsToSwitchMapping: DNSToSwitchMapping = {
     val conf: Configuration = CelebornHadoopUtils.newConfiguration(celebornConf)

Review Comment:
   How about move CelebornHadoopUtils to master module? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org