[GitHub] [incubator-superset] schoel-bis commented on issue #7822: Line chart tooltips broken on Firefox

[GitBox <gi...@apache.org>]

schoel-bis commented on issue #7822: Line chart tooltips broken on Firefox
URL: https://github.com/apache/incubator-superset/issues/7822#issuecomment-515421126
 
 
   I am seeing the same here. This is due to #7102, more precisely the style for the body element in ` superset/assets/stylesheets/less/index.less`.
   
   The `position: absolute` setting on the `body` element causes Firefox to calculate the height (and consequently the `clientHeight`) of the `html` element as 0 as absolutely positioned elements have no influence on their parent's height. But NVD3 uses `document.documentElement.clientHeight` (`documentElement` is the `html` element) in the formula for calculating the position of the tooltip. Since it is always `0` on Firefox the calculation produces a grossly false result and places the tooltip off-screen.
   
   My understanding of the change from the pull request above is that is meant to ensure that the body will always cover the entire window. A similar effect should be achievable with something like the following while avoiding the problem described above:
   
   ```less
   html {
     height: 100%;
   }
   
   body {
     min-height: 100%;
     display: flex;
     flex-direction: column;
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org