You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2017/08/24 22:32:56 UTC
[Impala-ASF-CR] IMPALA-5846: Fix output path for kudu libraries
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7818
Change subject: IMPALA-5846: Fix output path for kudu libraries
......................................................................
IMPALA-5846: Fix output path for kudu libraries
Prior to this patch, libraries and executables built using
ADD_EXPORTABLE_LIBRARY (i.e. those built from be/src/kudu) were placed
in their source directory - not in be/build/<etc>.
The problem appears to be related to how LIBRARY_OUTPUT_PATH was set by
ADD_EXPORTABLE_LIBRARY. I confess I don't completely understand the bug,
but this more idiomatic (and clear, IMHO) way of setting the output dirs
has the expected behaviour.
Change-Id: I73f3dd5435bceb35bc929ff6d5f2c92300e2a1d2
---
M cmake_modules/kudu_cmake_fns.txt
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/7818/1
--
To view, visit http://gerrit.cloudera.org:8080/7818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73f3dd5435bceb35bc929ff6d5f2c92300e2a1d2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-5846: Fix output path for kudu libraries
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5846: Fix output path for kudu libraries
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73f3dd5435bceb35bc929ff6d5f2c92300e2a1d2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5846: Fix output path for kudu libraries
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5846: Fix output path for kudu libraries
......................................................................
Patch Set 1: Code-Review+2
I took a quick look at the cmake docs and I also don't fully understand what was wrong with the old code. However the new code seems to match what is recommended.
--
To view, visit http://gerrit.cloudera.org:8080/7818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73f3dd5435bceb35bc929ff6d5f2c92300e2a1d2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5846: Fix output path for kudu libraries
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5846: Fix output path for kudu libraries
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1155/
--
To view, visit http://gerrit.cloudera.org:8080/7818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73f3dd5435bceb35bc929ff6d5f2c92300e2a1d2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5846: Fix output path for kudu libraries
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5846: Fix output path for kudu libraries
......................................................................
IMPALA-5846: Fix output path for kudu libraries
Prior to this patch, libraries and executables built using
ADD_EXPORTABLE_LIBRARY (i.e. those built from be/src/kudu) were placed
in their source directory - not in be/build/<etc>.
The problem appears to be related to how LIBRARY_OUTPUT_PATH was set by
ADD_EXPORTABLE_LIBRARY. I confess I don't completely understand the bug,
but this more idiomatic (and clear, IMHO) way of setting the output dirs
has the expected behaviour.
Change-Id: I73f3dd5435bceb35bc929ff6d5f2c92300e2a1d2
Reviewed-on: http://gerrit.cloudera.org:8080/7818
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M cmake_modules/kudu_cmake_fns.txt
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I73f3dd5435bceb35bc929ff6d5f2c92300e2a1d2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>