You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2023/02/28 15:16:19 UTC

[kafka] branch trunk updated: MINOR: srcJar should depend on processMessages task (#13316)

This is an automated email from the ASF dual-hosted git repository.

ijuma pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new dcc17999515 MINOR: srcJar should depend on processMessages task (#13316)
dcc17999515 is described below

commit dcc179995153c22c6248702976b60755b0b9fda8
Author: Ismael Juma <is...@juma.me.uk>
AuthorDate: Tue Feb 28 07:16:09 2023 -0800

    MINOR: srcJar should depend on processMessages task (#13316)
    
    This fixes the following `./gradlew install` issue:
    
    ```text
    * What went wrong:
    A problem was found with the configuration of task ':storage:srcJar' (type 'Jar').
      - Gradle detected a problem with the following location: '/Users/ijuma/src/kafka/storage/src/generated/java'.
    
        Reason: Task ':storage:srcJar' uses this output of task ':storage:processMessages' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
        Possible solutions:
          1. Declare task ':storage:processMessages' as an input of ':storage:srcJar'.
          2. Declare an explicit dependency on ':storage:processMessages' from ':storage:srcJar' using Task#dependsOn.
          3. Declare an explicit dependency on ':storage:processMessages' from ':storage:srcJar' using Task#mustRunAfter.
    
        Please refer to https://docs.gradle.org/8.0.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
    ```
    
    Reviewers: David Jacot <da...@gmail.com>
---
 build.gradle | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/build.gradle b/build.gradle
index 396506d1a5b..2ed096ab586 100644
--- a/build.gradle
+++ b/build.gradle
@@ -982,6 +982,7 @@ project(':core') {
   }
 
   compileJava.dependsOn 'processMessages'
+  srcJar.dependsOn 'processMessages'
 
   task genProtocolErrorDocs(type: JavaExec) {
     classpath = sourceSets.main.runtimeClasspath
@@ -1213,6 +1214,7 @@ project(':metadata') {
   }
 
   compileJava.dependsOn 'processMessages'
+  srcJar.dependsOn 'processMessages'
 
   sourceSets {
     main {
@@ -1287,6 +1289,7 @@ project(':group-coordinator') {
   }
 
   compileJava.dependsOn 'processMessages'
+  srcJar.dependsOn 'processMessages'
 }
 
 project(':examples') {
@@ -1425,6 +1428,7 @@ project(':clients') {
   }
 
   compileJava.dependsOn 'processMessages'
+  srcJar.dependsOn 'processMessages'
 
   compileTestJava.dependsOn 'processTestMessages'
 
@@ -1527,6 +1531,7 @@ project(':raft') {
   }
 
   compileJava.dependsOn 'processMessages'
+  srcJar.dependsOn 'processMessages'
 
   jar {
     dependsOn createVersionFile
@@ -1749,6 +1754,7 @@ project(':storage') {
   }
 
   compileJava.dependsOn 'processMessages'
+  srcJar.dependsOn 'processMessages'
 
   jar {
     dependsOn createVersionFile
@@ -1987,6 +1993,7 @@ project(':streams') {
   }
 
   compileJava.dependsOn 'processMessages'
+  srcJar.dependsOn 'processMessages'
 
   javadoc {
     include "**/org/apache/kafka/streams/**"