You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by ad...@apache.org on 2016/12/06 18:40:31 UTC
[3/3] kudu git commit: client: don't log retriable scanner errors
client: don't log retriable scanner errors
Retriable scanner errors are a normal part of life. Prior to this patch,
every such error (eg SERVER_TOO_BUSY) resulted in both an INFO and a
WARNING message logged in the client.
In an Impala stress scenario this was producing several hundred logs per
second, even while queries were mostly succeeding.
This downgrades them to a VLOG(1) level.
Change-Id: I32e16dd10f9de8a015d420da4b58b2f363045f67
Reviewed-on: http://gerrit.cloudera.org:8080/5380
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/aaca775d
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/aaca775d
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/aaca775d
Branch: refs/heads/master
Commit: aaca775da7f5e9d191627159417695848285790d
Parents: 8877b83
Author: Todd Lipcon <to...@apache.org>
Authored: Tue Dec 6 19:28:52 2016 +0800
Committer: Adar Dembo <ad...@cloudera.com>
Committed: Tue Dec 6 18:38:19 2016 +0000
----------------------------------------------------------------------
src/kudu/client/client.cc | 10 ++++++----
src/kudu/client/scanner-internal.cc | 6 +++---
2 files changed, 9 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/aaca775d/src/kudu/client/client.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/client.cc b/src/kudu/client/client.cc
index b634548..9095a4b 100644
--- a/src/kudu/client/client.cc
+++ b/src/kudu/client/client.cc
@@ -1309,11 +1309,13 @@ Status KuduScanner::NextBatch(KuduScanBatch* batch) {
data_->scan_attempts_++;
// Error handling.
- LOG(WARNING) << "Scan at tablet server " << data_->ts_->ToString() << " of tablet "
- << ToString() << " failed: " << result.status.ToString();
-
set<string> blacklist;
- RETURN_NOT_OK(data_->HandleError(result, batch_deadline, &blacklist));
+ Status s = data_->HandleError(result, batch_deadline, &blacklist);
+ if (!s.ok()) {
+ LOG(WARNING) << "Scan at tablet server " << data_->ts_->ToString() << " of tablet "
+ << ToString() << " failed: " << result.status.ToString();
+ return s;
+ }
if (data_->configuration().is_fault_tolerant()) {
LOG(WARNING) << "Attempting to retry scan of tablet " << ToString() << " elsewhere.";
http://git-wip-us.apache.org/repos/asf/kudu/blob/aaca775d/src/kudu/client/scanner-internal.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/scanner-internal.cc b/src/kudu/client/scanner-internal.cc
index 311a7bf..07f93a7 100644
--- a/src/kudu/client/scanner-internal.cc
+++ b/src/kudu/client/scanner-internal.cc
@@ -131,9 +131,9 @@ Status KuduScanner::Data::HandleError(const ScanRpcStatus& err,
return last_error_.ok() ?
ret : ret.CloneAndAppend(last_error_.ToString());
}
- LOG(INFO) << "Error scanning on server " << ts_->ToString() << ": "
- << err.status.ToString() << ". Will retry after "
- << sleep.ToString() << "; attempt " << scan_attempts_;
+ VLOG(1) << "Error scanning on server " << ts_->ToString() << ": "
+ << err.status.ToString() << ". Will retry after "
+ << sleep.ToString() << "; attempt " << scan_attempts_;
SleepFor(sleep);
}
if (can_retry) {