You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Robert Pluim <rp...@bigfoot.com> on 2003/04/01 14:41:07 UTC
[PATCH] svn diff doesn't check path existence all the time
[I ran across this whilst looking at issue 1061]
Transcript:
rpluim: ~/wc-test/local-wc1/foo
$ svn diff file:///home/rpluim/testrepo/trunk/foo/7000 file:///home/rpluim/testrepo/trunk/foo/1097
rpluim: ~/wc-test/local-wc1/foo
$
foo/7000 has never existed in this repository at any time. However:
rpluim: ~/wc-test/local-wc1/foo
$ svn diff file:///home/rpluim/testrepo/trunk/foo/1097 file:///home/rpluim/testrepo/trunk/foo/7000
subversion/libsvn_client/diff.c:1361: (apr_err=160013)
svn: Filesystem has no item
svn: 'file:///home/rpluim/testrepo/trunk/foo/7000' at rev 28 wasn't found in repository.
I'm attaching a patch, but I don't know the code well enough to see if
there are cases where you _don't_ want to check for the existence of
the first URL.
Log:
* svn/subversion/libsvn_client/diff.c (do_diff): Check that the
filesystem actually has the item specified as URL1@N
Patch:
Re: [PATCH] svn diff doesn't check path existence all the time
Posted by Matt Kraai <kr...@alumni.cmu.edu>.
On Wed, Apr 02, 2003 at 05:07:35PM +0200, Robert Pluim wrote:
> * subversion/libsvn_client/diff.c (do_diff): Check that the filesystem
> actually has the item specified as URL1@N (URL2 was already being
> checked).
>
> * subversion/tests/clients/cmdline/diff_tests.py : Test that 'svn diff
> URL1 URL2' fails if either of the URLs does not exist in the
> repository.
Other than some Python formatting issues, it looks good. Thanks.
If the regression tests I'm running succeed, I'll commit my
tweaked version.
Matt
--
It's most certainly GNU/Linux, not Linux. Read more at
http://www.gnu.org/gnu/why-gnu-linux.html.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svn diff doesn't check path existence all the time
Posted by Robert Pluim <rp...@bigfoot.com>.
Robert Pluim writes:
XEmacs is still resisting, but anyway. Python criticism gratefully
accepted, it's not something I've written a lot of.
Log:
* subversion/libsvn_client/diff.c (do_diff): Check that the filesystem
actually has the item specified as URL1@N (URL2 was already being
checked).
* subversion/tests/clients/cmdline/diff_tests.py : Test that 'svn diff
URL1 URL2' fails if either of the URLs does not exist in the
repository.
Re: [PATCH] svn diff doesn't check path existence all the time
Posted by Robert Pluim <rp...@bigfoot.com>.
Matt> On Tue, Apr 01, 2003 at 04:41:07PM +0200, Robert Pluim
Matt> wrote:
>> I'm attaching a patch, but I don't know the code well enough to
>> see if there are cases where you _don't_ want to check for the
>> existence of the first URL.
Matt> Could you add a test case?
<Hackity Hack> Wow, python's pretty nice. Why have I been avoiding it
all these years?
Test case tomorrow, after I beat the Emacs svn interface into
submission (and if I don't manage that, back to cut & paste).
--
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svn diff doesn't check path existence all the time
Posted by Matt Kraai <kr...@alumni.cmu.edu>.
On Tue, Apr 01, 2003 at 04:41:07PM +0200, Robert Pluim wrote:
> I'm attaching a patch, but I don't know the code well enough to see if
> there are cases where you _don't_ want to check for the existence of
> the first URL.
Could you add a test case?
Matt
--
It's most certainly GNU/Linux, not Linux. Read more at
http://www.gnu.org/gnu/why-gnu-linux.html.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org