You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "DL1231 (via GitHub)" <gi...@apache.org> on 2025/02/28 02:44:13 UTC
[PR] KAFKA-18817:[1/N] ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe [kafka]
DL1231 opened a new pull request, #19055:
URL: https://github.com/apache/kafka/pull/19055
1、Client support for TopicAuthException in DescribeShareGroup and HB path
2、ShareConsumerImpl#sendAcknowledgementsAndLeaveGroup swallow TopicAuthorizationException and GroupAuthorizationException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18817:[1/N] ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe [kafka]
Posted by "ShivsundarR (via GitHub)" <gi...@apache.org>.
ShivsundarR commented on code in PR #19055:
URL: https://github.com/apache/kafka/pull/19055#discussion_r1975285732
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareHeartbeatRequestManagerTest.java:
##########
@@ -402,6 +402,12 @@ public void testHeartbeatResponseOnErrorHandling(final Errors error, final boole
assertNextHeartbeatTiming(0);
break;
+ case TOPIC_AUTHORIZATION_FAILED:
+ verify(backgroundEventHandler).add(any(ErrorEvent.class));
+ assertNextHeartbeatTiming(DEFAULT_RETRY_BACKOFF_MS);
+ verify(membershipManager, never()).transitionToFatal();
+ break;
Review Comment:
This change was introduced in `AbstractHeartbeatRequestManager` and had a similar test in `ConsumerHeartbeatRequestManagerTest`. There is a JIRA(https://issues.apache.org/jira/browse/KAFKA-18862) to decide if we should duplicate the changes to this test as well.
Maybe we can avoid the change here as the test is probably going to be removed, but I do not mind it being there as well before that JIRA is addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18817:[1/N] ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #19055:
URL: https://github.com/apache/kafka/pull/19055#discussion_r1975724557
##########
clients/src/main/java/org/apache/kafka/common/requests/ShareGroupHeartbeatResponse.java:
##########
@@ -35,6 +35,7 @@
* - {@link Errors#INVALID_REQUEST}
* - {@link Errors#UNKNOWN_MEMBER_ID}
* - {@link Errors#GROUP_MAX_SIZE_REACHED}
+ * - {@link Errors#TOPIC_AUTHORIZATION_FAILED}
Review Comment:
Please add this to the JSON schema too.
##########
clients/src/main/java/org/apache/kafka/common/requests/ShareGroupDescribeResponse.java:
##########
@@ -35,6 +35,7 @@
* - {@link Errors#INVALID_REQUEST}
* - {@link Errors#INVALID_GROUP_ID}
* - {@link Errors#GROUP_ID_NOT_FOUND}
+ * - {@link Errors#TOPIC_AUTHORIZATION_FAILED}
Review Comment:
Please add this to the JSON schema too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18817:[1/N] ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield merged PR #19055:
URL: https://github.com/apache/kafka/pull/19055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org