You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by SleuthKid <gi...@git.apache.org> on 2017/09/30 12:04:17 UTC
[GitHub] couchdb-ci pull request #3: Add support for Debian 9 aka. stretch
GitHub user SleuthKid opened a pull request:
https://github.com/apache/couchdb-ci/pull/3
Add support for Debian 9 aka. stretch
Adding support for the Debian 9 (stretch) build environment.
REF: apache/couchdb#781
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SleuthKid/couchdb-ci add-debian-9
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-ci/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit 8740e17766ca664eb88ecea7cbdaab7ef6294459
Author: Robert Haist <sl...@mailbox.org>
Date: 2017-09-30T12:01:20Z
Add support for Debian 9 aka. stretch
----
---
[GitHub] couchdb-ci pull request #3: Add support for Debian 9 aka. stretch
Posted by SleuthKid <gi...@git.apache.org>.
Github user SleuthKid commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/3#discussion_r142012121
--- Diff: ansible/debian-9-erlang-18.3.yml ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+- hosts: couchdb-ci-worker
+ vars:
+ erlang_solutions_pkg_ver: "1:18.3-1"
--- End diff --
As far as I understand there are two different builds. One with 18.3 (LTS?!) and one with the distribution default erlang (ansible/debian-9-erlang-default.yml) , 19.2 in that case.
---
[GitHub] couchdb-ci pull request #3: Add support for Debian 9 aka. stretch
Posted by wohali <gi...@git.apache.org>.
Github user wohali commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/3#discussion_r142037422
--- Diff: bin/debian-9-base/create-container.sh ---
@@ -0,0 +1,28 @@
+#!/usr/bin/env bash
--- End diff --
No. We've found some serious segfaults in the libmozjs185-1.0 package and build our own with different flags to avoid these.
---
[GitHub] couchdb-ci pull request #3: Add support for Debian 9 aka. stretch
Posted by wohali <gi...@git.apache.org>.
Github user wohali commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/3#discussion_r142531509
--- Diff: ansible/roles/spidermonkey/tasks/main.yml ---
@@ -19,19 +19,30 @@
get_url:
url: "http://ftp.mozilla.org/pub/mozilla.org/js/js185-1.0.0.tar.gz"
dest: /tmp/js185-1.0.0.tar.gz
+
- name: unpack Spidermonkey 1.8.5
unarchive:
src: /tmp/js185-1.0.0.tar.gz
dest: /opt
copy: no
+
+- name: patch source for debian9 build
+ patch:
+ src: "{{ role_path }}/files/fix-811665.patch"
+ basedir: /opt/js-1.8.5/
+ strip: 1
+ when: ansible_distribution == "Debian"
--- End diff --
This needs to be conditional to only apply this patch for the Debian 9 build, not all builds please.
---
[GitHub] couchdb-ci pull request #3: Add support for Debian 9 aka. stretch
Posted by SleuthKid <gi...@git.apache.org>.
Github user SleuthKid commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/3#discussion_r142028521
--- Diff: bin/debian-9-base/create-container.sh ---
@@ -0,0 +1,28 @@
+#!/usr/bin/env bash
--- End diff --
Debian provides the libmozjs185-1.0 package with the same spidermonkey version. Could we just skip the source build and use that?
---
[GitHub] couchdb-ci pull request #3: Add support for Debian 9 aka. stretch
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-ci/pull/3
---
[GitHub] couchdb-ci pull request #3: Add support for Debian 9 aka. stretch
Posted by wohali <gi...@git.apache.org>.
Github user wohali commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/3#discussion_r142012226
--- Diff: ansible/debian-9-erlang-18.3.yml ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+- hosts: couchdb-ci-worker
+ vars:
+ erlang_solutions_pkg_ver: "1:18.3-1"
--- End diff --
We currently build against 18.3 in our CI pipeline and for released packages. When we move up to 19, we'll move to 19 across all releases, not just this one.
---
[GitHub] couchdb-ci pull request #3: Add support for Debian 9 aka. stretch
Posted by SleuthKid <gi...@git.apache.org>.
Github user SleuthKid commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/3#discussion_r142598289
--- Diff: ansible/roles/spidermonkey/tasks/main.yml ---
@@ -19,19 +19,30 @@
get_url:
url: "http://ftp.mozilla.org/pub/mozilla.org/js/js185-1.0.0.tar.gz"
dest: /tmp/js185-1.0.0.tar.gz
+
- name: unpack Spidermonkey 1.8.5
unarchive:
src: /tmp/js185-1.0.0.tar.gz
dest: /opt
copy: no
+
+- name: patch source for debian9 build
+ patch:
+ src: "{{ role_path }}/files/fix-811665.patch"
+ basedir: /opt/js-1.8.5/
+ strip: 1
+ when: ansible_distribution == "Debian"
--- End diff --
Done :+1:
---
[GitHub] couchdb-ci pull request #3: Add support for Debian 9 aka. stretch
Posted by rajudev <gi...@git.apache.org>.
Github user rajudev commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/3#discussion_r142012055
--- Diff: ansible/debian-9-erlang-18.3.yml ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+- hosts: couchdb-ci-worker
+ vars:
+ erlang_solutions_pkg_ver: "1:18.3-1"
--- End diff --
Why not do it for the for the version of erlang in stable. which is 19.2
instead of 18.3
https://tracker.debian.org/pkg/erlang
---
[GitHub] couchdb-ci pull request #3: Add support for Debian 9 aka. stretch
Posted by SleuthKid <gi...@git.apache.org>.
Github user SleuthKid commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/3#discussion_r142028127
--- Diff: bin/debian-9-base/create-container.sh ---
@@ -0,0 +1,28 @@
+#!/usr/bin/env bash
--- End diff --
Good catch. Solved with 7fb7bc9
---
[GitHub] couchdb-ci pull request #3: Add support for Debian 9 aka. stretch
Posted by wohali <gi...@git.apache.org>.
Github user wohali commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/3#discussion_r142018605
--- Diff: bin/debian-9-base/create-container.sh ---
@@ -0,0 +1,28 @@
+#!/usr/bin/env bash
--- End diff --
None of these .sh scripts are set `chmod +x`. Please do so.
---
[GitHub] couchdb-ci pull request #3: Add support for Debian 9 aka. stretch
Posted by SleuthKid <gi...@git.apache.org>.
Github user SleuthKid commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/3#discussion_r142366541
--- Diff: bin/debian-9-base/create-container.sh ---
@@ -0,0 +1,28 @@
+#!/usr/bin/env bash
--- End diff --
This bug is actually fixed in the debian package: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=811665
Besides GCC6 prints a lot of possible errors (warnings) in the source code that are partly addressed by the debian packaging team.
I would recommend using the official package - at least for the stretch build as the root of your problems with seem to come from building for arm?
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=839048
---
[GitHub] couchdb-ci pull request #3: Add support for Debian 9 aka. stretch
Posted by rajudev <gi...@git.apache.org>.
Github user rajudev commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/3#discussion_r142012380
--- Diff: ansible/debian-9-erlang-18.3.yml ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+- hosts: couchdb-ci-worker
+ vars:
+ erlang_solutions_pkg_ver: "1:18.3-1"
--- End diff --
understood. Thanks for the explanation.
---
[GitHub] couchdb-ci pull request #3: Add support for Debian 9 aka. stretch
Posted by rajudev <gi...@git.apache.org>.
Github user rajudev commented on a diff in the pull request:
https://github.com/apache/couchdb-ci/pull/3#discussion_r142012193
--- Diff: ansible/debian-9-erlang-18.3.yml ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+- hosts: couchdb-ci-worker
+ vars:
+ erlang_solutions_pkg_ver: "1:18.3-1"
--- End diff --
As far as I understand, the number 18.3 refers to the version of erlang in that particular distro. which in case of stretch is 19.2 . I may be wrong. but that is what I infer from the situation.
---