You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2019/01/04 18:51:10 UTC
[GitHub] codecov-io edited a comment on issue #3568: Add guava cache to
cache table schema in pinot broker
codecov-io edited a comment on issue #3568: Add guava cache to cache table schema in pinot broker
URL: https://github.com/apache/incubator-pinot/pull/3568#issuecomment-443390975
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=h1) Report
> Merging [#3568](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/ef32663fe45003c17272e24057e76cfe830fe8a3?src=pr&el=desc) will **decrease** coverage by `11.86%`.
> The diff coverage is `34.28%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3568 +/- ##
=============================================
- Coverage 70.68% 58.82% -11.87%
Complexity 4 4
=============================================
Files 1012 1148 +136
Lines 46454 58266 +11812
Branches 6212 8066 +1854
=============================================
+ Hits 32838 34274 +1436
- Misses 11461 21612 +10151
- Partials 2155 2380 +225
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...m/linkedin/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi91dGlscy9Db21tb25Db25zdGFudHMuamF2YQ==) | `39.58% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yZXF1ZXN0aGFuZGxlci9CYXNlQnJva2VyUmVxdWVzdEhhbmRsZXIuamF2YQ==) | `67.64% <10%> (-11.72%)` | `0 <0> (ø)` | |
| [...kedin/pinot/broker/broker/BrokerServerBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9icm9rZXIvQnJva2VyU2VydmVyQnVpbGRlci5qYXZh) | `91.66% <100%> (+0.14%)` | `0 <0> (ø)` | :arrow_down: |
| [...com/linkedin/pinot/common/metrics/BrokerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9tZXRyaWNzL0Jyb2tlck1ldGVyLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9icm9rZXIvaGVsaXgvSGVsaXhCcm9rZXJTdGFydGVyLmphdmE=) | `72.88% <100%> (+0.7%)` | `0 <0> (ø)` | :arrow_down: |
| [...thandler/SingleConnectionBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yZXF1ZXN0aGFuZGxlci9TaW5nbGVDb25uZWN0aW9uQnJva2VyUmVxdWVzdEhhbmRsZXIuamF2YQ==) | `88.09% <100%> (-0.55%)` | `0 <0> (ø)` | |
| [...esthandler/ConnectionPoolBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yZXF1ZXN0aGFuZGxlci9Db25uZWN0aW9uUG9vbEJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `88.05% <100%> (-0.15%)` | `0 <0> (ø)` | |
| [.../pinot/broker/requesthandler/TableSchemaCache.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yZXF1ZXN0aGFuZGxlci9UYWJsZVNjaGVtYUNhY2hlLmphdmE=) | `50% <50%> (ø)` | `0 <0> (?)` | |
| [...in/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3BydW5lci9WYWxpZFNlZ21lbnRQcnVuZXIuamF2YQ==) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | |
| [.../core/operator/query/SelectionOrderByOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL3F1ZXJ5L1NlbGVjdGlvbk9yZGVyQnlPcGVyYXRvci5qYXZh) | `78.37% <0%> (-13.29%)` | `0% <0%> (ø)` | |
| ... and [266 more](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=footer). Last update [ef32663...c58c1ae](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org