[GitHub] [cloudstack] GabrielBrascher commented on pull request #4257: remove the unnecessary check for tags when migrating volumes

[GitBox <gi...@apache.org>]

GabrielBrascher commented on pull request #4257:
URL: https://github.com/apache/cloudstack/pull/4257#issuecomment-888602105


   I don't see why this PR should be closed in favour of  https://github.com/apache/cloudstack/pull/5008. #4257 has a clear description and addresses a specific issue that can be easily tested, reproduced, and if necessary, reverted.
   
   Additionally, last time I've checked #5008 it was without description and set as a draft; looking #5008 right now it hasn't changed much. Nothing against #5008, but I think that both PRs can live together and this one has been open for a long time.
   
   To be honest, I am a bit worried with how we are handling some PRs from new contributors. It almost seems like some contributors have a hard time proposing, discussing, implementing, testing ... and then the PR is closed in favour of another work that introduces the same fix/behavior.
   
   This is just an example. If we go this way it will start to be hard for new contributors to implement something as it can be put aside for months and then closed in favour of any PR.
   
   I understand @RodrigoDLopez frustrations, some other examples that I've noticed  are:
   - https://github.com/apache/cloudstack/pull/4283
   - https://github.com/apache/cloudstack/pull/4282


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org