Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1361837955


##########
dev/create-release/release-build.sh:
##########
@@ -432,14 +432,14 @@ if [[ "$1" == "publish-snapshot" ]]; then
   echo "</server></servers></settings>" >> $tmp_settings
 
   if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
-    $MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
+    $MVN --settings $tmp_settings -DskipTests -DskipTests -Dmaven.javadoc.skip=true $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
   fi
 
   if [[ $PUBLISH_SCALA_2_13 = 1 ]]; then
     if [[ $SPARK_VERSION < "4.0" ]]; then
       ./dev/change-scala-version.sh 2.13
     fi
-    $MVN --settings $tmp_settings -DskipTests $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
+    $MVN --settings $tmp_settings -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy

Review Comment:
   The new code perform a two-step deployment (first package, then deploy) when `PACKAGE_BEFORE_DEPLOY` is true. However, after observing the compile log, I found that the second step's `scala:4.7.1:compile`, and `scala:4.7.1:doc-jar` are not skipped. I'm unsure if this change can really solve the problem...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org