You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Robert Joseph Evans (Created) (JIRA)" <ji...@apache.org> on 2012/03/15 16:07:38 UTC
[jira] [Created] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Configuration no longer sets all keys in a deprecated key list.
---------------------------------------------------------------
Key: HADOOP-8172
URL: https://issues.apache.org/jira/browse/HADOOP-8172
Project: Hadoop Common
Issue Type: Bug
Components: conf
Affects Versions: 0.24.0, 0.23.3
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans
Priority: Blocker
I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
{code}
if(!deprecated(key)) {
set(key, value);
} else {
for(String newKey: depricatedKeyMap.get(key)) {
set(newKey, value);
}
}
{code}
to be
{code}
set(key, value);
if(depricatedKeyMap.contains(key)) {
set(deprecatedKeyMap.get(key)[0], value);
} else if(reverseKeyMap.contains(key)) {
set(reverseKeyMap.get(key), value);
}
{code}
If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266157#comment-13266157 ]
Hudson commented on HADOOP-8172:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2184 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2184/])
HADOOP-8172. Configuration no longer sets all keys in a deprecated key list. (Anupam Seth via bobby) (Revision 1332821)
Result = ABORTED
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332821
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Critical
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266553#comment-13266553 ]
Hudson commented on HADOOP-8172:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1067 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1067/])
HADOOP-8172. Configuration no longer sets all keys in a deprecated key list. (Anupam Seth via bobby) (Revision 1332821)
Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332821
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Critical
> Fix For: 2.0.0, 3.0.0
>
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Anupam Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262081#comment-13262081 ]
Anupam Seth commented on HADOOP-8172:
-------------------------------------
Thanks Bobby. While a plain diff in the patch's javac warnings and the turnk's javac warnings is filled with noise from differences just in the branch-2 vs. trunk code bases, I was able to narrow down and find that these are deprecation warnings arising from my adding the @Deprecated tag to addDeprecation(String, String[]) method. These mostly arise in the file hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/util/ConfigUtil.java.
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Critical
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans resolved HADOOP-8172.
-----------------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
2.0.0
Thanks Anupam,
I put this into trunk and branch-2. +1
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Critical
> Fix For: 2.0.0, 3.0.0
>
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Anupam Seth (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anupam Seth updated HADOOP-8172:
--------------------------------
Status: Patch Available (was: Open)
Attaching patch. Kindly review.
Marking addDeprecated for String[] arguments as deprecated as there are 0 instances in the HDFS, Common and MR code that use this functionality and if other projects stop using it too, the resultant code could be a lot cleaner and simpler to understand.
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Blocker
> Attachments: HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254863#comment-13254863 ]
Hadoop QA commented on HADOOP-8172:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12522820/HADOOP-8172-branch-2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 1028 javac compiler warnings (more than the trunk's current 1014 warnings).
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.conf.TestConfigurationDeprecation
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/857//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/857//console
This message is automatically generated.
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Blocker
> Attachments: HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Robert Joseph Evans (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-8172:
----------------------------------------
Status: Open (was: Patch Available)
Anupam, Can you look into the increased javac warnings?
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Blocker
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-8172:
----------------------------------------
Fix Version/s: 0.23.3
Pulled this into branch0.23
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Critical
> Fix For: 0.23.3, 2.0.0-alpha, 3.0.0
>
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Anupam Seth (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anupam Seth updated HADOOP-8172:
--------------------------------
Status: Open (was: Patch Available)
Sorry - uploaded version of patch without the fix for the test failure.
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Blocker
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268421#comment-13268421 ]
Robert Joseph Evans commented on HADOOP-8172:
---------------------------------------------
Thanks for catching that Harsh.
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Critical
> Fix For: 2.0.0, 3.0.0
>
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Robert Joseph Evans (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans reassigned HADOOP-8172:
-------------------------------------------
Assignee: (was: Robert Joseph Evans)
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.24.0, 0.23.3
> Reporter: Robert Joseph Evans
> Priority: Blocker
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Anupam Seth (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anupam Seth updated HADOOP-8172:
--------------------------------
Attachment: HADOOP-8172-branch-2.patch
ploading latest version of patch
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Blocker
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425723#comment-13425723 ]
Hudson commented on HADOOP-8172:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #330 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/330/])
svn merge -c 1301551,1300642,1332821,1303884 FIXES:MAPREDUCE-4010,HADOOP-8167,HADOOP-8172,HADOOP-8197 Patches to fix OOZIE-761 (Revision 1367102)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367102
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestWritableJobConf.java
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Critical
> Fix For: 0.23.3, 2.0.0-alpha, 3.0.0
>
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266113#comment-13266113 ]
Hudson commented on HADOOP-8172:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2242 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2242/])
HADOOP-8172. Configuration no longer sets all keys in a deprecated key list. (Anupam Seth via bobby) (Revision 1332821)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332821
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Critical
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Anupam Seth (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anupam Seth updated HADOOP-8172:
--------------------------------
Status: Patch Available (was: Open)
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Blocker
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254923#comment-13254923 ]
Hadoop QA commented on HADOOP-8172:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12522826/HADOOP-8172-branch-2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 1028 javac compiler warnings (more than the trunk's current 1014 warnings).
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.fs.viewfs.TestViewFsTrash
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/858//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/858//console
This message is automatically generated.
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Blocker
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Anupam Seth (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anupam Seth reassigned HADOOP-8172:
-----------------------------------
Assignee: Anupam Seth
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Blocker
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Robert Joseph Evans (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-8172:
----------------------------------------
Priority: Critical (was: Blocker)
Dropping priority because in practice we are not using this feature.
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Critical
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268353#comment-13268353 ]
Harsh J commented on HADOOP-8172:
---------------------------------
This patch seems to have caused two new Javadocs warnings to appear in the aftermath apparently:
{code}
[WARNING] Javadoc Warnings
[WARNING] /Users/harshchouraria/Work/code/apache/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:334: warning - Tag @link: missing '#': "addDeprecation(String key, String newKey)"
[WARNING] /Users/harshchouraria/Work/code/apache/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:285: warning - Tag @link: missing '#': "addDeprecation(String key, String newKey,
[WARNING] String customMessage)"
{code}
I've filed HADOOP-8359 to address these.
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Critical
> Fix For: 2.0.0, 3.0.0
>
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Anupam Seth (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anupam Seth updated HADOOP-8172:
--------------------------------
Attachment: HADOOP-8172-branch-2.patch
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Blocker
> Attachments: HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266119#comment-13266119 ]
Hudson commented on HADOOP-8172:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2168 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2168/])
HADOOP-8172. Configuration no longer sets all keys in a deprecated key list. (Anupam Seth via bobby) (Revision 1332821)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332821
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Critical
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8172) Configuration no longer sets all
keys in a deprecated key list.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266535#comment-13266535 ]
Hudson commented on HADOOP-8172:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1032 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1032/])
HADOOP-8172. Configuration no longer sets all keys in a deprecated key list. (Anupam Seth via bobby) (Revision 1332821)
Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332821
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestDeprecatedKeys.java
> Configuration no longer sets all keys in a deprecated key list.
> ---------------------------------------------------------------
>
> Key: HADOOP-8172
> URL: https://issues.apache.org/jira/browse/HADOOP-8172
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Anupam Seth
> Priority: Critical
> Fix For: 2.0.0, 3.0.0
>
> Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch
>
>
> I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
> {code}
> if(!deprecated(key)) {
> set(key, value);
> } else {
> for(String newKey: depricatedKeyMap.get(key)) {
> set(newKey, value);
> }
> }
> {code}
> to be
> {code}
> set(key, value);
> if(depricatedKeyMap.contains(key)) {
> set(deprecatedKeyMap.get(key)[0], value);
> } else if(reverseKeyMap.contains(key)) {
> set(reverseKeyMap.get(key), value);
> }
> {code}
> If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira