You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "MonkeyCanCode (via GitHub)" <gi...@apache.org> on 2025/06/25 20:26:30 UTC
[PR] Fix admin tool for quick start [polaris]
MonkeyCanCode opened a new pull request, #1945:
URL: https://github.com/apache/polaris/pull/1945
When attempting to use the `polaris-admin-tool.jar` to bootstrap a realm, the application fails with a `jakarta.enterprise.inject.UnsatisfiedResolutionException` because it cannot find a `javax.sql.DataSource` bean. Detail in https://github.com/apache/polaris/issues/1943
This issue occurs because `quarkus.datasource.db-kind`is a build-time property in Quarkus. Its value must be defined during the application's build process to enable the datasource extension and generate the necessary CDI bean producer (ref: https://quarkus.io/guides/all-config#quarkus-datasource_quarkus-datasource-db-kind).
I think we only support postgres for now, thus, I set `quarkus.datasource.db-kind=postgresql`. This can be problematic if we later want to support more data sources other than postgres. There are couple options we have for this such as use multiple named datasources in the config during build time. But this may be out of scope of this PR. I am open for more discussion on this, but for the time being, it may be better to unblock people who are trying to use the quick start doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix admin tool for quick start [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard merged PR #1945:
URL: https://github.com/apache/polaris/pull/1945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix admin tool for quick start [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1945:
URL: https://github.com/apache/polaris/pull/1945#discussion_r2167723808
##########
runtime/admin/src/main/resources/application.properties:
##########
@@ -37,6 +37,7 @@ quarkus.container-image.additional-tags=latest
polaris.persistence.type=relational-jdbc
+quarkus.datasource.db-kind=postgresql
Review Comment:
Hi @dimas-b , does it affect normal use cases beside Quick Start examples?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix admin tool for quick start [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1945:
URL: https://github.com/apache/polaris/pull/1945#discussion_r2167725275
##########
runtime/admin/src/main/resources/application.properties:
##########
@@ -37,6 +37,7 @@ quarkus.container-image.additional-tags=latest
polaris.persistence.type=relational-jdbc
+quarkus.datasource.db-kind=postgresql
Review Comment:
IDK... I'm not even sure why Quick Start is broken... I never hit this problem in my env, but I used bootstrap a lot with Postgres :shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix admin tool for quick start [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1945:
URL: https://github.com/apache/polaris/pull/1945#discussion_r2167701459
##########
getting-started/jdbc/docker-compose-bootstrap-db.yml:
##########
@@ -22,7 +22,7 @@ services:
image: apache/polaris-admin-tool:postgres-latest
environment:
- POLARIS_PERSISTENCE_TYPE=relational-jdbc
- - QUARKUS_DATASOURCE_DB_KIND=pgsql
+ - QUARKUS_DATASOURCE_DB_KIND=postgresql
Review Comment:
Since the property is built-time, we can probably remove it from here for clarity, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix admin tool for quick start [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1945:
URL: https://github.com/apache/polaris/pull/1945#discussion_r2167720890
##########
runtime/admin/src/main/resources/application.properties:
##########
@@ -37,6 +37,7 @@ quarkus.container-image.additional-tags=latest
polaris.persistence.type=relational-jdbc
+quarkus.datasource.db-kind=postgresql
Review Comment:
Can we move up a bit if this is a build time setting? Anything below line 35 should be runtime properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix admin tool for quick start [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1945:
URL: https://github.com/apache/polaris/pull/1945#discussion_r2167725613
##########
runtime/admin/src/main/resources/application.properties:
##########
@@ -37,6 +37,7 @@ quarkus.container-image.additional-tags=latest
polaris.persistence.type=relational-jdbc
+quarkus.datasource.db-kind=postgresql
Review Comment:
Good point on property location: the built-time section is at the top of this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org