[GitHub] [spark] HeartSaVioR commented on a change in pull request #33870: [SPARK-36619][SS] Reset prefix-scan iterators on loading RocksDB

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #33870:
URL: https://github.com/apache/spark/pull/33870#discussion_r698961491



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
##########
@@ -120,6 +120,9 @@ class RocksDB(
       if (conf.resetStatsOnLoad) {
         nativeStats.reset
       }
+      // reset resources to prevent side-effects from previous loaded version

Review comment:
       We did this in rollback case but not in commit case. This doesn't bring problems in current implementation of session window, but I think we should fix it to avoid future correctness problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org