You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/08/02 06:42:52 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request, #4459: Modernize ActionsManager in Debugger API
lkishalmi opened a new pull request, #4459:
URL: https://github.com/apache/netbeans/pull/4459
Well, last week I had a chance to spend a few hours debugging the ActionsManager in the debugger API.
It was not a delightful experience. The code was written in ancient Java, sometimes it was hard to find out what does it want to do. So for make the debugging work easier, I've translated some of those ancient Java to a bit modern dialect.
After all I've found a small bug at https://github.com/apache/netbeans/blob/06a31ed66a97a0be7c9c9fe2a2fc0477f7b7e8b9/ide/api.debugger/src/org/netbeans/api/debugger/ActionsManager.java#L317 where the case ```'p1.equals(p2)``` was not handled well. But that it is easy to avoid to hit that codepath, so I did so in #4442, so the fix in the ActionManager was not required.
In order my translation efforts on the ActionsManager not to be vain, I've finished the translation of the whole file and put it here for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #4459: Modernize ActionsManager in Debugger API
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4459:
URL: https://github.com/apache/netbeans/pull/4459#issuecomment-1203059616
@mbien Well, that's true about the ArrayList, I'd expect 1-2 elements of this returned list, that's why I choose the Linked one.
Telling the truth, I would get rid of the whole method. When it is called, it means that we have two debugger support listening on the same action causing trouble like #4442. Instead of trying to resolve that issue with the heuristic applied by the path. I would pick the first one (should be ordered by the lookup position property) and write a warning message on the console.
That behavior could have saved me a few hours
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #4459: Modernize ActionsManager in Debugger API
Posted by GitBox <gi...@apache.org>.
lkishalmi merged PR #4459:
URL: https://github.com/apache/netbeans/pull/4459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists