[GitHub] [flink] pnowojski commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment
URL: https://github.com/apache/flink/pull/8416#discussion_r285507481
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/InputGateFairnessTest.java
 ##########
 @@ -327,7 +327,8 @@ public FairnessVerifyingInputGate(
 				boolean isCreditBased) {
 
 			super(owningTaskName, jobId, consumedResultId, ResultPartitionType.PIPELINED,
-				consumedSubpartitionIndex, numberOfInputChannels, taskActions, new SimpleCounter(), isCreditBased);
+				consumedSubpartitionIndex, numberOfInputChannels, taskActions, new SimpleCounter(),
+				isCreditBased, () -> null);
 
 Review comment:
   `null`?
   
   either:
   1a. if you are not expecting this supplier function to be ever called, `throw new UnsupportedOperationException()`.
   1b. if you are not expecting this supplier function to be ever called, it shows some problem in the design: probably this should be an argument of `setup()`'s method, not a constructor's parameter (check my previous comment).
   2. if `null` is supposed to be supported, change it to `Optional`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services