You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/15 15:05:00 UTC
[jira] [Work logged] (BEAM-3798) Performance tests flaky due to
Dataflow transient errors
[ https://issues.apache.org/jira/browse/BEAM-3798?focusedWorklogId=80862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-80862 ]
ASF GitHub Bot logged work on BEAM-3798:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/18 15:04
Start Date: 15/Mar/18 15:04
Worklog Time Spent: 10m
Work Description: lgajowy opened a new pull request #4871: [BEAM-3798] Remove error check on dataflow when getting batch job state
URL: https://github.com/apache/beam/pull/4871
In TestDataflowRunner beam can rely solely on Dataflow job state (for
batch jobs). It it's "DONE", then it means that Dataflow handled any
errors on it's own (eg. by retrying failed bundles). We don't need to
throw them further.
This PR does not fix a streaming scenario. We should fix it on separate
PR later. It still fixes Performance tests that we have now.
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand:
- [x] What the pull request does
- [x] Why it does it
- [x] How it does it
- [x] Why this approach
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 80862)
Time Spent: 10m
Remaining Estimate: 0h
> Performance tests flaky due to Dataflow transient errors
> --------------------------------------------------------
>
> Key: BEAM-3798
> URL: https://issues.apache.org/jira/browse/BEAM-3798
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Łukasz Gajowy
> Assignee: Thomas Groh
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Performance tests are flaky due to transient errors that happened during data processing (eg. SocketTimeoutException while connecting to DB). Currently exceptions that happen on Dataflow runner but are retried successfully, fail the test regardless of the final job state (giving a false-negative result).
> Possible solution for batch scenarios:
> We could "rethrow" exceptions that happened due to transient errors *only* if the job status is other than DONE.
> Possible solution for streaming scenarios:
> (don't know yet)
> [Link to discussion on dev list |https://lists.apache.org/thread.html/e480f8181913dc81d2d4cd1430557a646537473ccf29fe6390229098@%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)