You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Lukasz Lenart (Commented) (JIRA)" <ji...@apache.org> on 2012/02/25 16:19:48 UTC
[jira] [Commented] (WW-3766) remove
struts.freemarker.mru.max.strong.size from default.properties
[ https://issues.apache.org/jira/browse/WW-3766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216476#comment-13216476 ]
Lukasz Lenart commented on WW-3766:
-----------------------------------
Did you test that with your environment ?
> remove struts.freemarker.mru.max.strong.size from default.properties
> --------------------------------------------------------------------
>
> Key: WW-3766
> URL: https://issues.apache.org/jira/browse/WW-3766
> Project: Struts 2
> Issue Type: Improvement
> Reporter: zhouyanming
> Priority: Critical
> Labels: freemarker
>
> if struts.freemarker.mru.max.strong.size > 0 ,freemarker will use MruCacheStorage instead of SoftCacheStorage,and MruCacheStorage is not concurrent,it will synchronized on every call,it will affect performance.
> in TemplateCache:
> CachedTemplate cachedTemplate;
> if(isStorageConcurrent) {
> cachedTemplate = (CachedTemplate)storage.get(tk);
> }
> else {
> synchronized(storage) {
> cachedTemplate = (CachedTemplate)storage.get(tk);
> }
> }
> please remove struts.freemarker.mru.max.strong.size from default.properties lets developers make their own choice.
> a better solution is implements a concurrent MruCacheStorage for struts2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira