You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "rangadi (via GitHub)" <gi...@apache.org> on 2023/07/14 23:59:58 UTC

[GitHub] [spark] rangadi commented on a diff in pull request #42013: [SPARK-44439][CONNECT][SS]Fixed listListeners to only send ids back to client

rangadi commented on code in PR #42013:
URL: https://github.com/apache/spark/pull/42013#discussion_r1264250645


##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -399,7 +399,7 @@ message StreamingQueryManagerCommandResult {
   }
 
   message ListStreamingQueryListenerResult {
-    repeated StreamingQueryListenerInstance listeners = 1;
+    repeated string listeners = 1;

Review Comment:
   Better to change the name to `listener_ids`. Document the field. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org