You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/02/15 19:18:01 UTC

[GitHub] [activemq-website] mattrpav opened a new pull request #77: [AMQ-8345] Update JMS2 progress page

mattrpav opened a new pull request #77:
URL: https://github.com/apache/activemq-website/pull/77


    - Remove RC notation, as there is no planned "RC"-style release
    - Update tracking based on planned version alignment to JIRA tasks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-website] mattrpav commented on a change in pull request #77: [AMQ-8345] Update JMS2 progress page

Posted by GitBox <gi...@apache.org>.
mattrpav commented on a change in pull request #77:
URL: https://github.com/apache/activemq-website/pull/77#discussion_r808074070



##########
File path: src/jms2.md
##########
@@ -25,11 +25,13 @@ User feedback is welcome! Please comment on the JIRAs with questions and comment
 
 JIRA|Target Version|Completed Version|Feature|Notes
 ---|---|---
-[AMQ-7309](https://issues.apache.org/jira/browse/AMQ-7309) | 5.17.0.RC1 | | JMS v2.0 API dependency | ActiveMQ will ship with a JMS v2.0 dependency jar
-[AMQ-8320](https://issues.apache.org/jira/browse/AMQ-8320) | 5.17.0.RC1 | | Delivery Delay | Support for Message DeliveryDelay feature
-[AMQ-8321](https://issues.apache.org/jira/browse/AMQ-8321) | 5.17.0.RC1 | | GetBody/isBodyAssignable | Support for checking body type using a Class<?>
-[AMQ-8322](https://issues.apache.org/jira/browse/AMQ-8322) | TBD | | Connection.createContext | Simplified JMS Context object support
-[AMQ-8323](https://issues.apache.org/jira/browse/AMQ-8323) | TBD | | Session Topic Consumer | Consume messages using a MessageConsumer object (same as Queue)
-[AMQ-8324](https://issues.apache.org/jira/browse/AMQ-8324) | 5.17.0.RC1 | | MessageProducer send methods | Completion Listener and Delivery Delay support
+[AMQ-7309](https://issues.apache.org/jira/browse/AMQ-7309) | 5.17.0 | | JMS v2.0 API dependency | ActiveMQ will ship with a JMS v2.0 dependency jar
+[AMQ-8322](https://issues.apache.org/jira/browse/AMQ-8322) | 5.17.0 | | Connection.createContext | Simplified JMS Context object support
+[AMQ-8322](https://issues.apache.org/jira/browse/AMQ-8322) | 5.17.0 | | Session Topic Consumer | Consume messages using a MessageConsumer object (same as Queue)
+[AMQ-8322](https://issues.apache.org/jira/browse/AMQ-8322) | 5.17.0 | | MessageProducer send methods | 
+[AMQ-8320](https://issues.apache.org/jira/browse/AMQ-8320) | 5.17.1 | | Delivery Delay | Support for Message DeliveryDelay feature
+[AMQ-8321](https://issues.apache.org/jira/browse/AMQ-8321) | 5.17.1 | | GetBody/isBodyAssignable | Support for checking body type using a Class<?>
+[AMQ-8324](https://issues.apache.org/jira/browse/AMQ-8324) | TBD | | MessageProducer send methods | Completion Listener and Delivery Delay support

Review comment:
       I re-worked the table to clarify the intent




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-website] mattrpav merged pull request #77: [AMQ-8345] Update JMS2 progress page

Posted by GitBox <gi...@apache.org>.
mattrpav merged pull request #77:
URL: https://github.com/apache/activemq-website/pull/77


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-website] gemmellr commented on pull request #77: [AMQ-8345] Update JMS2 progress page

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #77:
URL: https://github.com/apache/activemq-website/pull/77#issuecomment-1041284675


   I'd like to suggest this again:
   > JB previously suggested he wanted to move the component specific docs etc into the component area, as part of a general tidyup and simplification of the docs. While the overall effort doesnt seem to have progressed as yet, as a rather component-specific page and probably the first distinct new page I can think of being created in a while, I think it would probably make sense to start the trend with this?
   
   https://github.com/apache/activemq-website/pull/54#issuecomment-911633870
   
   Personally I think retaining the RC notion would also make sense given the suggested state of the implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-website] gemmellr commented on a change in pull request #77: [AMQ-8345] Update JMS2 progress page

Posted by GitBox <gi...@apache.org>.
gemmellr commented on a change in pull request #77:
URL: https://github.com/apache/activemq-website/pull/77#discussion_r807726790



##########
File path: src/jms2.md
##########
@@ -25,11 +25,13 @@ User feedback is welcome! Please comment on the JIRAs with questions and comment
 
 JIRA|Target Version|Completed Version|Feature|Notes
 ---|---|---
-[AMQ-7309](https://issues.apache.org/jira/browse/AMQ-7309) | 5.17.0.RC1 | | JMS v2.0 API dependency | ActiveMQ will ship with a JMS v2.0 dependency jar
-[AMQ-8320](https://issues.apache.org/jira/browse/AMQ-8320) | 5.17.0.RC1 | | Delivery Delay | Support for Message DeliveryDelay feature
-[AMQ-8321](https://issues.apache.org/jira/browse/AMQ-8321) | 5.17.0.RC1 | | GetBody/isBodyAssignable | Support for checking body type using a Class<?>
-[AMQ-8322](https://issues.apache.org/jira/browse/AMQ-8322) | TBD | | Connection.createContext | Simplified JMS Context object support
-[AMQ-8323](https://issues.apache.org/jira/browse/AMQ-8323) | TBD | | Session Topic Consumer | Consume messages using a MessageConsumer object (same as Queue)
-[AMQ-8324](https://issues.apache.org/jira/browse/AMQ-8324) | 5.17.0.RC1 | | MessageProducer send methods | Completion Listener and Delivery Delay support
+[AMQ-7309](https://issues.apache.org/jira/browse/AMQ-7309) | 5.17.0 | | JMS v2.0 API dependency | ActiveMQ will ship with a JMS v2.0 dependency jar
+[AMQ-8322](https://issues.apache.org/jira/browse/AMQ-8322) | 5.17.0 | | Connection.createContext | Simplified JMS Context object support
+[AMQ-8322](https://issues.apache.org/jira/browse/AMQ-8322) | 5.17.0 | | Session Topic Consumer | Consume messages using a MessageConsumer object (same as Queue)
+[AMQ-8322](https://issues.apache.org/jira/browse/AMQ-8322) | 5.17.0 | | MessageProducer send methods | 
+[AMQ-8320](https://issues.apache.org/jira/browse/AMQ-8320) | 5.17.1 | | Delivery Delay | Support for Message DeliveryDelay feature
+[AMQ-8321](https://issues.apache.org/jira/browse/AMQ-8321) | 5.17.1 | | GetBody/isBodyAssignable | Support for checking body type using a Class<?>
+[AMQ-8324](https://issues.apache.org/jira/browse/AMQ-8324) | TBD | | MessageProducer send methods | Completion Listener and Delivery Delay support

Review comment:
       First "MessageProducer send methods" line has a terminator when no other does.
   
   Seems odd to have 2 lines and JIRAs referenced for "MessageProducer send methods" as a feature, when the first is unqualified with notes. If its incomplete it should probably be noted in the first instance. Especially as the second has no timeline given (though the JIRA is assigned to 5.17.0) and its notes mention the main send feature additions in JMS 2. Plus one of those features, Delivery Delay, has its own separate line and JIRA listed before saying it is being implemented separately in 5.17.1.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-website] mattrpav commented on pull request #77: [AMQ-8345] Update JMS2 progress page

Posted by GitBox <gi...@apache.org>.
mattrpav commented on pull request #77:
URL: https://github.com/apache/activemq-website/pull/77#issuecomment-1041586141


   ![image](https://user-images.githubusercontent.com/512119/154292728-ca95d272-d083-45d6-95ca-563ac79623ca.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-website] gemmellr commented on a change in pull request #77: [AMQ-8345] Update JMS2 progress page

Posted by GitBox <gi...@apache.org>.
gemmellr commented on a change in pull request #77:
URL: https://github.com/apache/activemq-website/pull/77#discussion_r807726790



##########
File path: src/jms2.md
##########
@@ -25,11 +25,13 @@ User feedback is welcome! Please comment on the JIRAs with questions and comment
 
 JIRA|Target Version|Completed Version|Feature|Notes
 ---|---|---
-[AMQ-7309](https://issues.apache.org/jira/browse/AMQ-7309) | 5.17.0.RC1 | | JMS v2.0 API dependency | ActiveMQ will ship with a JMS v2.0 dependency jar
-[AMQ-8320](https://issues.apache.org/jira/browse/AMQ-8320) | 5.17.0.RC1 | | Delivery Delay | Support for Message DeliveryDelay feature
-[AMQ-8321](https://issues.apache.org/jira/browse/AMQ-8321) | 5.17.0.RC1 | | GetBody/isBodyAssignable | Support for checking body type using a Class<?>
-[AMQ-8322](https://issues.apache.org/jira/browse/AMQ-8322) | TBD | | Connection.createContext | Simplified JMS Context object support
-[AMQ-8323](https://issues.apache.org/jira/browse/AMQ-8323) | TBD | | Session Topic Consumer | Consume messages using a MessageConsumer object (same as Queue)
-[AMQ-8324](https://issues.apache.org/jira/browse/AMQ-8324) | 5.17.0.RC1 | | MessageProducer send methods | Completion Listener and Delivery Delay support
+[AMQ-7309](https://issues.apache.org/jira/browse/AMQ-7309) | 5.17.0 | | JMS v2.0 API dependency | ActiveMQ will ship with a JMS v2.0 dependency jar
+[AMQ-8322](https://issues.apache.org/jira/browse/AMQ-8322) | 5.17.0 | | Connection.createContext | Simplified JMS Context object support
+[AMQ-8322](https://issues.apache.org/jira/browse/AMQ-8322) | 5.17.0 | | Session Topic Consumer | Consume messages using a MessageConsumer object (same as Queue)
+[AMQ-8322](https://issues.apache.org/jira/browse/AMQ-8322) | 5.17.0 | | MessageProducer send methods | 
+[AMQ-8320](https://issues.apache.org/jira/browse/AMQ-8320) | 5.17.1 | | Delivery Delay | Support for Message DeliveryDelay feature
+[AMQ-8321](https://issues.apache.org/jira/browse/AMQ-8321) | 5.17.1 | | GetBody/isBodyAssignable | Support for checking body type using a Class<?>
+[AMQ-8324](https://issues.apache.org/jira/browse/AMQ-8324) | TBD | | MessageProducer send methods | Completion Listener and Delivery Delay support

Review comment:
       First "MessageProducer send methods" line has a terminator when no other does.
   
   Seems odd to have 2 lines and JIRAs referenced for "MessageProducer send methods" as a feature, when the first is unqualified with notes. If its incomplete it should probably be noted in the first instance. Especially as the second has no timeline given and its notes mention the main send feature additions in JMS 2.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org