[GitHub] [incubator-heron] xiaoyao1991 commented on a change in pull request #3292: Bug: Read override config file in heron executor

[GitBox <gi...@apache.org>]

xiaoyao1991 commented on a change in pull request #3292: Bug: Read override config file in heron executor
URL: https://github.com/apache/incubator-heron/pull/3292#discussion_r294965342
 
 

 ##########
 File path: heron/executor/src/python/heron_executor.py
 ##########
 @@ -1109,10 +1109,15 @@ def start_state_manager_watches(self):
     Receive updates to the packing plan from the statemgrs and update processes as needed.
     """
     Log.info("Start state manager watches")
+
+    with open(self.override_config_file, 'r') as stream:
+      overrides = yaml.load(stream)
+    overrides["heron.statemgr.connection.string"] = self.state_manager_connection
 
 Review comment:
   Can `yaml.load` fail in any case? If so, should we check null and initialize `overrides` if necessary? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services