You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jo...@apache.org on 2024/03/25 21:43:04 UTC

(superset) branch john-bodley---fix-saved-queries created (now b43745e14e)

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a change to branch john-bodley---fix-saved-queries
in repository https://gitbox.apache.org/repos/asf/superset.git


      at b43745e14e fix: Provide more inclusive error handling for saved queries

This branch includes the following new commits:

     new b43745e14e fix: Provide more inclusive error handling for saved queries

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(superset) 01/01: fix: Provide more inclusive error handling for saved queries

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch john-bodley---fix-saved-queries
in repository https://gitbox.apache.org/repos/asf/superset.git

commit b43745e14e5a076987a0c658d818bd9791c46283
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Tue Mar 26 10:42:59 2024 +1300

    fix: Provide more inclusive error handling for saved queries
---
 superset/models/sql_lab.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/superset/models/sql_lab.py b/superset/models/sql_lab.py
index 2d7384a74e..9f2569fbee 100644
--- a/superset/models/sql_lab.py
+++ b/superset/models/sql_lab.py
@@ -46,7 +46,6 @@ from sqlalchemy.orm import backref, relationship
 from sqlalchemy.sql.elements import ColumnElement, literal_column
 
 from superset import security_manager
-from superset.exceptions import SupersetSecurityException
 from superset.jinja_context import BaseTemplateProcessor, get_template_processor
 from superset.models.helpers import (
     AuditMixinNullable,
@@ -76,7 +75,7 @@ class SqlTablesMixin:  # pylint: disable=too-few-public-methods
                     self.database.db_engine_spec.engine,  # type: ignore
                 )
             )
-        except SupersetSecurityException:
+        except Exception:  # pylint: disable=broad-except
             return []