You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/02/20 14:05:54 UTC
Review Request 31223: LENS-338: provide addPartitions API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-338
https://issues.apache.org/jira/browse/LENS-338
Repository: lens
Description
-------
server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
CubeMetastoreService api has both: addPartition and addPartitions.
cli tests accordingly modified to provide XPartitionList.
Diffs
-----
lens-cli/src/test/resources/dim1-local-part.xml a57f6a7d87a5ba8564f00e2d287321cd947ec827
lens-cli/src/test/resources/fact1-local-part.xml 46e76c35f62c557a8755f034a75748b54df17f93
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
Diff: https://reviews.apache.org/r/31223/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [3.353s]
[INFO] Lens .............................................. SUCCESS [2.860s]
[INFO] Lens API .......................................... SUCCESS [7.425s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.554s]
[INFO] Lens Cube ......................................... SUCCESS [6:53.200s]
[INFO] Lens DB storage ................................... SUCCESS [9.492s]
[INFO] Lens Query Library ................................ SUCCESS [4.657s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:34.349s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [24.117s]
[INFO] Lens Server ....................................... SUCCESS [4:10.309s]
[INFO] Lens client ....................................... SUCCESS [21.995s]
[INFO] Lens CLI .......................................... SUCCESS [1:43.574s]
[INFO] Lens Examples ..................................... SUCCESS [0.830s]
[INFO] Lens Distribution ................................. SUCCESS [9.375s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.309s]
[INFO] Lens Regression ................................... SUCCESS [0.472s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:38.063s
[INFO] Finished at: Fri Feb 20 13:05:28 UTC 2015
[INFO] Final Memory: 106M/1202M
[INFO] ------------------------------------------------------------------------
[SLOCCount] Report successfully processed and all data stored
Thanks,
Rajat Khandelwal
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/#review73268
-----------------------------------------------------------
Please have api for both addPartion and addPartitions in server api as well.
- Amareshwari Sriramadasu
On Feb. 20, 2015, 1:05 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31223/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2015, 1:05 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-338
> https://issues.apache.org/jira/browse/LENS-338
>
>
> Repository: lens
>
>
> Description
> -------
>
> server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
>
> CubeMetastoreService api has both: addPartition and addPartitions.
>
> cli tests accordingly modified to provide XPartitionList.
>
>
> Diffs
> -----
>
> lens-cli/src/test/resources/dim1-local-part.xml a57f6a7d87a5ba8564f00e2d287321cd947ec827
> lens-cli/src/test/resources/fact1-local-part.xml 46e76c35f62c557a8755f034a75748b54df17f93
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
>
> Diff: https://reviews.apache.org/r/31223/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.353s]
> [INFO] Lens .............................................. SUCCESS [2.860s]
> [INFO] Lens API .......................................... SUCCESS [7.425s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.554s]
> [INFO] Lens Cube ......................................... SUCCESS [6:53.200s]
> [INFO] Lens DB storage ................................... SUCCESS [9.492s]
> [INFO] Lens Query Library ................................ SUCCESS [4.657s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:34.349s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [24.117s]
> [INFO] Lens Server ....................................... SUCCESS [4:10.309s]
> [INFO] Lens client ....................................... SUCCESS [21.995s]
> [INFO] Lens CLI .......................................... SUCCESS [1:43.574s]
> [INFO] Lens Examples ..................................... SUCCESS [0.830s]
> [INFO] Lens Distribution ................................. SUCCESS [9.375s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.309s]
> [INFO] Lens Regression ................................... SUCCESS [0.472s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:38.063s
> [INFO] Finished at: Fri Feb 20 13:05:28 UTC 2015
> [INFO] Final Memory: 106M/1202M
> [INFO] ------------------------------------------------------------------------
> [SLOCCount] Report successfully processed and all data stored
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Feb. 24, 2015, 6:45 p.m., Jaideep dhok wrote:
> >
Dropping cli issues as they are not related to this jira. Had done some effort toward this in https://reviews.apache.org/r/30870/. Will be picking that up later as improvement.
> On Feb. 24, 2015, 6:45 p.m., Jaideep dhok wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java, line 1075
> > <https://reviews.apache.org/r/31223/diff/4/?file=873944#file873944line1075>
> >
> > What would be the error returned to client if this is null? It should be 402 - bad arguments and not 5xx (internal server error etc). Can we verify this
Just by adding annotation, it's giving 500. I modified some code so that it gives 400 now.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/#review73804
-----------------------------------------------------------
On Feb. 24, 2015, 8:21 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31223/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 8:21 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-338
> https://issues.apache.org/jira/browse/LENS-338
>
>
> Repository: lens
>
>
> Description
> -------
>
> server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
>
> There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
>
> Current implementation:
> ```
> MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
> MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
> MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
> MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
> ```
>
> Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 6336b9e8320cb0826a5c568a36b0bf5379f61608
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java f54d8be586546d10e55705e25416e7561269be39
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 01afbf31521d0f8e80ef7e1e5aa82f5b39afc23e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 0d345940d34e02129117c0e6de7c7a7d5cdb4c51
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java c7ed03df5ccad74108a09afb6c86618b4fe0a913
> lens-cli/src/test/resources/dim1-local-parts.xml PRE-CREATION
> lens-cli/src/test/resources/fact1-local-parts.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 0c5db747b41a906fd0c786ae87f85ec4b0927e02
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
>
> Diff: https://reviews.apache.org/r/31223/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
> [INFO] Lens .............................................. SUCCESS [1.692s]
> [INFO] Lens API .......................................... SUCCESS [5.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.661s]
> [INFO] Lens Cube ......................................... SUCCESS [6:27.888s]
> [INFO] Lens DB storage ................................... SUCCESS [10.261s]
> [INFO] Lens Query Library ................................ SUCCESS [4.635s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:35.006s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.114s]
> [INFO] Lens Server ....................................... SUCCESS [4:22.449s]
> [INFO] Lens client ....................................... SUCCESS [20.585s]
> [INFO] Lens CLI .......................................... SUCCESS [1:54.279s]
> [INFO] Lens Examples ..................................... SUCCESS [0.836s]
> [INFO] Lens Distribution ................................. SUCCESS [9.556s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.674s]
> [INFO] Lens Regression ................................... SUCCESS [0.478s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:33.601s
> [INFO] Finished at: Tue Feb 24 13:04:13 UTC 2015
> [INFO] Final Memory: 99M/973M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/#review73804
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
<https://reviews.apache.org/r/31223/#comment120215>
We should inform the user which file does not exist.
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
<https://reviews.apache.org/r/31223/#comment120216>
failure -> Failure
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java
<https://reviews.apache.org/r/31223/#comment120217>
Same as above- add file name in return message
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
<https://reviews.apache.org/r/31223/#comment120218>
Can you comment what improvement is needed?
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
<https://reviews.apache.org/r/31223/#comment120219>
can you log partition spec as well
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java
<https://reviews.apache.org/r/31223/#comment120220>
Why are we creating inner subclass of arraylist? Just add them and then return in two separate lines.
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
<https://reviews.apache.org/r/31223/#comment120221>
What would be the error returned to client if this is null? It should be 402 - bad arguments and not 5xx (internal server error etc). Can we verify this
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
<https://reviews.apache.org/r/31223/#comment120222>
No need to create annonymous sub class.
- Jaideep dhok
On Feb. 24, 2015, 12:49 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31223/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 12:49 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-338
> https://issues.apache.org/jira/browse/LENS-338
>
>
> Repository: lens
>
>
> Description
> -------
>
> server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
>
> There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
>
> Current implementation:
> ```
> MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
> MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
> MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
> MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
> ```
>
> Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 6336b9e8320cb0826a5c568a36b0bf5379f61608
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java f54d8be586546d10e55705e25416e7561269be39
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 01afbf31521d0f8e80ef7e1e5aa82f5b39afc23e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 0d345940d34e02129117c0e6de7c7a7d5cdb4c51
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java c7ed03df5ccad74108a09afb6c86618b4fe0a913
> lens-cli/src/test/resources/dim1-local-parts.xml PRE-CREATION
> lens-cli/src/test/resources/fact1-local-parts.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 0c5db747b41a906fd0c786ae87f85ec4b0927e02
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
>
> Diff: https://reviews.apache.org/r/31223/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.158s]
> [INFO] Lens .............................................. SUCCESS [1.868s]
> [INFO] Lens API .......................................... SUCCESS [5.609s]
> [INFO] Lens API for server and extensions ................ SUCCESS [5.213s]
> [INFO] Lens Cube ......................................... SUCCESS [6:17.935s]
> [INFO] Lens DB storage ................................... SUCCESS [9.538s]
> [INFO] Lens Query Library ................................ SUCCESS [4.595s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:38.363s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [24.264s]
> [INFO] Lens Server ....................................... SUCCESS [4:09.211s]
> [INFO] Lens client ....................................... SUCCESS [20.951s]
> [INFO] Lens CLI .......................................... SUCCESS [1:37.758s]
> [INFO] Lens Examples ..................................... SUCCESS [0.832s]
> [INFO] Lens Distribution ................................. SUCCESS [9.990s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.381s]
> [INFO] Lens Regression ................................... SUCCESS [0.487s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/#review74024
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Feb. 25, 2015, 1:05 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31223/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 1:05 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-338
> https://issues.apache.org/jira/browse/LENS-338
>
>
> Repository: lens
>
>
> Description
> -------
>
> server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
>
> There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
>
> Current implementation:
> ```
> MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
> MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
> MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
> MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
> ```
>
> Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 6336b9e8320cb0826a5c568a36b0bf5379f61608
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java f54d8be586546d10e55705e25416e7561269be39
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 01afbf31521d0f8e80ef7e1e5aa82f5b39afc23e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 0d345940d34e02129117c0e6de7c7a7d5cdb4c51
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java c7ed03df5ccad74108a09afb6c86618b4fe0a913
> lens-cli/src/test/resources/dim1-local-parts.xml PRE-CREATION
> lens-cli/src/test/resources/fact1-local-parts.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 0c5db747b41a906fd0c786ae87f85ec4b0927e02
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
>
> Diff: https://reviews.apache.org/r/31223/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
> [INFO] Lens .............................................. SUCCESS [1.692s]
> [INFO] Lens API .......................................... SUCCESS [5.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.661s]
> [INFO] Lens Cube ......................................... SUCCESS [6:27.888s]
> [INFO] Lens DB storage ................................... SUCCESS [10.261s]
> [INFO] Lens Query Library ................................ SUCCESS [4.635s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:35.006s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.114s]
> [INFO] Lens Server ....................................... SUCCESS [4:22.449s]
> [INFO] Lens client ....................................... SUCCESS [20.585s]
> [INFO] Lens CLI .......................................... SUCCESS [1:54.279s]
> [INFO] Lens Examples ..................................... SUCCESS [0.836s]
> [INFO] Lens Distribution ................................. SUCCESS [9.556s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.674s]
> [INFO] Lens Regression ................................... SUCCESS [0.478s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:33.601s
> [INFO] Finished at: Tue Feb 24 13:04:13 UTC 2015
> [INFO] Final Memory: 99M/973M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/
-----------------------------------------------------------
(Updated Feb. 25, 2015, 6:35 p.m.)
Review request for lens.
Bugs: LENS-338
https://issues.apache.org/jira/browse/LENS-338
Repository: lens
Description
-------
server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
Current implementation:
```
MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
```
Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 6336b9e8320cb0826a5c568a36b0bf5379f61608
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java f54d8be586546d10e55705e25416e7561269be39
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 01afbf31521d0f8e80ef7e1e5aa82f5b39afc23e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 0d345940d34e02129117c0e6de7c7a7d5cdb4c51
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java c7ed03df5ccad74108a09afb6c86618b4fe0a913
lens-cli/src/test/resources/dim1-local-parts.xml PRE-CREATION
lens-cli/src/test/resources/fact1-local-parts.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 0c5db747b41a906fd0c786ae87f85ec4b0927e02
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
Diff: https://reviews.apache.org/r/31223/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
[INFO] Lens .............................................. SUCCESS [1.692s]
[INFO] Lens API .......................................... SUCCESS [5.419s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.661s]
[INFO] Lens Cube ......................................... SUCCESS [6:27.888s]
[INFO] Lens DB storage ................................... SUCCESS [10.261s]
[INFO] Lens Query Library ................................ SUCCESS [4.635s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:35.006s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.114s]
[INFO] Lens Server ....................................... SUCCESS [4:22.449s]
[INFO] Lens client ....................................... SUCCESS [20.585s]
[INFO] Lens CLI .......................................... SUCCESS [1:54.279s]
[INFO] Lens Examples ..................................... SUCCESS [0.836s]
[INFO] Lens Distribution ................................. SUCCESS [9.556s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.674s]
[INFO] Lens Regression ................................... SUCCESS [0.478s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:33.601s
[INFO] Finished at: Tue Feb 24 13:04:13 UTC 2015
[INFO] Final Memory: 99M/973M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/
-----------------------------------------------------------
(Updated Feb. 25, 2015, 6:32 p.m.)
Review request for lens.
Bugs: LENS-338
https://issues.apache.org/jira/browse/LENS-338
Repository: lens
Description
-------
server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
Current implementation:
```
MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
```
Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 6336b9e8320cb0826a5c568a36b0bf5379f61608
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java f54d8be586546d10e55705e25416e7561269be39
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 01afbf31521d0f8e80ef7e1e5aa82f5b39afc23e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 0d345940d34e02129117c0e6de7c7a7d5cdb4c51
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java c7ed03df5ccad74108a09afb6c86618b4fe0a913
lens-cli/src/test/resources/dim1-local-parts.xml PRE-CREATION
lens-cli/src/test/resources/fact1-local-parts.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 0c5db747b41a906fd0c786ae87f85ec4b0927e02
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
Diff: https://reviews.apache.org/r/31223/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
[INFO] Lens .............................................. SUCCESS [1.692s]
[INFO] Lens API .......................................... SUCCESS [5.419s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.661s]
[INFO] Lens Cube ......................................... SUCCESS [6:27.888s]
[INFO] Lens DB storage ................................... SUCCESS [10.261s]
[INFO] Lens Query Library ................................ SUCCESS [4.635s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:35.006s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.114s]
[INFO] Lens Server ....................................... SUCCESS [4:22.449s]
[INFO] Lens client ....................................... SUCCESS [20.585s]
[INFO] Lens CLI .......................................... SUCCESS [1:54.279s]
[INFO] Lens Examples ..................................... SUCCESS [0.836s]
[INFO] Lens Distribution ................................. SUCCESS [9.556s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.674s]
[INFO] Lens Regression ................................... SUCCESS [0.478s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:33.601s
[INFO] Finished at: Tue Feb 24 13:04:13 UTC 2015
[INFO] Final Memory: 99M/973M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/
-----------------------------------------------------------
(Updated Feb. 25, 2015, 6:23 p.m.)
Review request for lens.
Bugs: LENS-338
https://issues.apache.org/jira/browse/LENS-338
Repository: lens
Description
-------
server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
Current implementation:
```
MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
```
Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 6336b9e8320cb0826a5c568a36b0bf5379f61608
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java f54d8be586546d10e55705e25416e7561269be39
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 01afbf31521d0f8e80ef7e1e5aa82f5b39afc23e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 0d345940d34e02129117c0e6de7c7a7d5cdb4c51
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java c7ed03df5ccad74108a09afb6c86618b4fe0a913
lens-cli/src/test/resources/dim1-local-parts.xml PRE-CREATION
lens-cli/src/test/resources/fact1-local-parts.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 0c5db747b41a906fd0c786ae87f85ec4b0927e02
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
Diff: https://reviews.apache.org/r/31223/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
[INFO] Lens .............................................. SUCCESS [1.692s]
[INFO] Lens API .......................................... SUCCESS [5.419s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.661s]
[INFO] Lens Cube ......................................... SUCCESS [6:27.888s]
[INFO] Lens DB storage ................................... SUCCESS [10.261s]
[INFO] Lens Query Library ................................ SUCCESS [4.635s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:35.006s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.114s]
[INFO] Lens Server ....................................... SUCCESS [4:22.449s]
[INFO] Lens client ....................................... SUCCESS [20.585s]
[INFO] Lens CLI .......................................... SUCCESS [1:54.279s]
[INFO] Lens Examples ..................................... SUCCESS [0.836s]
[INFO] Lens Distribution ................................. SUCCESS [9.556s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.674s]
[INFO] Lens Regression ................................... SUCCESS [0.478s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:33.601s
[INFO] Finished at: Tue Feb 24 13:04:13 UTC 2015
[INFO] Final Memory: 99M/973M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/
-----------------------------------------------------------
(Updated Feb. 25, 2015, 6:20 p.m.)
Review request for lens.
Bugs: LENS-338
https://issues.apache.org/jira/browse/LENS-338
Repository: lens
Description
-------
server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
Current implementation:
```
MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
```
Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 6336b9e8320cb0826a5c568a36b0bf5379f61608
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java f54d8be586546d10e55705e25416e7561269be39
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 01afbf31521d0f8e80ef7e1e5aa82f5b39afc23e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 0d345940d34e02129117c0e6de7c7a7d5cdb4c51
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java c7ed03df5ccad74108a09afb6c86618b4fe0a913
lens-cli/src/test/resources/dim1-local-parts.xml PRE-CREATION
lens-cli/src/test/resources/fact1-local-parts.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 0c5db747b41a906fd0c786ae87f85ec4b0927e02
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
Diff: https://reviews.apache.org/r/31223/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
[INFO] Lens .............................................. SUCCESS [1.692s]
[INFO] Lens API .......................................... SUCCESS [5.419s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.661s]
[INFO] Lens Cube ......................................... SUCCESS [6:27.888s]
[INFO] Lens DB storage ................................... SUCCESS [10.261s]
[INFO] Lens Query Library ................................ SUCCESS [4.635s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:35.006s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.114s]
[INFO] Lens Server ....................................... SUCCESS [4:22.449s]
[INFO] Lens client ....................................... SUCCESS [20.585s]
[INFO] Lens CLI .......................................... SUCCESS [1:54.279s]
[INFO] Lens Examples ..................................... SUCCESS [0.836s]
[INFO] Lens Distribution ................................. SUCCESS [9.556s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.674s]
[INFO] Lens Regression ................................... SUCCESS [0.478s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:33.601s
[INFO] Finished at: Tue Feb 24 13:04:13 UTC 2015
[INFO] Final Memory: 99M/973M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Feb. 25, 2015, 4:40 p.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java, line 837
> > <https://reviews.apache.org/r/31223/diff/7/?file=874086#file874086line837>
> >
> > addPartitions?
Nope. this one is just addPartition
> On Feb. 25, 2015, 4:40 p.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java, line 841
> > <https://reviews.apache.org/r/31223/diff/7/?file=874086#file874086line841>
> >
> > partitions in the path?
This is also add Partition
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/#review74014
-----------------------------------------------------------
On Feb. 25, 2015, 3:46 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31223/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 3:46 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-338
> https://issues.apache.org/jira/browse/LENS-338
>
>
> Repository: lens
>
>
> Description
> -------
>
> server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
>
> There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
>
> Current implementation:
> ```
> MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
> MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
> MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
> MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
> ```
>
> Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/checkstyle.xml 40191125012f2fc8f7fc71afb9ee884b9c1c1a09
> lens-server-api/pom.xml 292ce1f14026e1b86b9c5b742e2b36ad57cd03a8
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fdfce93f0d5ff8d151ccac4238f75c07b95d115c
> lens-server-api/src/main/java/org/apache/lens/server/api/annotations/MultiPurposeResource.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/DisabledMethodMetricsContext.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsContext.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 7d3b9473e44ccd91a60c4b4f14b17bb6cd2267a4
> lens-server/pom.xml 98ceed39b5084f1e8f46517ad41e29cc347f2a3f
> lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java b75bcf4b3af029d3e5b25465fa61d7bad771a89c
> lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java 4f434ce0230196e0dbf96d47f527a192769824a6
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 4ce3e0478785cbbed26bac2e17f93cc19bc057c6
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 0f9ac1a3a01d2172c9100349fb74fcf472e6a16e
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 2c870f12e48cfb7406756c3741f69b6625ff114b
> lens-server/src/main/java/org/apache/lens/server/MetricsServiceImpl.java 2094dfa26c77e2667a0a6d4f4d85db5ce5a2e357
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
> lens-server/src/main/java/org/apache/lens/server/metrics/MethodMetrics.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MethodMetricsFactory.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/model/LensContainerRequest.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/model/LensResourceMethod.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2447bbbd3bf8635bd24fee1253e73a3ab12aa496
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9a94b5cbf4962051be668abd890dc9f55bdf8e5a
> lens-server/src/main/resources/lensserver-default.xml 331448f432141342f4b370ca2f64f1d4a0669372
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java ca1c6c564a9bac54d7410f3daff36ce04b6e5ee7
> lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 1e31fada85ecd0fb8e5f06884ca2595b3c92bb04
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 554cf70d2139319e9a78520730efee9a345bedec
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
> lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9c48a40600543f2863b5e0b9bfda6c0db8f27e53
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java efa84ec76a38fb3486758458eef444bca6456f81
> pom.xml 281180d30a0685b6c7ccb4e772246ae4bf72c01e
> src/site/apt/admin/config.apt 5aaf8e9e6accf2f863b6f9be685c440a99d98b79
>
> Diff: https://reviews.apache.org/r/31223/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
> [INFO] Lens .............................................. SUCCESS [1.692s]
> [INFO] Lens API .......................................... SUCCESS [5.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.661s]
> [INFO] Lens Cube ......................................... SUCCESS [6:27.888s]
> [INFO] Lens DB storage ................................... SUCCESS [10.261s]
> [INFO] Lens Query Library ................................ SUCCESS [4.635s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:35.006s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.114s]
> [INFO] Lens Server ....................................... SUCCESS [4:22.449s]
> [INFO] Lens client ....................................... SUCCESS [20.585s]
> [INFO] Lens CLI .......................................... SUCCESS [1:54.279s]
> [INFO] Lens Examples ..................................... SUCCESS [0.836s]
> [INFO] Lens Distribution ................................. SUCCESS [9.556s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.674s]
> [INFO] Lens Regression ................................... SUCCESS [0.478s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:33.601s
> [INFO] Finished at: Tue Feb 24 13:04:13 UTC 2015
> [INFO] Final Memory: 99M/973M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/#review74014
-----------------------------------------------------------
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java
<https://reviews.apache.org/r/31223/#comment120455>
addPartitions?
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java
<https://reviews.apache.org/r/31223/#comment120456>
partitions in the path?
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java
<https://reviews.apache.org/r/31223/#comment120457>
Add partition list ?
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
<https://reviews.apache.org/r/31223/#comment120458>
we can remove this log as well. logging XPartitionList might be huge log.
Or modify the log saying adding partition list for dimtable and storage.
If you are adding add for other addPartition methods as well.
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
<https://reviews.apache.org/r/31223/#comment120459>
Change new partition to partition list?
- Amareshwari Sriramadasu
On Feb. 25, 2015, 10:16 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31223/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 10:16 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-338
> https://issues.apache.org/jira/browse/LENS-338
>
>
> Repository: lens
>
>
> Description
> -------
>
> server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
>
> There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
>
> Current implementation:
> ```
> MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
> MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
> MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
> MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
> ```
>
> Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/checkstyle.xml 40191125012f2fc8f7fc71afb9ee884b9c1c1a09
> lens-server-api/pom.xml 292ce1f14026e1b86b9c5b742e2b36ad57cd03a8
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fdfce93f0d5ff8d151ccac4238f75c07b95d115c
> lens-server-api/src/main/java/org/apache/lens/server/api/annotations/MultiPurposeResource.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/DisabledMethodMetricsContext.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsContext.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 7d3b9473e44ccd91a60c4b4f14b17bb6cd2267a4
> lens-server/pom.xml 98ceed39b5084f1e8f46517ad41e29cc347f2a3f
> lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java b75bcf4b3af029d3e5b25465fa61d7bad771a89c
> lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java 4f434ce0230196e0dbf96d47f527a192769824a6
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 4ce3e0478785cbbed26bac2e17f93cc19bc057c6
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 0f9ac1a3a01d2172c9100349fb74fcf472e6a16e
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 2c870f12e48cfb7406756c3741f69b6625ff114b
> lens-server/src/main/java/org/apache/lens/server/MetricsServiceImpl.java 2094dfa26c77e2667a0a6d4f4d85db5ce5a2e357
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
> lens-server/src/main/java/org/apache/lens/server/metrics/MethodMetrics.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MethodMetricsFactory.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/model/LensContainerRequest.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/model/LensResourceMethod.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2447bbbd3bf8635bd24fee1253e73a3ab12aa496
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9a94b5cbf4962051be668abd890dc9f55bdf8e5a
> lens-server/src/main/resources/lensserver-default.xml 331448f432141342f4b370ca2f64f1d4a0669372
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java ca1c6c564a9bac54d7410f3daff36ce04b6e5ee7
> lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 1e31fada85ecd0fb8e5f06884ca2595b3c92bb04
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 554cf70d2139319e9a78520730efee9a345bedec
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
> lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9c48a40600543f2863b5e0b9bfda6c0db8f27e53
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java efa84ec76a38fb3486758458eef444bca6456f81
> pom.xml 281180d30a0685b6c7ccb4e772246ae4bf72c01e
> src/site/apt/admin/config.apt 5aaf8e9e6accf2f863b6f9be685c440a99d98b79
>
> Diff: https://reviews.apache.org/r/31223/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
> [INFO] Lens .............................................. SUCCESS [1.692s]
> [INFO] Lens API .......................................... SUCCESS [5.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.661s]
> [INFO] Lens Cube ......................................... SUCCESS [6:27.888s]
> [INFO] Lens DB storage ................................... SUCCESS [10.261s]
> [INFO] Lens Query Library ................................ SUCCESS [4.635s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:35.006s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.114s]
> [INFO] Lens Server ....................................... SUCCESS [4:22.449s]
> [INFO] Lens client ....................................... SUCCESS [20.585s]
> [INFO] Lens CLI .......................................... SUCCESS [1:54.279s]
> [INFO] Lens Examples ..................................... SUCCESS [0.836s]
> [INFO] Lens Distribution ................................. SUCCESS [9.556s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.674s]
> [INFO] Lens Regression ................................... SUCCESS [0.478s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:33.601s
> [INFO] Finished at: Tue Feb 24 13:04:13 UTC 2015
> [INFO] Final Memory: 99M/973M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/
-----------------------------------------------------------
(Updated Feb. 25, 2015, 3:46 p.m.)
Review request for lens.
Bugs: LENS-338
https://issues.apache.org/jira/browse/LENS-338
Repository: lens
Description
-------
server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
Current implementation:
```
MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
```
Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
Diffs (updated)
-----
checkstyle/src/main/resources/checkstyle.xml 40191125012f2fc8f7fc71afb9ee884b9c1c1a09
lens-server-api/pom.xml 292ce1f14026e1b86b9c5b742e2b36ad57cd03a8
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fdfce93f0d5ff8d151ccac4238f75c07b95d115c
lens-server-api/src/main/java/org/apache/lens/server/api/annotations/MultiPurposeResource.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/DisabledMethodMetricsContext.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MethodMetricsContext.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 7d3b9473e44ccd91a60c4b4f14b17bb6cd2267a4
lens-server/pom.xml 98ceed39b5084f1e8f46517ad41e29cc347f2a3f
lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java b75bcf4b3af029d3e5b25465fa61d7bad771a89c
lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java 4f434ce0230196e0dbf96d47f527a192769824a6
lens-server/src/main/java/org/apache/lens/server/LensServer.java 4ce3e0478785cbbed26bac2e17f93cc19bc057c6
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 0f9ac1a3a01d2172c9100349fb74fcf472e6a16e
lens-server/src/main/java/org/apache/lens/server/LensServices.java 2c870f12e48cfb7406756c3741f69b6625ff114b
lens-server/src/main/java/org/apache/lens/server/MetricsServiceImpl.java 2094dfa26c77e2667a0a6d4f4d85db5ce5a2e357
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
lens-server/src/main/java/org/apache/lens/server/metrics/MethodMetrics.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metrics/MethodMetricsFactory.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/model/LensContainerRequest.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/model/LensResourceMethod.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2447bbbd3bf8635bd24fee1253e73a3ab12aa496
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 9a94b5cbf4962051be668abd890dc9f55bdf8e5a
lens-server/src/main/resources/lensserver-default.xml 331448f432141342f4b370ca2f64f1d4a0669372
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java ca1c6c564a9bac54d7410f3daff36ce04b6e5ee7
lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 1e31fada85ecd0fb8e5f06884ca2595b3c92bb04
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 554cf70d2139319e9a78520730efee9a345bedec
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9c48a40600543f2863b5e0b9bfda6c0db8f27e53
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java efa84ec76a38fb3486758458eef444bca6456f81
pom.xml 281180d30a0685b6c7ccb4e772246ae4bf72c01e
src/site/apt/admin/config.apt 5aaf8e9e6accf2f863b6f9be685c440a99d98b79
Diff: https://reviews.apache.org/r/31223/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
[INFO] Lens .............................................. SUCCESS [1.692s]
[INFO] Lens API .......................................... SUCCESS [5.419s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.661s]
[INFO] Lens Cube ......................................... SUCCESS [6:27.888s]
[INFO] Lens DB storage ................................... SUCCESS [10.261s]
[INFO] Lens Query Library ................................ SUCCESS [4.635s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:35.006s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.114s]
[INFO] Lens Server ....................................... SUCCESS [4:22.449s]
[INFO] Lens client ....................................... SUCCESS [20.585s]
[INFO] Lens CLI .......................................... SUCCESS [1:54.279s]
[INFO] Lens Examples ..................................... SUCCESS [0.836s]
[INFO] Lens Distribution ................................. SUCCESS [9.556s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.674s]
[INFO] Lens Regression ................................... SUCCESS [0.478s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:33.601s
[INFO] Finished at: Tue Feb 24 13:04:13 UTC 2015
[INFO] Final Memory: 99M/973M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/
-----------------------------------------------------------
(Updated Feb. 25, 2015, 11:41 a.m.)
Review request for lens.
Bugs: LENS-338
https://issues.apache.org/jira/browse/LENS-338
Repository: lens
Description
-------
server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
Current implementation:
```
MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
```
Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 6336b9e8320cb0826a5c568a36b0bf5379f61608
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java f54d8be586546d10e55705e25416e7561269be39
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 01afbf31521d0f8e80ef7e1e5aa82f5b39afc23e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 0d345940d34e02129117c0e6de7c7a7d5cdb4c51
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java c7ed03df5ccad74108a09afb6c86618b4fe0a913
lens-cli/src/test/resources/dim1-local-parts.xml PRE-CREATION
lens-cli/src/test/resources/fact1-local-parts.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 0c5db747b41a906fd0c786ae87f85ec4b0927e02
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
Diff: https://reviews.apache.org/r/31223/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
[INFO] Lens .............................................. SUCCESS [1.692s]
[INFO] Lens API .......................................... SUCCESS [5.419s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.661s]
[INFO] Lens Cube ......................................... SUCCESS [6:27.888s]
[INFO] Lens DB storage ................................... SUCCESS [10.261s]
[INFO] Lens Query Library ................................ SUCCESS [4.635s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:35.006s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.114s]
[INFO] Lens Server ....................................... SUCCESS [4:22.449s]
[INFO] Lens client ....................................... SUCCESS [20.585s]
[INFO] Lens CLI .......................................... SUCCESS [1:54.279s]
[INFO] Lens Examples ..................................... SUCCESS [0.836s]
[INFO] Lens Distribution ................................. SUCCESS [9.556s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.674s]
[INFO] Lens Regression ................................... SUCCESS [0.478s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:33.601s
[INFO] Finished at: Tue Feb 24 13:04:13 UTC 2015
[INFO] Final Memory: 99M/973M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/#review73827
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
<https://reviews.apache.org/r/31223/#comment120231>
Should be invalid partition right?
- Jaideep dhok
On Feb. 24, 2015, 3 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31223/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 3 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-338
> https://issues.apache.org/jira/browse/LENS-338
>
>
> Repository: lens
>
>
> Description
> -------
>
> server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
>
> There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
>
> Current implementation:
> ```
> MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
> MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
> MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
> MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
> ```
>
> Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 6336b9e8320cb0826a5c568a36b0bf5379f61608
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java f54d8be586546d10e55705e25416e7561269be39
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 01afbf31521d0f8e80ef7e1e5aa82f5b39afc23e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 0d345940d34e02129117c0e6de7c7a7d5cdb4c51
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java c7ed03df5ccad74108a09afb6c86618b4fe0a913
> lens-cli/src/test/resources/dim1-local-parts.xml PRE-CREATION
> lens-cli/src/test/resources/fact1-local-parts.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 0c5db747b41a906fd0c786ae87f85ec4b0927e02
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
>
> Diff: https://reviews.apache.org/r/31223/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
> [INFO] Lens .............................................. SUCCESS [1.692s]
> [INFO] Lens API .......................................... SUCCESS [5.419s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.661s]
> [INFO] Lens Cube ......................................... SUCCESS [6:27.888s]
> [INFO] Lens DB storage ................................... SUCCESS [10.261s]
> [INFO] Lens Query Library ................................ SUCCESS [4.635s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:35.006s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.114s]
> [INFO] Lens Server ....................................... SUCCESS [4:22.449s]
> [INFO] Lens client ....................................... SUCCESS [20.585s]
> [INFO] Lens CLI .......................................... SUCCESS [1:54.279s]
> [INFO] Lens Examples ..................................... SUCCESS [0.836s]
> [INFO] Lens Distribution ................................. SUCCESS [9.556s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.674s]
> [INFO] Lens Regression ................................... SUCCESS [0.478s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:33.601s
> [INFO] Finished at: Tue Feb 24 13:04:13 UTC 2015
> [INFO] Final Memory: 99M/973M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 8:30 p.m.)
Review request for lens.
Bugs: LENS-338
https://issues.apache.org/jira/browse/LENS-338
Repository: lens
Description
-------
server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
Current implementation:
```
MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
```
Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 6336b9e8320cb0826a5c568a36b0bf5379f61608
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java f54d8be586546d10e55705e25416e7561269be39
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 01afbf31521d0f8e80ef7e1e5aa82f5b39afc23e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 0d345940d34e02129117c0e6de7c7a7d5cdb4c51
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java c7ed03df5ccad74108a09afb6c86618b4fe0a913
lens-cli/src/test/resources/dim1-local-parts.xml PRE-CREATION
lens-cli/src/test/resources/fact1-local-parts.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 0c5db747b41a906fd0c786ae87f85ec4b0927e02
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
Diff: https://reviews.apache.org/r/31223/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
[INFO] Lens .............................................. SUCCESS [1.692s]
[INFO] Lens API .......................................... SUCCESS [5.419s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.661s]
[INFO] Lens Cube ......................................... SUCCESS [6:27.888s]
[INFO] Lens DB storage ................................... SUCCESS [10.261s]
[INFO] Lens Query Library ................................ SUCCESS [4.635s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:35.006s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.114s]
[INFO] Lens Server ....................................... SUCCESS [4:22.449s]
[INFO] Lens client ....................................... SUCCESS [20.585s]
[INFO] Lens CLI .......................................... SUCCESS [1:54.279s]
[INFO] Lens Examples ..................................... SUCCESS [0.836s]
[INFO] Lens Distribution ................................. SUCCESS [9.556s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.674s]
[INFO] Lens Regression ................................... SUCCESS [0.478s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:33.601s
[INFO] Finished at: Tue Feb 24 13:04:13 UTC 2015
[INFO] Final Memory: 99M/973M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 8:21 p.m.)
Review request for lens.
Bugs: LENS-338
https://issues.apache.org/jira/browse/LENS-338
Repository: lens
Description
-------
server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
Current implementation:
```
MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
```
Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 6336b9e8320cb0826a5c568a36b0bf5379f61608
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java f54d8be586546d10e55705e25416e7561269be39
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 01afbf31521d0f8e80ef7e1e5aa82f5b39afc23e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 0d345940d34e02129117c0e6de7c7a7d5cdb4c51
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java c7ed03df5ccad74108a09afb6c86618b4fe0a913
lens-cli/src/test/resources/dim1-local-parts.xml PRE-CREATION
lens-cli/src/test/resources/fact1-local-parts.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 0c5db747b41a906fd0c786ae87f85ec4b0927e02
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
Diff: https://reviews.apache.org/r/31223/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
[INFO] Lens .............................................. SUCCESS [1.692s]
[INFO] Lens API .......................................... SUCCESS [5.419s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.661s]
[INFO] Lens Cube ......................................... SUCCESS [6:27.888s]
[INFO] Lens DB storage ................................... SUCCESS [10.261s]
[INFO] Lens Query Library ................................ SUCCESS [4.635s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:35.006s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.114s]
[INFO] Lens Server ....................................... SUCCESS [4:22.449s]
[INFO] Lens client ....................................... SUCCESS [20.585s]
[INFO] Lens CLI .......................................... SUCCESS [1:54.279s]
[INFO] Lens Examples ..................................... SUCCESS [0.836s]
[INFO] Lens Distribution ................................. SUCCESS [9.556s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.674s]
[INFO] Lens Regression ................................... SUCCESS [0.478s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:33.601s
[INFO] Finished at: Tue Feb 24 13:04:13 UTC 2015
[INFO] Final Memory: 99M/973M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 6:47 p.m.)
Review request for lens.
Bugs: LENS-338
https://issues.apache.org/jira/browse/LENS-338
Repository: lens
Description
-------
server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
Current implementation:
```
MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
```
Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 6336b9e8320cb0826a5c568a36b0bf5379f61608
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java f54d8be586546d10e55705e25416e7561269be39
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 01afbf31521d0f8e80ef7e1e5aa82f5b39afc23e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 0d345940d34e02129117c0e6de7c7a7d5cdb4c51
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java c7ed03df5ccad74108a09afb6c86618b4fe0a913
lens-cli/src/test/resources/dim1-local-parts.xml PRE-CREATION
lens-cli/src/test/resources/fact1-local-parts.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 0c5db747b41a906fd0c786ae87f85ec4b0927e02
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
Diff: https://reviews.apache.org/r/31223/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
[INFO] Lens .............................................. SUCCESS [1.692s]
[INFO] Lens API .......................................... SUCCESS [5.419s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.661s]
[INFO] Lens Cube ......................................... SUCCESS [6:27.888s]
[INFO] Lens DB storage ................................... SUCCESS [10.261s]
[INFO] Lens Query Library ................................ SUCCESS [4.635s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:35.006s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.114s]
[INFO] Lens Server ....................................... SUCCESS [4:22.449s]
[INFO] Lens client ....................................... SUCCESS [20.585s]
[INFO] Lens CLI .......................................... SUCCESS [1:54.279s]
[INFO] Lens Examples ..................................... SUCCESS [0.836s]
[INFO] Lens Distribution ................................. SUCCESS [9.556s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.674s]
[INFO] Lens Regression ................................... SUCCESS [0.478s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:33.601s
[INFO] Finished at: Tue Feb 24 13:04:13 UTC 2015
[INFO] Final Memory: 99M/973M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 6:19 p.m.)
Review request for lens.
Bugs: LENS-338
https://issues.apache.org/jira/browse/LENS-338
Repository: lens
Description (updated)
-------
server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
Current implementation:
```
MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
```
Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 6336b9e8320cb0826a5c568a36b0bf5379f61608
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java f54d8be586546d10e55705e25416e7561269be39
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 01afbf31521d0f8e80ef7e1e5aa82f5b39afc23e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 0d345940d34e02129117c0e6de7c7a7d5cdb4c51
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java c7ed03df5ccad74108a09afb6c86618b4fe0a913
lens-cli/src/test/resources/dim1-local-parts.xml PRE-CREATION
lens-cli/src/test/resources/fact1-local-parts.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 0c5db747b41a906fd0c786ae87f85ec4b0927e02
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
Diff: https://reviews.apache.org/r/31223/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.158s]
[INFO] Lens .............................................. SUCCESS [1.868s]
[INFO] Lens API .......................................... SUCCESS [5.609s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.213s]
[INFO] Lens Cube ......................................... SUCCESS [6:17.935s]
[INFO] Lens DB storage ................................... SUCCESS [9.538s]
[INFO] Lens Query Library ................................ SUCCESS [4.595s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:38.363s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [24.264s]
[INFO] Lens Server ....................................... SUCCESS [4:09.211s]
[INFO] Lens client ....................................... SUCCESS [20.951s]
[INFO] Lens CLI .......................................... SUCCESS [1:37.758s]
[INFO] Lens Examples ..................................... SUCCESS [0.832s]
[INFO] Lens Distribution ................................. SUCCESS [9.990s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.381s]
[INFO] Lens Regression ................................... SUCCESS [0.487s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Feb. 24, 2015, 12:18 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java, line 1085
> > <https://reviews.apache.org/r/31223/diff/3/?file=872904#file872904line1085>
> >
> > Is there any test for addPartition itself? I see all the callers are removed here
No. Places where only one partition was getting added, I've not modified them. Only two places `addPartitions` is added in test class, once clubbing three `addPartition`s and once clubbing two `addPartition`s. There are still 11 calls to `addPartition` in this class.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/#review73762
-----------------------------------------------------------
On Feb. 24, 2015, 6:19 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31223/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 6:19 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-338
> https://issues.apache.org/jira/browse/LENS-338
>
>
> Repository: lens
>
>
> Description
> -------
>
> server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
>
> There is new path: ` @Path("/facts/{factName}/storages/{storage}/partition")` which adds a single partition
>
> Current implementation:
> ```
> MetastoreResource#addPartitionsToDim -> CubeMetastoreService#addPartitionsToDim -> CubeMetastoreClient#addPartitions
> MetastoreResource#addPartitionsToFact -> CubeMetastoreService#addPartitionsToFact -> CubeMetastoreClient#addPartitions
> MetastoreResource#addPartitionToDim -> CubeMetastoreService#addPartitionToDim -> CubeMetastoreClient#addPartition
> MetastoreResource#addPartitionToFact -> CubeMetastoreService#addPartitionToFact -> CubeMetastoreClient#addPartition
> ```
>
> Inside `CubeMetastoreClient` paths merge. Currently `addPartitions` calls `addPartition` in loop. Will keep it like this in this jira. In a later jira, `addPartitions` will be optimized api and won't call `addPartition`. A design choice can be made over whether to implement `addPartition` using `addPartitions`.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 6336b9e8320cb0826a5c568a36b0bf5379f61608
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java f54d8be586546d10e55705e25416e7561269be39
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 01afbf31521d0f8e80ef7e1e5aa82f5b39afc23e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 0d345940d34e02129117c0e6de7c7a7d5cdb4c51
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java c7ed03df5ccad74108a09afb6c86618b4fe0a913
> lens-cli/src/test/resources/dim1-local-parts.xml PRE-CREATION
> lens-cli/src/test/resources/fact1-local-parts.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 0c5db747b41a906fd0c786ae87f85ec4b0927e02
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
>
> Diff: https://reviews.apache.org/r/31223/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.158s]
> [INFO] Lens .............................................. SUCCESS [1.868s]
> [INFO] Lens API .......................................... SUCCESS [5.609s]
> [INFO] Lens API for server and extensions ................ SUCCESS [5.213s]
> [INFO] Lens Cube ......................................... SUCCESS [6:17.935s]
> [INFO] Lens DB storage ................................... SUCCESS [9.538s]
> [INFO] Lens Query Library ................................ SUCCESS [4.595s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:38.363s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [24.264s]
> [INFO] Lens Server ....................................... SUCCESS [4:09.211s]
> [INFO] Lens client ....................................... SUCCESS [20.951s]
> [INFO] Lens CLI .......................................... SUCCESS [1:37.758s]
> [INFO] Lens Examples ..................................... SUCCESS [0.832s]
> [INFO] Lens Distribution ................................. SUCCESS [9.990s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.381s]
> [INFO] Lens Regression ................................... SUCCESS [0.487s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/#review73762
-----------------------------------------------------------
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java
<https://reviews.apache.org/r/31223/#comment120142>
Add api for addPartitions as well.
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
<https://reviews.apache.org/r/31223/#comment120143>
Is there any test for addPartition itself? I see all the callers are removed here
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java
<https://reviews.apache.org/r/31223/#comment120144>
Include both addPartition and addPartitions api
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java
<https://reviews.apache.org/r/31223/#comment120145>
Please update documentation in cube-0.1.xsd :
Right now, it is
----
<xs:element name="x_partition_list" type="x_partition_list" />
<xs:complexType name="x_partition_list">
<xs:annotation>
<xs:documentation>
LENS uses this type to return the list of all partitions. Should not be used by end-user directly.
</xs:documentation>
</xs:annotation>
<xs:sequence>
<xs:element name="partition" type="x_partition" maxOccurs="unbounded" minOccurs="0" />
</xs:sequence>
</xs:complexType>
----
- Amareshwari Sriramadasu
On Feb. 23, 2015, 2:15 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31223/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 2:15 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-338
> https://issues.apache.org/jira/browse/LENS-338
>
>
> Repository: lens
>
>
> Description
> -------
>
> server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
>
> There is new path: ` @Path("/facts/{factName}/storages/{storage}/partitions")` which adds a single partition
>
> CubeMetastoreService api has both: addPartition and addPartitions.
>
> Code paths merge at the earliest point: in the resource file. Metastore service api has only `addPartitions`
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
>
> Diff: https://reviews.apache.org/r/31223/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.158s]
> [INFO] Lens .............................................. SUCCESS [1.868s]
> [INFO] Lens API .......................................... SUCCESS [5.609s]
> [INFO] Lens API for server and extensions ................ SUCCESS [5.213s]
> [INFO] Lens Cube ......................................... SUCCESS [6:17.935s]
> [INFO] Lens DB storage ................................... SUCCESS [9.538s]
> [INFO] Lens Query Library ................................ SUCCESS [4.595s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:38.363s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [24.264s]
> [INFO] Lens Server ....................................... SUCCESS [4:09.211s]
> [INFO] Lens client ....................................... SUCCESS [20.951s]
> [INFO] Lens CLI .......................................... SUCCESS [1:37.758s]
> [INFO] Lens Examples ..................................... SUCCESS [0.832s]
> [INFO] Lens Distribution ................................. SUCCESS [9.990s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.381s]
> [INFO] Lens Regression ................................... SUCCESS [0.487s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/#review73763
-----------------------------------------------------------
Update description wrt compatibility. And the path for single partition seems wrong in the description.
- Amareshwari Sriramadasu
On Feb. 23, 2015, 2:15 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31223/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 2:15 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-338
> https://issues.apache.org/jira/browse/LENS-338
>
>
> Repository: lens
>
>
> Description
> -------
>
> server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
>
> There is new path: ` @Path("/facts/{factName}/storages/{storage}/partitions")` which adds a single partition
>
> CubeMetastoreService api has both: addPartition and addPartitions.
>
> Code paths merge at the earliest point: in the resource file. Metastore service api has only `addPartitions`
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
>
> Diff: https://reviews.apache.org/r/31223/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.158s]
> [INFO] Lens .............................................. SUCCESS [1.868s]
> [INFO] Lens API .......................................... SUCCESS [5.609s]
> [INFO] Lens API for server and extensions ................ SUCCESS [5.213s]
> [INFO] Lens Cube ......................................... SUCCESS [6:17.935s]
> [INFO] Lens DB storage ................................... SUCCESS [9.538s]
> [INFO] Lens Query Library ................................ SUCCESS [4.595s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:38.363s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [24.264s]
> [INFO] Lens Server ....................................... SUCCESS [4:09.211s]
> [INFO] Lens client ....................................... SUCCESS [20.951s]
> [INFO] Lens CLI .......................................... SUCCESS [1:37.758s]
> [INFO] Lens Examples ..................................... SUCCESS [0.832s]
> [INFO] Lens Distribution ................................. SUCCESS [9.990s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.381s]
> [INFO] Lens Regression ................................... SUCCESS [0.487s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/
-----------------------------------------------------------
(Updated Feb. 23, 2015, 7:45 p.m.)
Review request for lens.
Bugs: LENS-338
https://issues.apache.org/jira/browse/LENS-338
Repository: lens
Description (updated)
-------
server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
There is new path: ` @Path("/facts/{factName}/storages/{storage}/partitions")` which adds a single partition
CubeMetastoreService api has both: addPartition and addPartitions.
Code paths merge at the earliest point: in the resource file. Metastore service api has only `addPartitions`
Diffs (updated)
-----
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a13a22072abb99d347eb5f9bdd1927042d4e2c74
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
Diff: https://reviews.apache.org/r/31223/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.158s]
[INFO] Lens .............................................. SUCCESS [1.868s]
[INFO] Lens API .......................................... SUCCESS [5.609s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.213s]
[INFO] Lens Cube ......................................... SUCCESS [6:17.935s]
[INFO] Lens DB storage ................................... SUCCESS [9.538s]
[INFO] Lens Query Library ................................ SUCCESS [4.595s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:38.363s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [24.264s]
[INFO] Lens Server ....................................... SUCCESS [4:09.211s]
[INFO] Lens client ....................................... SUCCESS [20.951s]
[INFO] Lens CLI .......................................... SUCCESS [1:37.758s]
[INFO] Lens Examples ..................................... SUCCESS [0.832s]
[INFO] Lens Distribution ................................. SUCCESS [9.990s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.381s]
[INFO] Lens Regression ................................... SUCCESS [0.487s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 31223: LENS-338: provide addPartitions API
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31223/
-----------------------------------------------------------
(Updated Feb. 20, 2015, 9:45 p.m.)
Review request for lens.
Bugs: LENS-338
https://issues.apache.org/jira/browse/LENS-338
Repository: lens
Description
-------
server api to add partitions now expects XPartitionList, not XPartition. This will break backward compatibility.
CubeMetastoreService api has both: addPartition and addPartitions.
cli tests accordingly modified to provide XPartitionList.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java c920afbccabd5ea414330173b7a2faa6c3c38800
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 7542fc95a1ffa1cc029c2bc89b89426002f45c9c
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java fd377ea46db361feaa36ad106d68b0cc7b04ec6e
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java eb08c8e82e60afb33d3f426361fd2ea1a71b19f4
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 4265250f44264bb518e5d81dd14ff54ce423af9f
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 488729789e4c5f4aa2f02c96588d9015c8447d99
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 7148a77eb28a78c6adce73fc36941cd40b7fc368
Diff: https://reviews.apache.org/r/31223/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.502s]
[INFO] Lens .............................................. SUCCESS [2.482s]
[INFO] Lens API .......................................... SUCCESS [7.334s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.867s]
[INFO] Lens Cube ......................................... SUCCESS [6:35.322s]
[INFO] Lens DB storage ................................... SUCCESS [10.131s]
[INFO] Lens Query Library ................................ SUCCESS [4.348s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:34.139s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [23.363s]
[INFO] Lens Server ....................................... SUCCESS [4:18.394s]
[INFO] Lens client ....................................... SUCCESS [19.881s]
[INFO] Lens CLI .......................................... SUCCESS [1:40.598s]
[INFO] Lens Examples ..................................... SUCCESS [0.844s]
[INFO] Lens Distribution ................................. SUCCESS [9.627s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.523s]
[INFO] Lens Regression ................................... SUCCESS [0.480s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:18.795s
[INFO] Finished at: Fri Feb 20 16:13:52 UTC 2015
[INFO] Final Memory: 109M/971M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal