You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/12 09:44:33 UTC
[GitHub] [skywalking-rocketbot-ui] Fine0830 opened a new pull request #339: Feat: Support tag conditions for trace
Fine0830 opened a new pull request #339:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/339
Support tag conditions for trace. Reference https://github.com/apache/skywalking/issues/5272
Screenshots
Signed-off-by: Qiuxia Fan <qi...@apache.org>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #339: Feat: Support tag conditions for trace
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #339:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/339#issuecomment-672783631
> Please give a separate line for the tag condition, because users usually use multiple tags.
>
> And could you show me, how to input the tag(key=vlaue)? Such as, please consider value could include `white space` in some cases. Traditionally, the interactive style is, user gives `key=value`, value could be anything following the first `=`. Then use `enter` to confirm the condition added. And you would have an `x` after the condition set. I think you used to do similar things in the comparison page.
For multiple tags, we use a separate comma. As follow,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #339: Feat: Support tag conditions for trace
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #339:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/339#issuecomment-673916178
@Fine0830 Please sync the main repo, I could update the demo env later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #339: Feat: Support tag conditions for trace
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #339:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/339#issuecomment-673395064
The pr was updated, please recheck @wu-sheng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #339: Feat: Support tag conditions for trace
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #339:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/339#issuecomment-672775005
Please give a separate line for the tag condition, because users usually use multiple tags.
And could you show me, how to input the tag(key=vlaue)? Such as, please consider value could include `white space` in some cases. Traditionally, the interactive style is, user gives `key=value`, value could be anything following the first `=`. Then use `enter` to confirm the condition added. And you would have an `x` after the condition set. I think you used to do similar things in the comparison page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #339: Feat: Support tag conditions for trace
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #339:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/339#issuecomment-672876098
The way I suggested because we don't know comma or whitespace whether be a part of tag value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #339: Feat: Support tag conditions for trace
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #339:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/339
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org